Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): avoid directly importing vue-router inside <NuxtLayout> - #8421

Merged
pi0 merged 3 commits into
mainfrom
fix/router-layout
Oct 24, 2022
Merged

fix(nuxt): avoid directly importing vue-router inside <NuxtLayout>#8421
pi0 merged 3 commits into
mainfrom
fix/router-layout

Conversation

@danielroe

@danielroedanielroe commented Oct 23, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#15236

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

As noted in #8133, this follows up to remove a vue-router dependency from all use of <NuxtLayout>.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working pages 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Oct 23, 2022
@danielroedanielroe self-assigned this Oct 23, 2022
@codesandbox

codesandboxBot commented Oct 23, 2022

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Oct 23, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commitf2e3b21
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/63564be29844660009e7734f

pi0
pi0 reviewed Oct 24, 2022
View reviewed changes
Comment threadpackages/nuxt/src/pages/module.ts
@danielroe
danielroe requested a review from pi0October 24, 2022 08:25
pi0
pi0 approved these changes Oct 24, 2022
View reviewed changes
@pi0pi0 changed the title fix(nuxt): don't use vue-router without pages/ integrationfix(nuxt): avoid directly importing vue-router inside <NuxtLayout>Oct 24, 2022
@pi0
pi0 merged commit 6bcd9cd into mainOct 24, 2022
@pi0
pi0 deleted the fix/router-layout branch October 24, 2022 08:36
@pi0pi0 mentioned this pull request Nov 3, 2022
Merged
@misaonmisaon mentioned this pull request Nov 11, 2022
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@atinuxatinuxatinux approved these changes
@pi0pi0pi0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@danielroedanielroe

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usagepages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

<NuxtLayout> does not work without pages/ integration

3 participants

@danielroe@atinux@pi0