Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(test-utils): override NITRO_PORT as well - #8458

Merged
pi0 merged 1 commit into
mainfrom
fix/test-port
Oct 25, 2022
Merged

fix(test-utils): override NITRO_PORT as well#8458
pi0 merged 1 commit into
mainfrom
fix/test-port

Conversation

@danielroe

@danielroedanielroe commented Oct 25, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#15183

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

We override PORT but also need to override NITRO_PORT if this is set by the user in an .env file.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage test-utils labels Oct 25, 2022
@danielroe
danielroe requested a review from pi0October 25, 2022 09:15
@danielroedanielroe self-assigned this Oct 25, 2022
@codesandbox

codesandboxBot commented Oct 25, 2022

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Oct 25, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commiteacf73b
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/6357a91a8c5b010008783635

pi0
pi0 approved these changes Oct 25, 2022
View reviewed changes
@pi0
pi0 merged commit 452766e into mainOct 25, 2022
@pi0
pi0 deleted the fix/test-port branch October 25, 2022 09:17
@pi0pi0 mentioned this pull request Nov 3, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@pi0pi0pi0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@danielroedanielroe

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usagetest-utils

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NITRO_PORT cause setup() failed in test

2 participants

@danielroe@pi0