Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

feat(nuxt): add dev warnings when setPageLayout is used incorrectly - #8464

Merged
pi0 merged 1 commit into
mainfrom
feat/set-layout-warnings
Oct 25, 2022
Merged

feat(nuxt): add dev warnings when setPageLayout is used incorrectly#8464
pi0 merged 1 commit into
mainfrom
feat/set-layout-warnings

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#15176

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR adds warnings in dev mode when setPageLayout is used in a location where it will cause a hydration mismatch.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added enhancement New feature or request dx labels Oct 25, 2022
@danielroe
danielroe requested a review from pi0October 25, 2022 12:09
@danielroedanielroe self-assigned this Oct 25, 2022
@codesandbox

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Oct 25, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit973b1b8
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/6357d1de78b5280009a4a2a5

pi0
pi0 approved these changes Oct 25, 2022
@pi0
pi0 merged commit 91eab1b into mainOct 25, 2022
@pi0
pi0 deleted the feat/set-layout-warnings branch October 25, 2022 12:25
@pi0pi0 mentioned this pull request Nov 3, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xdxenhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Calling setPageLayout() before page mount does not render properly

2 participants

@danielroe@pi0