Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): call data refresh hook in parallel - #8470

Merged
pi0 merged 1 commit into
mainfrom
fix/parallel-refresh
Oct 25, 2022
Merged

fix(nuxt): call data refresh hook in parallel#8470
pi0 merged 1 commit into
mainfrom
fix/parallel-refresh

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#15256

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

It seems reasonable not to call refresh serially/waterfull. (If fully parallel isn't right, we could also batch this.)

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage performance labels Oct 25, 2022
@danielroe
danielroe requested a review from pi0October 25, 2022 14:32
@danielroedanielroe self-assigned this Oct 25, 2022
pi0
pi0 approved these changes Oct 25, 2022

@pi0pi0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@pi0
pi0 merged commit 1d795f0 into mainOct 25, 2022
@pi0
pi0 deleted the fix/parallel-refresh branch October 25, 2022 15:29
@pi0pi0 mentioned this pull request Nov 3, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.x🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usageperformance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

perf of refreshNuxtData waterfall is a very unpleasant

2 participants

@danielroe@pi0