Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(kit): don't require nuxt when resolving path - #8504

Merged
pi0 merged 1 commit into
mainfrom
fix/resolve-path-nuxt-optional
Oct 26, 2022
Merged

fix(kit): don't require nuxt when resolving path#8504
pi0 merged 1 commit into
mainfrom
fix/resolve-path-nuxt-optional

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Currently if nuxt instance is not present when calling resolvePath, we will throw an error. We already check for existence, so this was likely not intended.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working kit labels Oct 26, 2022
@danielroe
danielroe requested a review from pi0October 26, 2022 13:53
@danielroedanielroe self-assigned this Oct 26, 2022
@codesandbox

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Oct 26, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit73f4be7
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/63593bf900a36e00084ea49f

pi0
pi0 approved these changes Oct 26, 2022
@pi0
pi0 merged commit 2284525 into mainOct 26, 2022
@pi0
pi0 deleted the fix/resolve-path-nuxt-optional branch October 26, 2022 13:55
@pi0pi0 mentioned this pull request Nov 3, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't workingkit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@danielroe@pi0