Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
fix(nuxt): check before appending comma in composable keys - #8529
Merged
Conversation
|
✅ Deploy Preview for nuxt3-docs canceled.
|
pi0
reviewed
Nov 2, 2022
| break | ||
| } | ||
| const endsWithComma = code.slice(codeIndex + (node as any).start, codeIndex + (node as any).end - 1).trim().endsWith(',') |
Member
There was a problem hiding this comment.
Perf: this is a heavy operation to run on each code block, copying the whole string, trimming (that also copies) to only check the last character is ,. We could replace it with a look-behind loop.
Suggested change
| constendsWithComma=code.slice(codeIndex+(nodeasany).start,codeIndex+(nodeasany).end-1).trim().endsWith(',') | |
| // TODO: Optimize me (https://github.com/nuxt/framework/pull/8529) | |
| constendsWithComma=code.slice(codeIndex+(nodeasany).start,codeIndex+(nodeasany).end-1).trim().endsWith(',') |
pi0
approved these changes
Nov 2, 2022
Merged
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolvesnuxt/nuxt#15272
❓ Type of change
📚 Description
We were previously not confirming whether there was a trailing comma before appending our own.
📝 Checklist