Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): add vue-router to optimized deps - #8544

Merged
pi0 merged 1 commit into
mainfrom
fix/optimize-router
Nov 2, 2022
Merged

fix(nuxt): add vue-router to optimized deps#8544
pi0 merged 1 commit into
mainfrom
fix/optimize-router

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#15288

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

It seems that we could end up with multiple versions of vue-router when optimising dependencies, and therefore have mismatching route symbols.

This PR ensures that when using the pages integration we process the router first.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Oct 28, 2022
@danielroe
danielroe requested a review from pi0October 28, 2022 03:28
@danielroedanielroe self-assigned this Oct 28, 2022
@codesandbox

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Oct 28, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit91670a5
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/635b4c7cb1027100083297fa

@pi0
pi0 merged commit 28ffb7f into mainNov 2, 2022
@pi0
pi0 deleted the fix/optimize-router branch November 2, 2022 08:53
@pi0pi0 mentioned this pull request Nov 3, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

injection "Symbol(route location)" not found

2 participants

@danielroe@pi0