Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): resolve ids to support pnpm - #8671

Merged
pi0 merged 2 commits into
mainfrom
fix/pnpm-implicit
Nov 3, 2022
Merged

fix(nuxt): resolve ids to support pnpm#8671
pi0 merged 2 commits into
mainfrom
fix/pnpm-implicit

Conversation

@pi0

@pi0pi0 commented Nov 3, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

nuxt/nuxt#14146

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Since paths.mjs and app.config.mjs templates are directly written to .nuxt directory, their implicit (defu and ufo) dependencies need to be already resolved. This almost fixes pnpm support!

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0pi0 changed the title fix: resolve ids to support pnpmfix(nuxt): resolve ids to support pnpmNov 3, 2022
@netlify

netlifyBot commented Nov 3, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commit3cf35ae
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/63642c9e16b2440009b196a9
😎 Deploy Previewhttps://deploy-preview-8671--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pi0

pi0 commented Nov 3, 2022

Copy link
Copy Markdown
MemberAuthor

(it seems we have way to go btw)

@pi0
pi0 merged commit 9eb6a62 into mainNov 3, 2022
@pi0
pi0 deleted the fix/pnpm-implicit branch November 3, 2022 21:48
@pi0pi0 mentioned this pull request Nov 3, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@pi0@danielroe