Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): ensure payload url has no protocol - #8675

Merged
pi0 merged 3 commits into
mainfrom
fix/payload-proto
Nov 3, 2022
Merged

fix(nuxt): ensure payload url has no protocol#8675
pi0 merged 3 commits into
mainfrom
fix/payload-proto

Conversation

@pi0

@pi0pi0 commented Nov 3, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Use URL parser to extract pathname from URL for internal _getPayloadURL utility and ensure input does not contain hostname or search params.

Previously an invalid URL like loadPayload('/\\example.com') could be passed.

Credits to @OhB00 for discovering this.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Nov 3, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit4fd9a8c
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/63643eeffea91b0008e8a485

@pi0
pi0 merged commit 19a2cd1 into mainNov 3, 2022
@pi0
pi0 deleted the fix/payload-proto branch November 3, 2022 22:28
@pi0pi0 mentioned this pull request Nov 3, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@pi0@danielroe