Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
fix: correct default scroll behavior for routes without page transition - #8701
Closed
greimela wants to merge 1 commit into
Closed
fix: correct default scroll behavior for routes without page transition#8701greimela wants to merge 1 commit into
greimela wants to merge 1 commit into
Conversation
Related issue: https://github.com/nuxt/framework/issues/8699 `router.options.ts` falsely thinks that an `undefined` page transition is `true`, meaning it HAS a transition. Whereas `page.mjs` correctly interprets an `undefined` transition as `false`.
|
✅ Deploy Preview for nuxt3-docs canceled.
|
atinux
commented
Nov 4, 2022
Member
greimela
commented
Nov 4, 2022
Author
@atinux Oh no! 😅 But I don't mind, as long as it's getting fixed! 😉 |
pi0
commented
Nov 4, 2022
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
nuxt/nuxt#15364
❓ Type of change
📚 Description
router.options.tsfalsely determines that anundefinedpage transition istrue, meaning it HAS a transition.Whereas
page.mjscorrectly interprets anundefinedtransition asfalse.This commit changes the condition in
router.options.tsto consider anundefinedtransition asfalse.Resolvesnuxt/nuxt#15364
📝 Checklist