Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

refactor(nuxt)!: fix typo for NuxtRenderHTMLContext.bodyPrepend - #8712

Merged
pi0 merged 1 commit into
nuxt:mainfrom
agenordebriat:patch-1
Nov 7, 2022
Merged

refactor(nuxt)!: fix typo for NuxtRenderHTMLContext.bodyPrepend#8712
pi0 merged 1 commit into
nuxt:mainfrom
agenordebriat:patch-1

Conversation

@agenordebriat

@agenordebriatagenordebriat commented Nov 4, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

🔗 Linked issue

No issue.

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Tried to use Nitro's render:html hook in a server plugin and noticed bodyPrepend was actually bodyPreprend.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox

codesandboxBot commented Nov 4, 2022

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Nov 4, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit0132ecc
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/63658b3e6e53bd0008eaaefc

@agenordebriatagenordebriat changed the title chore(nuxt): fix typochore(nuxt)!: fix typoNov 4, 2022
danielroe
danielroe approved these changes Nov 5, 2022
View reviewed changes

@danielroedanielroe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ❤️

@atinux
atinux requested a review from pi0November 5, 2022 09:45
@TheAlexLichter

TheAlexLichter commented Nov 5, 2022

Copy link
Copy Markdown
Member

We have 2 PRs fixing the same thing here - #8704

@pi0pi0 changed the title chore(nuxt)!: fix typorefactor(nuxt)!: fix typoNov 7, 2022
pi0
pi0 approved these changes Nov 7, 2022
View reviewed changes
@pi0pi0 changed the title refactor(nuxt)!: fix typorefactor(nuxt)!: fix typo for NuxtRenderHTMLContext.bodyPrependNov 7, 2022
@pi0
pi0 merged commit b60f136 into nuxt:mainNov 7, 2022
@pi0

pi0 commented Nov 7, 2022

Copy link
Copy Markdown
Member

Nice spot. Thanks!

@pi0

pi0 commented Nov 7, 2022

Copy link
Copy Markdown
Member

We have 2 PRs fixing the same thing here - #8704

Merged twice to keep credits :)

@pi0pi0 mentioned this pull request Nov 15, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@pi0pi0pi0 approved these changes
@danielroedanielroedanielroe approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@agenordebriat@TheAlexLichter@pi0@danielroe