fix(nuxt): use parser to treeshake `<ClientOnly>` by huang-julien · Pull Request #8713 · nuxt/framework

huang-julien · 2022-11-04T22:45:56Z

🔗 Linked issue

resolvenuxt/nuxt#15227
resolvenuxt/nuxt#15396
closes#8789 (by including it)

❓ Type of change

📖 Documentation (updates to the documentation or readme)
🐞 Bug fix (a non-breaking change that fixes an issue)
👌 Enhancement (improving an existing functionality like performance)
✨ New feature (a non-breaking change that adds functionality)
⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

hi 👋 , i think this should fixnuxt/nuxt#15227.
Instead of treeshaking the default slot before SFC compilation.
This PR:

move the module before the component loader plugin (to avoid having extra imports to remove)
enforce post, this way the scoped attributes will be already added when modifying the code
remove the default slot of ClientOnly components
remove components direct import (or Identifier) based on if they are called only in the removed code.
it also remove the components from the setup return statement (mostly in dev)

Test:

This also adds a test to ensure that style are corretly applied once on client.

let me know what you think of this 🙂

todo:

change the regex to test _component_ and unref() (resolve and direct import)

📝 Checklist

I have linked an issue or discussion.
I have updated the documentation accordingly.

codesandbox · 2022-11-04T22:45:58Z

Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

netlify · 2022-11-04T22:46:00Z

✅ Deploy Preview for nuxt3-docs ready!

Name	Link
🔨 Latest commit	`21543b2`
🔍 Latest deploy log	https://app.netlify.com/sites/nuxt3-docs/deploys/636e77ad7e84eb00081d3445
😎 Deploy Preview	https://deploy-preview-8713--nuxt3-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

danielroe

Thanks for working on this!

socket-security · 2022-11-06T09:28:35Z

Socket Security Pull Request Report

👍 No new dependency issues detected in pull request

Pull request report summary

Issue	Status
Install scripts	✅ 0 issues
Native code	✅ 0 issues
Bin script confusion	✅ 0 issues
Bin script shell injection	✅ 0 issues
Unresolved require	✅ 0 issues
Invalid package.json	✅ 0 issues
HTTP dependency	✅ 0 issues
Git dependency	✅ 0 issues
Potential typo squat	✅ 0 issues
Known Malware	✅ 0 issues
Telemetry	✅ 0 issues
Protestware/Troll package	✅ 0 issues

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@2.4.2

Powered by socket.dev

pi0 · 2022-11-15T17:19:11Z

@danielroe What is status of this PR?

Co-authored-by: Daniel Roe <daniel@roe.dev>

…ving to ';'

…lyStyle

danielroe

The latest snapshot test failure is likely due to a vue or vite plugin vue upgrade - it's replicable with latest node_modules even undoing the merge commit.

Would you be able to have a look? 🙏

huang-julien · 2023-02-08T00:08:31Z

@danielroe Did the CI failed due to 2 timeout ?
Couldn't reproduce it in local

commit 1729d2e Author: Julien Huang <julien.huang@outlook.fr> Date: Wed Mar 8 22:13:06 2023 +0100 feat(nuxt): add `<NuxtClientFallback>` component (nuxt#8216) commit c4222b1 Author: Sébastien Chopin <seb@nuxt.com> Date: Wed Mar 8 17:06:22 2023 +0100 docs: fix local modules commit 8732720 Author: Harlan Wilton <harlan@harlanzw.com> Date: Thu Mar 9 02:32:24 2023 +1100 perf(head): drop `@vueuse/head` dependency (#19519) commit df3ae8c Author: Daniel Roe <daniel@roe.dev> Date: Wed Mar 8 12:17:22 2023 +0000 feat(nuxt): enable chunk error handling by default (#19086) commit 6243146 Author: Anthony Fu <anthonyfu117@hotmail.com> Date: Wed Mar 8 12:56:41 2023 +0100 feat(vite): use custom logger to show vite logs (#19523) commit e344321 Author: Sebastian Landwehr <info@sebastianlandwehr.com> Date: Wed Mar 8 12:32:00 2023 +0100 feat(cli): programmatically pass nuxt config overrides (to dev) (#19371) commit c2ab76d Author: Daniel Roe <daniel@roe.dev> Date: Tue Mar 7 22:51:08 2023 +0000 perf(vite): mark more core functions as side-effect free (#19508) commit 0b82f67 Author: Daniel Roe <daniel@roe.dev> Date: Tue Mar 7 21:36:58 2023 +0000 chore: force minor bumps at most commit 60d07df Author: Daniel Roe <daniel@roe.dev> Date: Tue Mar 7 21:06:15 2023 +0000 feat(nuxt): support custom keyed composables (#19490) commit faeffcb Author: Daniel Roe <daniel@roe.dev> Date: Tue Mar 7 17:46:25 2023 +0000 docs: add new release cycle info (#19509) commit 01a6f17 Author: Clément Ollivier <clement.o2p@gmail.com> Date: Tue Mar 7 17:55:18 2023 +0100 docs: update pr template to include jsdoc annotations (#19511) commit 6c53c8b Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Tue Mar 7 06:25:27 2023 -0800 chore(deps)!: update dependency fork-ts-checker-webpack-plugin to v8 (main) (#19468) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Daniel Roe <daniel@roe.dev> BREAKING CHANGE: Using the webpack builder, `typescript.typeCheck` has not been properly type-checking vue files _anyway_, so this shouldn't be a breaking change. But the underlying plugin we have been using (`fork-ts-checker-webpack-plugin`) has now formally removed support for type-checking `.vue` files to make this clearer. commit 06b9233 Author: Daniel Roe <daniel@roe.dev> Date: Tue Mar 7 12:20:43 2023 +0000 docs: update cli docs for `--log-level` commit 3f1e023 Author: Jakub Andrzejewski <37120330+Baroshem@users.noreply.github.com> Date: Tue Mar 7 13:18:47 2023 +0100 feat(nuxi,schema): add support for setting nuxt `logLevel` (#19369) commit fe14961 Author: Clément Ollivier <clement.o2p@gmail.com> Date: Tue Mar 7 12:12:54 2023 +0100 docs: update `addComponent` jsdoc comment (#19503) commit 6748211 Author: Paulius Varna <paul.varna@gmail.com> Date: Tue Mar 7 11:45:07 2023 +0200 docs: add info `~/server/utils` directory in `~/utils` page (#19500) commit bb61496 Author: Harlan Wilton <harlan@harlanzw.com> Date: Tue Mar 7 20:30:05 2023 +1100 feat(nuxt): allow configuring treeshakeable composables (#19383) commit 3a73f42 Author: Alex Korytskyi <alexander.korytskyi@gmail.com> Date: Tue Mar 7 09:17:42 2023 +0200 feat(nuxt): support `trailingSlashBehavior` in `defineNuxtLink` (#19458) commit b9e6980 Author: Samuel DIDIER-LAURENT <iStuffs@users.noreply.github.com> Date: Mon Mar 6 23:54:40 2023 +0100 docs: update `devServer.https` example (#19486) commit abcd27a Author: Daniel Roe <daniel@roe.dev> Date: Mon Mar 6 22:20:07 2023 +0000 chore: restrict commit hash strings to 8 chars resolves #19488 commit 4f61e36 Author: pooya parsa <pyapar@gmail.com> Date: Mon Mar 6 15:42:20 2023 +0100 fix(cli): handle different kind of shutdown signals (#19485) commit d4f443a Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Mar 6 03:34:45 2023 -0800 chore(deps): update all non-major dependencies (main) (#19472) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit ca32852 Author: Alex Liu <dsa1314@gmail.com> Date: Mon Mar 6 19:34:17 2023 +0800 feat(nuxt): enable preloading object-syntax routes (#19120) commit 129bb4f Author: Daniel Roe <daniel@roe.dev> Date: Mon Mar 6 11:33:40 2023 +0000 feat(kit,nuxt): add component `priority` to allow overriding (#19252) commit a7d75a8 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sun Mar 5 12:59:50 2023 -0800 chore(deps): update all non-major dependencies to ^1.1.16 (main) (#19466) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Daniel Roe <daniel@roe.dev> commit 4310d2a Author: Alexander Lichter <github@lichter.io> Date: Sun Mar 5 15:42:16 2023 +0100 docs: fix dead link to useSeoMeta guide (#19463) commit a670e07 Author: Alexander Lichter <github@lichter.io> Date: Sun Mar 5 11:10:56 2023 +0100 docs: fix link to nitro `routeRules` (#19455) commit 5977adb Author: Sébastien Chopin <seb@nuxtlabs.com> Date: Sun Mar 5 10:51:10 2023 +0100 docs: add local modules ordering commit b73ca91 Author: Daniel Roe <daniel@roe.dev> Date: Sat Mar 4 15:10:40 2023 +0000 fix(kit): match commit hashes of other lengths (#19450) commit 71225e5 Author: pooya parsa <pyapar@gmail.com> Date: Sat Mar 4 15:39:26 2023 +0100 feat(nuxt): enable config schema by default (#19172) commit 44d4aba Author: Daniel Roe <daniel@roe.dev> Date: Sat Mar 4 14:34:34 2023 +0000 docs: add edge banners on `versions` and modules (#19448) commit f14b896 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sat Mar 4 06:34:20 2023 -0800 chore(deps): update all non-major dependencies (main) (#19439) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 4aa35b6 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Fri Mar 3 20:07:45 2023 +0000 chore(deps): update devdependency changelogen to ^0.5.0 (main) (#19433) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 8fa3fba Author: pooya parsa <pyapar@gmail.com> Date: Fri Mar 3 20:24:49 2023 +0100 refactor(nuxi): hard restart with communication channel (#19423) commit 3681bdd Author: Daniel Roe <daniel@roe.dev> Date: Fri Mar 3 17:52:55 2023 +0000 feat(nuxt): auto-register modules in `~/modules` (#19394) commit a420369 Author: Daniel Roe <daniel@roe.dev> Date: Fri Mar 3 16:47:08 2023 +0000 fix(nuxt): don't print layout warning if page is not ssr (#19434) commit 588c3ff Author: Horu <73709188+HigherOrderLogic@users.noreply.github.com> Date: Fri Mar 3 23:04:03 2023 +0700 fix(nuxt): add `kit.*` files to published package (#19430) commit 008426c Author: Sébastien Chopin <seb@nuxt.com> Date: Fri Mar 3 16:40:47 2023 +0100 docs: add frontmatter note for docs readme to remove from live preview commit bc9ffa4 Author: Daniel Roe <daniel@roe.dev> Date: Fri Mar 3 14:48:04 2023 +0000 feat(nuxt): add support for `nuxt/kit` subpath for local use (#19422) commit 7131aef Author: Ivan <rebyatyonok@yandex.com> Date: Fri Mar 3 17:07:42 2023 +0300 feat(schema): allow adding page routes without a matching file (#19173) commit 4406842 Author: Daniel Roe <daniel@roe.dev> Date: Fri Mar 3 13:51:47 2023 +0000 fix(nuxi): avoid top-level await in wrapper commit db5ea91 Author: Anthony Fu <anthonyfu117@hotmail.com> Date: Fri Mar 3 14:45:38 2023 +0100 feat(nuxi): cli wrapper for self restart (#18641) commit 78f1c33 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Fri Mar 3 11:35:59 2023 +0000 chore(deps): update devdependency @types/node to ^18.14.5 (main) (#19409) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 93c31cf Author: Xin Du (Clark) <clark.duxin@gmail.com> Date: Fri Mar 3 10:58:15 2023 +0000 chore: mark `@nuxt/test-utils` package as external group (#19419) commit 842c4e6 Author: Xin Du (Clark) <clark.duxin@gmail.com> Date: Fri Mar 3 10:57:56 2023 +0000 chore: add chore to type of change in pr template (#19420) commit e11d55a Author: Daniel Roe <daniel@roe.dev> Date: Fri Mar 3 10:45:47 2023 +0000 ci: fetch git history commit 6084f64 Author: Stefan <stefan.heim@hotmail.com> Date: Fri Mar 3 11:40:24 2023 +0100 fix(nuxt): pass transform options to component loader plugin (#19414) commit 73ade18 Author: Daniel Roe <daniel@roe.dev> Date: Fri Mar 3 10:35:25 2023 +0000 fix(vite): omit `/` from `sourcemapIgnoreList` for windows support commit 1712885 Author: Daniel Roe <daniel@roe.dev> Date: Fri Mar 3 10:34:47 2023 +0000 chore: add branch to edge release script commit 654b9a2 Author: Xin Du (Clark) <clark.duxin@gmail.com> Date: Fri Mar 3 10:20:15 2023 +0000 fix(schema): update vite `import.meta` types (#19338) commit 2cf5f48 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Fri Mar 3 06:46:30 2023 +0000 chore(deps): update all non-major dependencies (main) (#19404) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit f3c82d5 Author: Daniel Roe <daniel@roe.dev> Date: Thu Mar 2 16:57:55 2023 +0000 chore: bump edge version based on commits (#19397) commit e3fe706 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Thu Mar 2 08:54:03 2023 -0800 chore(deps): update all non-major dependencies to ^1.1.15 (main) (#19395) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 21e3e17 Author: Daniel Roe <daniel@roe.dev> Date: Thu Mar 2 15:28:15 2023 +0000 feat(vite): add `node_modules` and buildDir to `x_google_ignoreList` (#19243) commit 3475f36 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Thu Mar 2 02:18:50 2023 -0800 chore(deps): update all non-major dependencies (main) (#19374) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Daniel Roe <daniel@roe.dev> commit 0be8cda Author: Lucie <25330882+lihbr@users.noreply.github.com> Date: Thu Mar 2 10:53:46 2023 +0100 fix(nuxt): prevent fallthrough attributes on custom `NuxtLink` (#19379) commit d4a7524 Author: Daniel Roe <daniel@roe.dev> Date: Wed Mar 1 15:08:23 2023 +0000 feat(nuxt): add `versions` to runtime nuxtApp (#19064) commit c35104c Author: Daniel Roe <daniel@roe.dev> Date: Wed Mar 1 13:58:33 2023 +0000 docs: update esm link commit 59918f5 Author: Anthony Fu <anthonyfu117@hotmail.com> Date: Wed Mar 1 13:24:46 2023 +0100 feat(nuxt): scan composables with star export (#19249) commit 5cfd835 Author: Jakub Andrzejewski <37120330+Baroshem@users.noreply.github.com> Date: Wed Mar 1 13:15:01 2023 +0100 feat(nuxi): reload nuxt when `restart` hook is called (#19084) commit c7eb891 Author: Inesh Bose <56732164+ineshbose@users.noreply.github.com> Date: Wed Mar 1 12:08:58 2023 +0000 fix(nuxt): deprecate scanning directory index plugins (#18418) commit dccb733 Author: Daniel Roe <daniel@roe.dev> Date: Wed Mar 1 12:03:58 2023 +0000 feat(nuxi): enforce consistent casing in filenames (#19088) commit f303ed6 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed Mar 1 01:45:01 2023 -0800 chore(deps): update devdependency @unocss/reset to ^0.50.2 (main) (#19350) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 755decc Author: Inesh Bose <56732164+ineshbose@users.noreply.github.com> Date: Wed Mar 1 09:39:58 2023 +0000 ci: limit nuxt2 nightly build to nuxt org (#19352) commit 679cec0 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Tue Feb 28 13:31:58 2023 -0800 chore(deps): update all non-major dependencies to ^0.29.2 (main) (#19341) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 6009deb Author: Mahdi Shah abbasian <mehdi.shahabbasian@gmail.com> Date: Wed Mar 1 01:01:41 2023 +0330 docs: use consistent indentation in examples (#19342) commit 639189c Author: Alexander Lichter <github@lichter.io> Date: Tue Feb 28 20:18:47 2023 +0100 fix(nuxt): clear loading indicator on unmount (#19340) commit 32f6cb2 Author: Daniel Roe <daniel@roe.dev> Date: Tue Feb 28 14:06:31 2023 +0100 perf(nuxt): increase static asset maxAge to 1yr (#19335) commit 021ba43 Author: Daniel Roe <daniel@roe.dev> Date: Tue Feb 28 12:19:32 2023 +0100 v3.2.3 (#19317) commit 0f47936 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Tue Feb 28 02:26:11 2023 -0800 chore(deps): update all non-major dependencies to ^1.1.14 (main) (#19321) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Daniel Roe <daniel@roe.dev> commit 503b7ac Author: Daniel Roe <daniel@roe.dev> Date: Mon Feb 27 20:36:27 2023 +0100 perf(nuxt): don't update manifest in dev mode (#19315) commit 62b079a Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Feb 27 11:35:51 2023 -0800 chore(deps): update dependency ufo to ^1.1.1 (main) (#19316) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Daniel Roe <daniel@roe.dev> commit 8bfc66d Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Feb 27 11:02:11 2023 -0800 chore(deps): update all non-major dependencies (main) (#19235) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Daniel Roe <daniel@roe.dev> commit 57b8ff5 Author: Daniel Roe <daniel@roe.dev> Date: Mon Feb 27 16:13:59 2023 +0100 fix(vite): handle non-iterable `noExternal` option (#19256) commit f16cce8 Author: Daniel Roe <daniel@roe.dev> Date: Mon Feb 27 16:13:14 2023 +0100 fix(nuxt): compatible route object for custom external routes (#19261) commit 9e6fa9f Author: igayamaguchi <iganin2@gmail.com> Date: Mon Feb 27 21:29:57 2023 +0900 fix(nuxt): preserve explicit `rel` attribute on internal link (#19309) commit 3c006b3 Author: Sébastien Chopin <seb@nuxt.com> Date: Fri Feb 24 13:19:07 2023 +0100 docs: add docs badge commit fea495f Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed Feb 22 15:04:09 2023 -0800 chore(deps): update all non-major dependencies (main) (#19220) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 99a47c1 Author: Rafael Magalhaes <rafaelmagalhaes93@gmail.com> Date: Wed Feb 22 13:45:22 2023 +0000 docs: improved going further modules documentation (#19219) Co-authored-by: Rafael Magalhaes <rafael.magalhaes@yapily.com> commit 7a4a416 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed Feb 22 01:30:30 2023 -0800 chore(deps): update all non-major dependencies (main) (#19209) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Daniel Roe <daniel@roe.dev> commit a3713eb Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Tue Feb 21 22:01:59 2023 -0800 chore(deps): update all non-major dependencies (main) (#19168) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Daniel Roe <daniel@roe.dev> commit 2359b43 Author: ML <me.mlaure@gmail.com> Date: Wed Feb 22 06:50:14 2023 +0100 docs: clarify that app config is not available (yet) in nitro (#19200) commit 185ae9f Author: Clément Ollivier <clement.o2p@gmail.com> Date: Tue Feb 21 17:45:47 2023 +0100 docs: update link (#19197) commit 7479d46 Author: Daniel Roe <daniel@roe.dev> Date: Tue Feb 21 15:06:10 2023 +0000 fix(nuxt): log errors thrown when booting the nuxt app (#19187) commit b1fd520 Author: Joel Wenzel <50124194+joel-wenzel@users.noreply.github.com> Date: Tue Feb 21 07:39:36 2023 -0600 docs(pages): add example of limiting scanned routes (#19181) commit c4eb4b7 Author: Daniel Roe <daniel@roe.dev> Date: Tue Feb 21 12:22:12 2023 +0000 fix(nuxt): preserve (re)named imports in meta (#19192) commit d2481f9 Author: Daniel Roe <daniel@roe.dev> Date: Mon Feb 20 20:34:33 2023 +0000 fix(webpack): use default export from webpack (#19166) commit 268cded Author: Alex Liu <dsa1314@gmail.com> Date: Tue Feb 21 04:31:27 2023 +0800 fix(nuxt): prefetch object-syntax routes with `<NuxtLink>` (#19144) commit 29d6094 Author: Anthony Fu <anthonyfu117@hotmail.com> Date: Mon Feb 20 21:28:10 2023 +0100 fix(vite): normalize path emitted by vite watcher (#19179) commit eaeb4f0 Author: Julien Huang <julien.huang@outlook.fr> Date: Mon Feb 20 11:56:17 2023 +0100 fix(nuxi): restart nuxt when `distDir` is unlinked (#19131) commit b3ce956 Author: Daniel Roe <daniel@roe.dev> Date: Mon Feb 20 09:54:48 2023 +0000 ci: reduce artifact retention days commit fc19021 Author: usagizmo <usagizmo@gmail.com> Date: Mon Feb 20 18:53:40 2023 +0900 docs: fix components path (#19163) commit cbe2ed6 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Feb 20 01:52:13 2023 -0800 chore(deps): update all non-major dependencies (main) (#19158) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 435b923 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sat Feb 18 14:11:01 2023 -0800 chore(deps): update dependency rollup to ^3.17.1 (main) (#19146) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 7f67fce Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sat Feb 18 10:21:07 2023 +0000 chore(deps): update all non-major dependencies (main) (#19134) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 524426e Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Fri Feb 17 21:03:12 2023 +0000 chore(deps): update all non-major dependencies (main) (#19128) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 3a832ba Author: Daniel Roe <daniel@roe.dev> Date: Fri Feb 17 16:39:15 2023 +0000 v3.2.2 commit a89d944 Author: Daniel Roe <daniel@roe.dev> Date: Fri Feb 17 16:38:16 2023 +0000 fix(nuxi): upgrade `giget` commit 5c47d4c Author: Daniel Roe <daniel@roe.dev> Date: Fri Feb 17 15:56:00 2023 +0000 v3.2.1 (#19082) commit 576ce9e Author: Daniel Roe <daniel@roe.dev> Date: Fri Feb 17 14:13:17 2023 +0000 chore: dedupe rollup commit 5ae0d52 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Fri Feb 17 15:12:14 2023 +0100 chore(deps): update devdependency giget to ^1.1.1 (main) (#19116) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 6858796 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Fri Feb 17 06:05:49 2023 -0800 chore(deps): update all non-major dependencies (main) (#19103) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Daniel Roe <daniel@roe.dev> commit 15b9386 Author: pooya parsa <pyapar@gmail.com> Date: Fri Feb 17 14:38:19 2023 +0100 chore: update nitropack and unjs dependencies (#19100) Co-authored-by: Daniel Roe <daniel@roe.dev> commit ce2d97c Author: Daniel Roe <daniel@roe.dev> Date: Fri Feb 17 10:08:10 2023 +0000 chore: increase node 14 minor version constraint (#19111) commit 3190254 Author: Daniel Roe <daniel@roe.dev> Date: Fri Feb 17 00:59:24 2023 +0000 fix(nuxt): pass nuxt + workspace paths when importing builder (#19099) commit ac682fd Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Thu Feb 16 18:59:07 2023 +0000 chore(deps): update devdependency vue-tsc to ^1.1.2 (main) (#19090) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit f5a3d79 Author: Mathieu Magalhaes <mathieu.magalhaes@gmail.com> Date: Thu Feb 16 18:26:15 2023 +0100 fix(nuxt): respect redirects which differ only by trailing slash (#18593) Co-authored-by: Daniel Roe <daniel@roe.dev> commit e2fc6f2 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Thu Feb 16 09:24:05 2023 -0800 chore(deps): update dependency unenv to ^1.2.0 (main) (#19087) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Daniel Roe <daniel@roe.dev> commit af55b98 Author: Daniel Roe <daniel@roe.dev> Date: Thu Feb 16 17:16:51 2023 +0000 fix(nuxt): test generated pathname commit e9ff34a Author: Daniel Roe <daniel@roe.dev> Date: Thu Feb 16 16:59:06 2023 +0000 fix(nuxt): restore previous check on payload url commit 1e8b27f Author: Daniel Roe <daniel@roe.dev> Date: Thu Feb 16 15:00:40 2023 +0000 perf(nuxt): don't include side-effects from `#components` (#19008) commit c8b49a3 Author: yuyin <38490578+yuyinws@users.noreply.github.com> Date: Thu Feb 16 22:53:23 2023 +0800 docs: add `sendRedirect` usage (#19070) commit 7aa35ff Author: Daniel Roe <daniel@roe.dev> Date: Thu Feb 16 14:40:51 2023 +0000 fix(nuxt): validate no `//` in path when constructing payload url (#19085) commit c45b842 Author: Hamish Claxton <hamishclaxton@gmail.com> Date: Thu Feb 16 23:17:56 2023 +1000 fix(nuxi): read `devServer` options from nuxt config (#19055) commit 681cfa8 Author: Nathan Chase <nathan@nathanchase.com> Date: Thu Feb 16 08:04:09 2023 -0500 perf(nuxt): animate transform rather than width (#19073) commit 7d0ecb5 Author: Daniel Roe <daniel@roe.dev> Date: Thu Feb 16 12:56:14 2023 +0000 fix(nuxt): show client error if no page matches after validate fails (#18978) commit 4b2901b Author: Alex <self@pirsig.net> Date: Thu Feb 16 13:55:12 2023 +0100 fix(nuxi): pass through exit code from test errors (#18959) commit 61cd6b5 Author: Julien Huang <julien.huang@outlook.fr> Date: Thu Feb 16 13:47:42 2023 +0100 fix(nuxt): use parser to treeshake client-only declarations (#18951) commit 9dc5413 Author: Nick Williams <WickyNilliams@users.noreply.github.com> Date: Thu Feb 16 12:45:08 2023 +0000 fix(vite): respect `isCustomElement` config for jsx transform (#19053) commit 96b09ea Author: Daniel Roe <daniel@roe.dev> Date: Thu Feb 16 12:43:58 2023 +0000 feat(nuxt): add experimental `app:chunkError` hook and reload strategy (#19038) commit a1252d3 Author: Daniel Roe <daniel@roe.dev> Date: Thu Feb 16 12:27:28 2023 +0000 docs: add information on when mw runs & how to skip (#19083) commit a937e84 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Thu Feb 16 04:24:49 2023 -0800 chore(deps): update all non-major dependencies (main) (#19075) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 88b895a Author: Ayaka Rizumu <464388324@qq.com> Date: Thu Feb 16 19:44:31 2023 +0800 chore(deps): update @vueuse/head dependencies to 1.0.26 (#19076) commit f225ebd Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Thu Feb 16 03:00:39 2023 +0000 chore(deps): update all non-major dependencies (main) (#19069) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 76a4f4e Author: Favour Felix Chinemerem <46944485+felixfavour@users.noreply.github.com> Date: Wed Feb 15 17:23:17 2023 +0100 docs: updated public directory explanation (#18464) commit 6c5d8d6 Author: Daniel Roe <daniel@roe.dev> Date: Wed Feb 15 16:22:30 2023 +0000 docs: add note about nested directory order (#19061) commit 80f73d3 Author: Daniel Roe <daniel@roe.dev> Date: Wed Feb 15 12:54:49 2023 +0000 docs: remove reference to obsolete `static` property resolves #15009 commit 636e494 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed Feb 15 03:13:08 2023 -0800 chore(deps): update all non-major dependencies (main) (#18952) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com> commit 59a1f7b Author: Daniel Roe <daniel@roe.dev> Date: Tue Feb 14 22:22:53 2023 +0000 perf(nuxt): allow tree-shaking empty meta from build (#19032) commit 523b495 Author: Alois Sečkár <ellrohir@seznam.cz> Date: Tue Feb 14 13:01:37 2023 +0100 docs: flatten top-level project in layers example (#18967) Co-authored-by: Daniel Roe <daniel@roe.dev> Co-authored-by: pooya parsa <pyapar@gmail.com> commit 27d68f6 Author: Florent Delerue <florentdelerue@hotmail.com> Date: Tue Feb 14 11:01:35 2023 +0100 docs: fix spacing (#19018) commit 9e789c7 Author: Daniel Roe <daniel@roe.dev> Date: Tue Feb 14 00:36:46 2023 +0000 fix(vite): exclude `nuxt/app` from optimised deps commit 2960aa3 Author: Daniel Roe <daniel@roe.dev> Date: Tue Feb 14 00:23:12 2023 +0000 fix(schema): transpile `nuxt/app` by default (#19009) commit b1b908b Author: Daniel Roe <daniel@roe.dev> Date: Tue Feb 14 00:22:42 2023 +0000 build: add `nuxt` to nuxt externals commit 71bcd95 Author: Daniel Roe <daniel@roe.dev> Date: Tue Feb 14 00:02:41 2023 +0000 test: skip vnode warning on windows dev mode commit e3e7688 Author: Daniel Roe <daniel@roe.dev> Date: Mon Feb 13 23:08:20 2023 +0000 build(nuxt): add `nuxt/schema` to externals commit 4219ff2 Author: Daniel Roe <daniel@roe.dev> Date: Mon Feb 13 22:56:39 2023 +0000 fix(nuxt): prevent hyphens forming child routes & warn if dupes are detected (#18944) commit 859fbd0 Author: Xin Du (Clark) <clark.duxin@gmail.com> Date: Mon Feb 13 22:55:29 2023 +0000 fix(nitro): ensure ssr error `statusCode` is a number (#19001) commit 54739e4 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Feb 13 14:44:04 2023 -0800 chore(deps): update dependency execa to v7 (main) (#18965) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 6016aef Author: Daniel Roe <daniel@roe.dev> Date: Mon Feb 13 22:42:04 2023 +0000 fix(nuxt): expose `nuxt/schema` subpath for augmentation (#18922) commit e362061 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Feb 13 14:09:58 2023 -0800 chore(deps): update devdependency eslint-plugin-jsdoc to v40 (main) (#18961) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit d036d3d Author: Daniel Roe <daniel@roe.dev> Date: Mon Feb 13 22:09:32 2023 +0000 ci: run webpack/vite and dev/prod as matrices (#18905) commit aa40929 Author: Tim van den Eijnden <TimvdEijnden@users.noreply.github.com> Date: Mon Feb 13 21:40:13 2023 +0100 docs: fix link to ESM page (#19000) commit 6d7be47 Author: Benjamin Flesch <bf@deutsche-cyberberatung.de> Date: Sun Feb 12 20:18:39 2023 +0100 docs: fix typo (#18975) commit b25b6c8 Author: Lioness100 <jchickmm2@gmail.com> Date: Sun Feb 12 14:16:42 2023 -0500 docs: fix typos (#18976) commit 7111b6c Author: pooya parsa <pyapar@gmail.com> Date: Fri Feb 10 17:33:06 2023 +0100 fix(nuxt): avoid recursive import in nitro renderer (#18948) Co-authored-by: Daniel Roe <daniel@roe.dev> commit cf47f9e Author: Felix <5724535+FelixGraf@users.noreply.github.com> Date: Fri Feb 10 17:32:40 2023 +0100 docs: update link to bridge repo (#18950) commit 2d342c3 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Fri Feb 10 06:23:27 2023 -0800 chore(deps): update all non-major dependencies (main) (#18929) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit ee2f568 Author: Daniel Roe <daniel@roe.dev> Date: Fri Feb 10 10:31:56 2023 +0100 refactor(nuxt): combine imports from same relative path commit 19bef5a Author: Daniel Roe <daniel@roe.dev> Date: Fri Feb 10 08:36:10 2023 +0100 fix(schema): allow type inference of arrays in runtime config (#18931) * fix(schema): allow type inference of arrays in runtime config * test: add types fixture commit 9ee568e Author: Daniel Roe <daniel@roe.dev> Date: Thu Feb 9 15:02:59 2023 +0100 docs: add info for `nuxi devtools` command (#18888) commit 5855c1e Author: Daniel Roe <daniel@roe.dev> Date: Thu Feb 9 11:55:03 2023 +0100 v3.2.0 (#18843) commit 5426e56 Author: Daniel Roe <daniel@roe.dev> Date: Thu Feb 9 09:26:23 2023 +0100 test: decrease vite logging during tests commit 71d67ad Author: Daniel Roe <daniel@roe.dev> Date: Thu Feb 9 07:28:58 2023 +0100 chore: combine import statements commit a89e2fa Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Thu Feb 9 00:13:25 2023 -0800 chore(deps): update all non-major dependencies (main) (#18890) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Daniel Roe <daniel@roe.dev> commit 9a035a1 Author: Daniel Roe <daniel@roe.dev> Date: Wed Feb 8 22:26:41 2023 -0800 refactor(nuxt): within nuxt app, import directly from source file (#18902) commit 0b2bce4 Author: Daniel Roe <daniel@roe.dev> Date: Wed Feb 8 22:03:06 2023 -0800 docs: add explanation with augmented meta for new routes (#18901) commit 9845467 Author: pooya parsa <pyapar@gmail.com> Date: Thu Feb 9 07:02:07 2023 +0100 feat(nuxt): upgrade to nitropack 2.2 (#18889) commit 2e62246 Author: Chen <58675561+HiChen404@users.noreply.github.com> Date: Wed Feb 8 22:04:37 2023 +0800 fix: reorder the types field in package.json (#18880) commit 9f3b38c Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed Feb 8 04:09:30 2023 -0800 chore(deps): update dependency esbuild-loader to v3 (main) (#18883) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Daniel Roe <daniel@roe.dev> commit c936bc7 Author: Daniel Roe <daniel@roe.dev> Date: Wed Feb 8 02:43:39 2023 -0800 feat(nuxi): add initial support for enabling/disabling devtools (#18864) Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com> commit 113ce71 Author: Julien Huang <julien.huang@outlook.fr> Date: Wed Feb 8 09:59:57 2023 +0100 fix(nuxt): use parser to treeshake `<ClientOnly>` (nuxt#8713)

huang-julien marked this pull request as draft November 4, 2022 22:51

huang-julien marked this pull request as ready for review November 5, 2022 01:59

atinux requested a review from pi0 November 5, 2022 09:46

danielroe reviewed Nov 6, 2022
View reviewed changes

Comment threadpackages/nuxt/src/components/tree-shake.ts Outdated
Comment threadpackages/nuxt/src/components/tree-shake.ts Outdated
Comment threadpackages/nuxt/src/components/tree-shake.ts Outdated
Comment threadpackages/nuxt/src/components/tree-shake.ts

huang-julien marked this pull request as draft November 6, 2022 15:13

This was referenced Jan 19, 2023
Allow fallback slot server side for .client components nuxt/nuxt#15380
Closed
fix(nuxt): treeshake client-only components with placeholders #8789
Merged

huang-julien marked this pull request as ready for review November 8, 2022 00:09

huang-julien marked this pull request as draft November 8, 2022 00:23

huang-julien marked this pull request as ready for review November 11, 2022 16:53

huang-julien requested review from danielroe and removed request for pi0 November 11, 2022 16:53

danielroe reviewed Nov 15, 2022
View reviewed changes

huang-julien marked this pull request as draft November 15, 2022 21:34

huang-julienand others added 8 commits November 15, 2022 23:12

fix(nuxt): use parser for treeshake module
ec8967b

test(nuxt): ensure scoped style does not break
a62d688

style: lint
ee02bed

refactor(nuxt): improve regex and change jsdoc
27c9205

fix(nuxt): treeshake client only components in setup
fecea00

fix(nuxt): fix refactor + change component to components
6357b28

chore: remove ultrahtml dependency
d8397c1

Update packages/nuxt/src/components/tree-shake.ts
13aa7f8
Co-authored-by: Daniel Roe <daniel@roe.dev>

danielroe added the 3.x label Jan 19, 2023

danielroe reviewed Jan 20, 2023
View reviewed changes

Comment threadpackages/nuxt/src/components/tree-shake.ts Outdated

huang-julien added 5 commits January 22, 2023 16:53

test(nuxt): unit test treeshake client plugin
b08125f

fix(nuxt): remove whole line of component declaration instead of remo…
0fe07f6
…ving to ';'

refactor(nuxt): move some logic into a function
521f883

chore: remove unecessary comment
c40c649

test(nuxt): add snapshots for treeshake client only
646e69f

huang-julien force-pushed the fix/treeshakeCLientOnlyStyle branch 4 times, most recently from e285b1c to dbbf73bCompare January 22, 2023 22:41

test: fix snapshot
939bc3d

huang-julien force-pushed the fix/treeshakeCLientOnlyStyle branch from dbbf73b to 939bc3dCompare January 22, 2023 22:45

huang-julienand others added 3 commits January 22, 2023 23:57

fix: update snapshot
139c615

test: directly mock node:crypto
392b401

Merge remote-tracking branch 'origin/main' into fix/treeshakeCLientOn…
eabbff9
…lyStyle

danielroe reviewed Feb 7, 2023
View reviewed changes

huang-julien added 4 commits February 8, 2023 00:41

test(nuxt): mock path relative due to os differences
73da1fe

test: set correct mock
cbfe602

test: fix max callstack
7fc8681

lint + fix
e5271a7

huang-julien marked this pull request as draft February 8, 2023 00:03

huang-julien marked this pull request as ready for review February 8, 2023 00:08

danielroe changed the title ~~fix(nuxt): use parser to treeshake ClientOnly~~fix(nuxt): use parser to treeshake <ClientOnly>Feb 8, 2023

danielroe merged commit 113ce71 into nuxt:mainFeb 8, 2023

danielroe mentioned this pull request Feb 8, 2023
with treeshakeClientOnly, scoped style attributes don't match between server + client builds nuxt/nuxt#15227
Closed

warflash mentioned this pull request Apr 3, 2023
.client.vue scoped styles are missing on ssr nuxt/nuxt#20061
Closed

antfu mentioned this pull request Oct 26, 2023
Support stripe-away slot of ClientOnly on SSG antfu-collective/vite-ssg#378
Open
3 tasks

Navigation Menu

Uh oh!

Uh oh!

fix(nuxt): use parser to treeshake `<ClientOnly>` - #8713

fix(nuxt): use parser to treeshake `<ClientOnly>`#8713
danielroe merged 39 commits into
nuxt:mainfrom
huang-julien:fix/treeshakeCLientOnlyStyle

huang-julien commented Nov 4, 2022•
edited
Loading

Uh oh!

codesandboxBot commented Nov 4, 2022

Uh oh!

netlifyBot commented Nov 4, 2022•
edited
Loading

Uh oh!

danielroe left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

socket-securityBot commented Nov 6, 2022•
edited
Loading

Uh oh!

pi0 commented Nov 15, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

danielroe left a comment

Uh oh!

huang-julien commented Feb 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

huang-julien commented Nov 4, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Linked issue

❓ Type of change

📚 Description

📝 Checklist

Uh oh!

codesandboxBot commented Nov 4, 2022

Uh oh!

netlifyBot commented Nov 4, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for nuxt3-docs ready!

Uh oh!

danielroe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

socket-securityBot commented Nov 6, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Socket Security Pull Request Report

Uh oh!

pi0 commented Nov 15, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

danielroe left a comment

Choose a reason for hiding this comment

Uh oh!

huang-julien commented Feb 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

huang-julien commented Nov 4, 2022•
edited
Loading

netlifyBot commented Nov 4, 2022•
edited
Loading

socket-securityBot commented Nov 6, 2022•
edited
Loading