Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

Fixed cookie value type - #8754

Closed
magyarb wants to merge 1 commit into
nuxt:mainfrom
magyarb:patch-1
Closed

Fixed cookie value type#8754
magyarb wants to merge 1 commit into
nuxt:mainfrom
magyarb:patch-1

Conversation

@magyarb

@magyarbmagyarb commented Nov 6, 2022

Copy link
Copy Markdown
Contributor

Discussed in https://github.com/nuxt/framework/discussions/2576

The cookie.value is typed as string, so // @ts-ignore must be used to do this. I have fixed the types, so the cookie can be deleted without a ts error.

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

### Discussed in https://github.com/nuxt/framework/discussions/2576
The cookie.value is typed as string, so // @ts-ignore must be used to do this. I have fixed the types, so the cookie can be deleted without a ts error.
@netlify

netlifyBot commented Nov 6, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commitcc1df3e
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/636825990b9cf90008354d52
😎 Deploy Previewhttps://deploy-preview-8754--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codesandbox

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe

Copy link
Copy Markdown
Member

I've made a new PR to make a couple changes - see #8769. Feel free to merge them back into this PR if you would like - and in future please allow maintainers edit access to your PRs.

@danielroedanielroe self-assigned this Nov 7, 2022
@pi0

pi0 commented Nov 9, 2022

Copy link
Copy Markdown
Member

Merged via #8769. Thanks for PR ❤️

@pi0pi0 closed this Nov 9, 2022
@magyarb
magyarb deleted the patch-1 branch November 14, 2022 15:57
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@magyarb@danielroe@pi0