Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): add catchall paths to prerender list - #8782

Merged
pi0 merged 2 commits into
mainfrom
fix/catchall-generation
Nov 9, 2022
Merged

fix(nuxt): add catchall paths to prerender list#8782
pi0 merged 2 commits into
mainfrom
fix/catchall-generation

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Where users had only a catchall but no other pages, we weren't generating anything. In this case we can almost certainly render the base URL that would otherwise be caught by the catchall. (I've also included optional params, e.g. ~/pages/[[something]].vue.)

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added the bug Something isn't working label Nov 7, 2022
@danielroe
danielroe requested review from atinux and pi0November 7, 2022 18:00
@danielroedanielroe self-assigned this Nov 7, 2022
@codesandbox

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Nov 7, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commitd83621b
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/636947a6d4f8fe0009b17541

pi0
pi0 approved these changes Nov 9, 2022
@pi0pi0 changed the title fix(nuxt): add catchall/optional paths to prerender listfix(nuxt): add catchall paths to prerender listNov 9, 2022
@pi0
pi0 merged commit 30d9947 into mainNov 9, 2022
@pi0
pi0 deleted the fix/catchall-generation branch November 9, 2022 09:00
@pi0pi0 mentioned this pull request Nov 15, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@danielroe@atinux@pi0