Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(schema): add declarations to ignore list - #8787

Merged
pi0 merged 4 commits into
mainfrom
fix/ignore-ts
Nov 9, 2022
Merged

fix(schema): add declarations to ignore list #8787
pi0 merged 4 commits into
mainfrom
fix/ignore-ts

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#15387

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

We can safely ignore .d.ts files from our resolver for layouts, pages, middleware, plugins, etc. (and indeed from the vite build watcher). They will still be included in the user's project and type checked.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working schema labels Nov 7, 2022
@danielroe
danielroe requested a review from pi0November 7, 2022 21:48
@danielroedanielroe self-assigned this Nov 7, 2022
@codesandbox

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Nov 7, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit9b80b35
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/636983686662d900086dbd90

@danielroedanielroe changed the title style: lint some types fix(schema): add declarations to ignore list Nov 7, 2022
@danielroedanielroe changed the title fix(schema): add declarations to ignore list fix(schema): add declarations to ignore list Nov 7, 2022
@danielroe
danielroe marked this pull request as ready for review November 7, 2022 21:54
pi0
pi0 approved these changes Nov 9, 2022
@pi0
pi0 merged commit 4e8f59b into mainNov 9, 2022
@pi0
pi0 deleted the fix/ignore-ts branch November 9, 2022 09:01
@pi0pi0 mentioned this pull request Nov 15, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't workingschema

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Defining an index.d.ts file in /plugins throws an error client-side

2 participants

@danielroe@pi0