Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

feat(nuxt-link): add isExternal to slot props - #8800

Merged
pi0 merged 5 commits into
nuxt:mainfrom
TheAlexLichter:feat/nuxt-linkadd-is-external
Nov 9, 2022
Merged

feat(nuxt-link): add isExternal to slot props#8800
pi0 merged 5 commits into
nuxt:mainfrom
TheAlexLichter:feat/nuxt-linkadd-is-external

Conversation

@TheAlexLichter

@TheAlexLichterTheAlexLichter commented Nov 8, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

nuxt/nuxt#15398

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR exposes the isExternal scoped slot prop of <NuxtLink>

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox

codesandboxBot commented Nov 8, 2022

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Nov 8, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commitb89549d
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/636a25e0d7e5270008ad225e

danielroe
danielroe reviewed Nov 8, 2022
View reviewed changes
Comment threadpackages/nuxt/src/app/components/nuxt-link.ts Outdated
@TheAlexLichter@danielroe
Update packages/nuxt/src/app/components/nuxt-link.ts
b89549d
Co-authored-by: Daniel Roe <daniel@roe.dev>
pi0
pi0 approved these changes Nov 9, 2022
View reviewed changes

@pi0pi0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@pi0
pi0 merged commit 15d4cea into nuxt:mainNov 9, 2022
@pi0pi0 mentioned this pull request Nov 9, 2022
Closed
4 tasks
@TheAlexLichter
TheAlexLichter deleted the feat/nuxt-linkadd-is-external branch November 9, 2022 09:35
@pi0pi0 mentioned this pull request Nov 15, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@danielroedanielroedanielroe approved these changes
@pi0pi0pi0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TheAlexLichter@pi0@danielroe