Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

feat(nuxt): auto-import utils/ directory - #8817

Merged
pi0 merged 6 commits into
mainfrom
feat/import-utils
Nov 9, 2022
Merged

feat(nuxt): auto-import utils/ directory#8817
pi0 merged 6 commits into
mainfrom
feat/import-utils

Conversation

@danielroe

@danielroedanielroe commented Nov 8, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This adds auto-import support for the utils/ directory for auto-imports that are not composables.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added the enhancement New feature or request label Nov 8, 2022
@danielroe
danielroe requested review from atinux and pi0November 8, 2022 14:48
@danielroedanielroe self-assigned this Nov 8, 2022
@codesandbox

codesandboxBot commented Nov 8, 2022

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Nov 8, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commitb5cd545
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/636b73a15fbeac0008650df4
😎 Deploy Previewhttps://deploy-preview-8817--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

atinux
atinux approved these changes Nov 8, 2022
View reviewed changes

@atinuxatinux left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good enough for redirecting for now but would be worth adding content later on on utils to explain the convention between composables vs utils

pi0
pi0 reviewed Nov 9, 2022
View reviewed changes
Comment threaddocs/content/2.guide/2.directory-structure/1.utils.md
pi0
pi0 approved these changes Nov 9, 2022
View reviewed changes
@pi0
pi0 merged commit 4bbd261 into mainNov 9, 2022
@pi0
pi0 deleted the feat/import-utils branch November 9, 2022 09:43
@pi0pi0 mentioned this pull request Nov 15, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@atinuxatinuxatinux approved these changes
@pi0pi0pi0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@danielroedanielroe

Labels

3.xenhancementNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danielroe@atinux@pi0