Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): swallow issues with query selectors - #8843

Merged
pi0 merged 1 commit into
mainfrom
fix/query-selector
Nov 9, 2022
Merged

fix(nuxt): swallow issues with query selectors#8843
pi0 merged 1 commit into
mainfrom
fix/query-selector

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#15381

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This swalls any issues with invalid query selectors which otherwise would completely crash a page.

Note that vue-router will rightly still warn:

[Vue Router warn]: The selector "#accesstoken=ey.4" is invalid. If you are using an id selector, make sure to escape it. You can find more information about escaping characters in selectors at https://mathiasbynens.be/notes/css-escapes or use CSS.escape (https://developer.mozilla.org/en-US/docs/Web/API/CSS/escape).

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Nov 9, 2022
@danielroe
danielroe requested a review from pi0November 9, 2022 08:39
@danielroedanielroe self-assigned this Nov 9, 2022
@codesandbox

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Nov 9, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commite5be451
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/636b672f4f760900086c73c9

pi0
pi0 approved these changes Nov 9, 2022
@pi0
pi0 merged commit 453ce78 into mainNov 9, 2022
@pi0
pi0 deleted the fix/query-selector branch November 9, 2022 09:10
@pi0pi0 mentioned this pull request Nov 15, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default router behaviour issues with client-side callback (hash)

2 participants

@danielroe@pi0