Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxi): exclude dist from type checking - #8848

Merged
pi0 merged 3 commits into
mainfrom
fix/exclude-dist
Nov 10, 2022
Merged

fix(nuxi): exclude dist from type checking#8848
pi0 merged 3 commits into
mainfrom
fix/exclude-dist

Conversation

@danielroe

@danielroedanielroe commented Nov 9, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#15415

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

.nuxt/dist, .output, .netlify, etc. aren't caught because they start with ., but the 'dist' folder does get caught by TS when type-checking a project. Excluding it should improve type-checking performance, and also resolve the linked issue.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working cli labels Nov 9, 2022
@danielroe
danielroe requested a review from pi0November 9, 2022 11:16
@danielroedanielroe self-assigned this Nov 9, 2022
@codesandbox

codesandboxBot commented Nov 9, 2022

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Nov 9, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commitf730708
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/636ba730ff24ed0008f13494

pi0
pi0 reviewed Nov 9, 2022
View reviewed changes
Comment threadpackages/nuxi/src/utils/prepare.ts Outdated
@pi0pi0 changed the title fix(nuxi): exclude 'dist' from type checkingfix(nuxi): exclude dist from type checkingNov 10, 2022
pi0
pi0 approved these changes Nov 10, 2022
View reviewed changes
@pi0
pi0 merged commit c32c1d0 into mainNov 10, 2022
@pi0
pi0 deleted the fix/exclude-dist branch November 10, 2022 08:45
@pi0pi0 mentioned this pull request Nov 15, 2022
Merged
@danielroedanielroe mentioned this pull request Mar 20, 2023
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@pi0pi0pi0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@danielroedanielroe

Labels

3.xbugSomething isn't workingcli

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

$fetch typings clash with contents of dist folder

2 participants

@danielroe@pi0