Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): detect non-functional imports within page meta - #8881

Merged
pi0 merged 1 commit into
mainfrom
fix/external-meta
Nov 10, 2022
Merged

fix(nuxt): detect non-functional imports within page meta#8881
pi0 merged 1 commit into
mainfrom
fix/external-meta

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#15346

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This slightly expands the detection of imports to include standalone identifiers and not just functions.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Nov 10, 2022
@danielroe
danielroe requested a review from pi0November 10, 2022 10:26
@danielroedanielroe self-assigned this Nov 10, 2022
@codesandbox

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Nov 10, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit000b030
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/636cd1cf6e707b000862bd9b

pi0
pi0 approved these changes Nov 10, 2022
@pi0
pi0 merged commit 9227361 into mainNov 10, 2022
@pi0
pi0 deleted the fix/external-meta branch November 10, 2022 10:31
@dargmuesli

Copy link
Copy Markdown
Member

@pi0pi0 mentioned this pull request Nov 15, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

definePageMeta throws an error 500 as "is not defined" for external data

3 participants

@danielroe@dargmuesli@pi0