Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): use app.baseURL when fetching error page on server - #8888

Merged
pi0 merged 2 commits into
nuxt:mainfrom
tobyfaux:fix/ssr-error-page-base-url
Nov 10, 2022
Merged

fix(nuxt): use app.baseURL when fetching error page on server#8888
pi0 merged 2 commits into
nuxt:mainfrom
tobyfaux:fix/ssr-error-page-base-url

Conversation

@tobyfaux

@tobyfauxtobyfaux commented Nov 10, 2022

Copy link
Copy Markdown
Contributor

🔗 Linked issue

Resolvesnuxt/nuxt#15437.

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Resolvesnuxt/nuxt#15437 by prepending app.baseURL when fetching the error page during SSR. This is needed because the localFetch method used has no default baseURL value.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox

codesandboxBot commented Nov 10, 2022

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Nov 10, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit3c5747b
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/636cf8567125110008872125

pi0
pi0 approved these changes Nov 10, 2022
View reviewed changes
@pi0
pi0 merged commit 3e34a61 into nuxt:mainNov 10, 2022
@pi0

pi0 commented Nov 10, 2022

Copy link
Copy Markdown
Member

Thanks!

@tobyfaux
tobyfaux deleted the fix/ssr-error-page-base-url branch November 10, 2022 20:36
@pi0pi0 mentioned this pull request Nov 15, 2022
Merged
danielroe pushed a commit that referenced this pull request Jan 21, 2023
@tobyfauxToby Faux@danielroe
fix(nuxt): useapp.baseURLwhen fetching error page on server (#8888)
0a351f0
Co-authored-by: Toby Faux <tobyfaux@Tobys-MacBook-Pro.local>
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@pi0pi0pi0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot render error page during SSR if app.baseURL is configured

3 participants

@tobyfaux@pi0@danielroe