Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

docs: match the open graph protocol markup - #8959

Merged
pi0 merged 1 commit into
nuxt:mainfrom
IsraelOrtuno:patch-3
Nov 14, 2022
Merged

docs: match the open graph protocol markup#8959
pi0 merged 1 commit into
nuxt:mainfrom
IsraelOrtuno:patch-3

Conversation

@IsraelOrtuno

Copy link
Copy Markdown
Contributor

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

https://ogp.me/ suggests to use the attribute property instead of name when defining OpenGraph metadata.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

https://ogp.me/ suggests to use the attribute `property` instead of `name` for defining its properties
@codesandbox

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Nov 14, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commit9c4d544
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/6371be6e5401f600083e06a1
😎 Deploy Previewhttps://deploy-preview-8959--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@danielroe

Copy link
Copy Markdown
Member

Thank you ❤️

@pi0pi0 changed the title docs: Match the OpenGraph protocol markupdocs: match the open graph protocol markupNov 14, 2022
@pi0
pi0 merged commit 4915a39 into nuxt:mainNov 14, 2022
@TheAlexLichter

Copy link
Copy Markdown
Member

@harlan-zw Maybe unhead could allow both, nameorproperty and automatically choose the right one (e.g. property for og: tags, name otherwise?)

@harlan-zw

Copy link
Copy Markdown
Collaborator

@harlan-zw Maybe unhead could allow both, nameorproperty and automatically choose the right one (e.g. property for og: tags, name otherwise?)

The logic for determining that is actually quite complex (like 1kb of scripts), so instead, we implement this type of logic in a opt-in composable.

https://unhead.harlanzw.com/guide/guides/useseometa

PR should be up very shortly

@pi0pi0 mentioned this pull request Nov 15, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@IsraelOrtuno@danielroe@TheAlexLichter@harlan-zw@pi0