Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

refactor(kit)!: remove support for module container - #9010

Merged
pi0 merged 3 commits into
mainfrom
refactor/container
Nov 15, 2022
Merged

refactor(kit)!: remove support for module container#9010
pi0 merged 3 commits into
mainfrom
refactor/container

Conversation

@danielroe

@danielroedanielroe commented Nov 15, 2022•
edited
Loading

Copy link
Copy Markdown
Member

🔗 Linked issue

#8994

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR removes automatic provision of module container to nuxt modules.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added enhancement New feature or request kit labels Nov 15, 2022
@danielroe
danielroe requested a review from pi0November 15, 2022 13:01
@danielroedanielroe self-assigned this Nov 15, 2022
@codesandbox

codesandboxBot commented Nov 15, 2022

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Nov 15, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commita9c1d04
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/637390470f8fa10008a92fd4
😎 Deploy Previewhttps://deploy-preview-9010--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vercel
vercelBot temporarily deployed to Preview November 15, 2022 13:02 Inactive
pi0
pi0 reviewed Nov 15, 2022
View reviewed changes
Comment threadpackages/kit/src/module/container.ts Outdated
@danielroe
danielroe requested a review from pi0November 15, 2022 13:12
@danielroedanielroe mentioned this pull request Nov 15, 2022
Merged
@vercel
vercelBot temporarily deployed to Preview November 15, 2022 13:19 Inactive
pi0
pi0 approved these changes Nov 15, 2022
View reviewed changes
@pi0
pi0 merged commit 74b81bb into mainNov 15, 2022
@pi0
pi0 deleted the refactor/container branch November 15, 2022 13:22
@so1veso1ve mentioned this pull request Nov 16, 2022
Closed
5 tasks
danielroe added a commit that referenced this pull request Jan 21, 2023
@danielroe
refactor(kit)!: remove support for module container (#9010)
9efd1c2
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@pi0pi0pi0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@danielroedanielroe

Labels

3.xenhancementNew feature or requestkit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danielroe@pi0