Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

refactor: update unjs dependencies to stable v1 - #9011

Merged
pi0 merged 8 commits into
mainfrom
feat/updates
Nov 15, 2022
Merged

refactor: update unjs dependencies to stable v1#9011
pi0 merged 8 commits into
mainfrom
feat/updates

Conversation

@pi0

@pi0pi0 commented Nov 15, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Update uns packages with semver major to v1.

Also updating nitropack temporarily to edge channel to finish update in one step.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Nov 15, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs failed.

NameLink
🔨 Latest commit6918f57
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/6373a2c66a64c20009a94ffa

@TheAlexLichter

TheAlexLichter commented Nov 15, 2022

Copy link
Copy Markdown
Member

@pi0 Could you briefly explain why was ohmyfetch renamed to ofetch? I'm a little afraid people have to memorize "yet another library name" after getting used to ohmyfetch + using it package in projects / shown it in docs + talks 🙈

@pi0pi0 mentioned this pull request Nov 15, 2022
@pi0

pi0 commented Nov 15, 2022

Copy link
Copy Markdown
MemberAuthor

Could you briefly explain why was ohmyfetch renamed to ofetch?

it is a shorter name. I initially wanted to release as shorter name but took long to get publish access to it. As for Nuxt users, interface name is still $fetch without imports. Perhaps can add some references to ofetch readme to explain renaming.

@socket-security

Copy link
Copy Markdown

Socket Security Pull Request Report

Dependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again.

🧐 Potential typo squat

Package name is similar to other popular packages and may not be the package you want.

Use care when consuming similarly named packages and ensure that you did not intend to consume a different package. Malicious packages often publish using similar names as existing popular packages.

Package📎 Did you mean?Found in
ofetch@1.0.0 (added)ofetch (16 thousand times more downloads)package.json,packages/nuxt/package.json,packages/test-utils/package.json
Pull request report summary
IssueStatus
Install scripts✅ 0 issues
Native code✅ 0 issues
Bin script confusion✅ 0 issues
Bin script shell injection✅ 0 issues
Unresolved require✅ 0 issues
Invalid package.json✅ 0 issues
HTTP dependency✅ 0 issues
Git dependency✅ 0 issues
Potential typo squat⚠️ 1 issue
Known Malware✅ 0 issues
Telemetry✅ 0 issues
Protestware/Troll package✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@2.4.2

  • @SocketSecurity ignore ofetch@1.0.0

⚠️ Please accept the latest app permissions to ensure bot commands work properly. Accept the new permissions here.

Powered by socket.dev

@TheAlexLichter

Copy link
Copy Markdown
Member

it is a shorter name

Do you think the shorter name really worth all the migration for all packages using ohmyfetch now explicitly?

@pi0

pi0 commented Nov 15, 2022

Copy link
Copy Markdown
MemberAuthor

Hmm will probably keep ohmyfetch as placeholder in a semver-major. Making it easier to migrate other packages. But for renaming really had to do this before v3 as you notice, it gets harder to break API or make renames as we have more users.

@TheAlexLichter

Copy link
Copy Markdown
Member

Hmm will probably keep ohmyfetch as placeholder in a semver-major.

That'd be good at least 👍

But for renaming really had to do this before v3

Or not at all 🙈

@pi0
pi0 marked this pull request as ready for review November 15, 2022 14:33
@pi0
pi0 merged commit b49f2a8 into mainNov 15, 2022
@pi0
pi0 deleted the feat/updates branch November 15, 2022 14:33
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@pi0@TheAlexLichter@danielroe