Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): include layers in esbuild transform - #9014

Merged
pi0 merged 1 commit into
mainfrom
fix/esbuild-layers
Nov 15, 2022
Merged

fix(nuxt): include layers in esbuild transform#9014
pi0 merged 1 commit into
mainfrom
fix/esbuild-layers

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

If we are using typescript files within a layer, esbuild doesn't process this and the nitro build will fail. This PR exempts layers from the node_modules exclude, but otherwise preserves it.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added the bug Something isn't working label Nov 15, 2022
@danielroe
danielroe requested review from atinux and pi0November 15, 2022 13:45
@danielroedanielroe self-assigned this Nov 15, 2022
@codesandbox

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Nov 15, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit7fec6e0
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/637398131b2fcc000a00e7a0

pi0
pi0 approved these changes Nov 15, 2022
@pi0
pi0 merged commit 4c8369f into mainNov 15, 2022
@pi0
pi0 deleted the fix/esbuild-layers branch November 15, 2022 13:52
@pi0pi0 mentioned this pull request Nov 16, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@danielroe@pi0