Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): include missing <NuxtPage> component props - #9204

Merged
pi0 merged 6 commits into
mainfrom
fix/nuxt-page-props
Nov 21, 2022
Merged

fix(nuxt): include missing <NuxtPage> component props#9204
pi0 merged 6 commits into
mainfrom
fix/nuxt-page-props

Conversation

@DamianGlowala

@DamianGlowalaDamianGlowala commented Nov 20, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Adds missing props to the <NuxtPage> component's type cast. Are default undefined/null values of the props serving any purpose? Can they be removed?

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox

codesandboxBot commented Nov 20, 2022

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@vercel
vercelBot temporarily deployed to Preview November 21, 2022 11:50 Inactive
@danielroe

danielroe commented Nov 21, 2022

Copy link
Copy Markdown
Member

Are default undefined/null values of the props serving any purpose? Can they be removed?

Yes, they are serving a purpose - we want to distinguish between default (undefined, in which case we want to fall back to app-wide defaults) and deliberately false values.

danielroe
danielroe approved these changes Nov 21, 2022
View reviewed changes

@danielroedanielroe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ❤️

@pi0
pi0 merged commit 4f2bfbe into mainNov 21, 2022
@pi0
pi0 deleted the fix/nuxt-page-props branch November 21, 2022 13:03
daniil4udo pushed a commit to daniil4udo/framework that referenced this pull request Nov 22, 2022
@DamianGlowala@danielroe@daniil4udo
fix(nuxt): include missing<NuxtPage>component props (nuxt#9204)
ad475d9
Co-authored-by: Daniel Roe <daniel@roe.dev>
@pi0pi0 mentioned this pull request Dec 15, 2022
Closed
6 tasks
@danielroedanielroe mentioned this pull request Jan 20, 2023
Merged
@MikeBellikaMikeBellika mentioned this pull request Jan 20, 2023
Closed
danielroe added a commit that referenced this pull request Jan 21, 2023
@DamianGlowala@danielroe
fix(nuxt): include missing<NuxtPage>component props (#9204)
d8cf446
Co-authored-by: Daniel Roe <daniel@roe.dev>
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@danielroedanielroedanielroe approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DamianGlowala@danielroe@pi0