Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

refactor: split out type imports from value imports - #9225

Merged
danielroe merged 9 commits into
nuxt:mainfrom
daniil4udo:refactor/importsNotUsedAsValues
Dec 11, 2022
Merged

refactor: split out type imports from value imports#9225
danielroe merged 9 commits into
nuxt:mainfrom
daniil4udo:refactor/importsNotUsedAsValues

Conversation

@daniil4udo

Copy link
Copy Markdown
Contributor

🔗 Linked issue

❓ Type of change

Refactoring type imports to be in proper import type {...}

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

pi0
pi0 approved these changes Nov 21, 2022

@pi0pi0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it 💯

@daniil4udo
daniil4udoforce-pushed the refactor/importsNotUsedAsValues branch from acb6f1c to 01890cbCompareNovember 22, 2022 03:34
@vercel

vercelBot commented Dec 11, 2022

Copy link
Copy Markdown

@danielroe is attempting to deploy a commit to the Nuxt Team on Vercel.

A member of the Team first needs to authorize it.

@danielroedanielroe changed the title refactor: imports not used as valuesrefactor: split out type imports from value importsDec 11, 2022
@danielroe
danielroe merged commit ab2456c into nuxt:mainDec 11, 2022
@pi0pi0 mentioned this pull request Dec 15, 2022
6 tasks
@danielroedanielroe mentioned this pull request Jan 20, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@daniil4udo@TheAlexLichter@pi0@danielroe@nathanchase