Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxi): provide install advice if git fails - #923

Merged
pi0 merged 2 commits into
mainfrom
fix/nuxi-init-advice
Oct 13, 2021
Merged

fix(nuxi): provide install advice if git fails#923
pi0 merged 2 commits into
mainfrom
fix/nuxi-init-advice

Conversation

@danielroe

@danielroedanielroe commented Oct 13, 2021

Copy link
Copy Markdown
Member

🔗 Linked issue

see nuxt/nuxt#11997

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This adds some basic advice when degit fails, along with a command to run separately workaround.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe
danielroe requested a review from pi0October 13, 2021 10:13
@danielroedanielroe self-assigned this Oct 13, 2021
@netlify

netlifyBot commented Oct 13, 2021•
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for nuxt3-docs canceled.

🔨 Explore the source changes: 7bbe4f6

🔍 Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/6166b39817a4d200085dc838

pi0
pi0 reviewed Oct 13, 2021
View reviewed changes
Comment threadpackages/nuxi/src/commands/init.ts Outdated
pi0
pi0 approved these changes Oct 13, 2021
View reviewed changes

@pi0pi0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However we need to debug degit why is not downloading tarbar and depending on git

@danielroe@pi0
Update packages/nuxi/src/commands/init.ts
7bbe4f6
Co-authored-by: pooya parsa <pyapar@gmail.com>
@pi0
pi0 merged commit 81293ff into mainOct 13, 2021
@pi0
pi0 deleted the fix/nuxi-init-advice branch October 13, 2021 10:30
@pi0pi0 mentioned this pull request Jan 19, 2023
Closed
@harlan-zwharlan-zw mentioned this pull request May 26, 2022
Merged
7 tasks
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@pi0pi0pi0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@danielroedanielroe

Labels

3.xclidx

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danielroe@pi0