Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(test-utils): do not hide Vitest output - #9442

Merged
pi0 merged 4 commits into
mainfrom
fix/test-log
Dec 2, 2022
Merged

fix(test-utils): do not hide Vitest output#9442
pi0 merged 4 commits into
mainfrom
fix/test-log

Conversation

@antfu

Copy link
Copy Markdown
Member

🔗 Linked issue

closenuxt/nuxt#15747

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

kit.logger.level was overriding globally to hide all output including Vitest

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@atinux

Copy link
Copy Markdown
Member

Thanks!

Would it be possible also to add the others logs like mentioned in the issue?
CleanShot 2022-12-01 at 00 40 02@2x

@antfuantfu changed the title fix(test-utils): do not hide Vitest output,fix(test-utils): do not hide Vitest outputDec 1, 2022
@atinux
atinux requested review from danielroe and pi0December 1, 2022 15:02
const hooks = createTest(options)

export const setup = async () => {
kit.logger.info('Building Nuxt app...')

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might to refactor this later into setup for fine gained control when to show message (build is not always happening / can include more context details in log)

pi0
pi0 approved these changes Dec 2, 2022

@pi0pi0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks 💯

@pi0
pi0 merged commit 3501fd5 into mainDec 2, 2022
@pi0
pi0 deleted the fix/test-log branch December 2, 2022 09:42
@pi0pi0 mentioned this pull request Dec 15, 2022
6 tasks
@danielroedanielroe mentioned this pull request Jan 20, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display Vitest output when running nuxi test

4 participants

@antfu@atinux@pi0@danielroe