Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

feat(nuxt): support for extending error.vue in layers - #9521

Merged
danielroe merged 5 commits into
nuxt:mainfrom
TheAlexLichter:fix/error-layers
Dec 6, 2022
Merged

feat(nuxt): support for extending error.vue in layers#9521
danielroe merged 5 commits into
nuxt:mainfrom
TheAlexLichter:fix/error-layers

Conversation

@TheAlexLichter

@TheAlexLichterTheAlexLichter commented Dec 5, 2022•
edited
Loading

Copy link
Copy Markdown
Member

🔗 Linked issue

Resolvesnuxt/nuxt#15717
Related: nuxt/nuxt#13367

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Adds layer/extends support for error.vue

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox

codesandboxBot commented Dec 5, 2022

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

pi0
pi0 reviewed Dec 5, 2022
View reviewed changes
Comment threadpackages/nuxt/src/core/app.ts Outdated
pi0
pi0 reviewed Dec 5, 2022
View reviewed changes
Comment threadpackages/nuxt/src/core/app.ts Outdated
@TheAlexLichter

TheAlexLichter commented Dec 5, 2022

Copy link
Copy Markdown
MemberAuthor

I'll refactor the rest of the file in another PR to make use of pathe.join + keeping fallback out of findPath - for e.g. App.vue

danielroe
danielroe reviewed Dec 5, 2022
View reviewed changes
Comment threadpackages/nuxt/src/core/app.ts Outdated
@TheAlexLichter@danielroe
Update packages/nuxt/src/core/app.ts
c8be652
Co-authored-by: Daniel Roe <daniel@roe.dev>
danielroe
danielroe approved these changes Dec 5, 2022
View reviewed changes

@danielroedanielroe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - thank you! ❤️

@danielroedanielroe changed the title feat(layers): support for error.vuefeat(nuxt): support for extending error.vue in layersDec 6, 2022
@danielroe
danielroe merged commit 5f935aa into nuxt:mainDec 6, 2022
@TheAlexLichter
TheAlexLichter deleted the fix/error-layers branch December 6, 2022 10:05
@TheAlexLichterTheAlexLichter mentioned this pull request Dec 6, 2022
Merged
8 tasks
@pi0pi0 mentioned this pull request Dec 15, 2022
Closed
6 tasks
@danielroedanielroe mentioned this pull request Jan 20, 2023
Merged
danielroe pushed a commit that referenced this pull request Jan 21, 2023
@TheAlexLichter@danielroe
feat(nuxt): support for extending error.vue in layers (#9521)
9777b64
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pi0pi0Awaiting requested review from pi0
2 more reviewers
@atinuxatinuxatinux approved these changes
@danielroedanielroedanielroe approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

resolve error.vue in nuxt layers

4 participants

@TheAlexLichter@atinux@pi0@danielroe