Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

docs(rendering): hide light image in dark mode - #9620

Merged
danielroe merged 2 commits into
nuxt:mainfrom
mst101:docs/dark-mode-images
Dec 10, 2022
Merged

docs(rendering): hide light image in dark mode#9620
danielroe merged 2 commits into
nuxt:mainfrom
mst101:docs/dark-mode-images

Conversation

@mst101

@mst101mst101 commented Dec 9, 2022

Copy link
Copy Markdown
Contributor

🔗 Linked issue

❓ Type of change

  • [ x] 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

The page at https://nuxt.com/docs/guide/concepts/rendering shows both light and dark versions of the images. I don't know how to conditionally render an image from within markdown(?), but this PR at least hides the light version of the image when dark mode is set by simply adding a tailwind class of dark:hidden.

N.B. I'm not sure what the current classes of .light-img and .dark-img currently do, if anything?

📝 Checklist

  • I have linked an issue or discussion.
  • [ x] I have updated the documentation accordingly.

@codesandbox

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@vercel

vercelBot commented Dec 9, 2022

Copy link
Copy Markdown

@mst101 is attempting to deploy a commit to the Nuxt Team on Vercel.

A member of the Team first needs to authorize it.

@danielroedanielroe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ❤️

cc: @clemcode

Comment threaddocs/content/1.docs/2.guide/1.concepts/3.rendering.md Outdated
Comment threaddocs/content/1.docs/2.guide/1.concepts/3.rendering.md Outdated
@danielroe
danielroe merged commit ac61b2b into nuxt:mainDec 10, 2022
@pi0pi0 mentioned this pull request Dec 15, 2022
6 tasks
@danielroedanielroe mentioned this pull request Jan 20, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mst101@danielroe