Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): remove absolute paths from routes objects - #9655

Merged
pi0 merged 2 commits into
mainfrom
fix/relative-component-name
Dec 12, 2022
Merged

fix(nuxt): remove absolute paths from routes objects#9655
pi0 merged 2 commits into
mainfrom
fix/relative-component-name

Conversation

@danielroe

@danielroedanielroe commented Dec 11, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#15637

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Absolute file paths were being embedded in the build by the pages integration in two places - in the meta variable as well as in the .file attribute (which is not used by vue-router as far as I can tell). We can safely relativise the former and remove the latter.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels Dec 11, 2022
@danielroedanielroe self-assigned this Dec 11, 2022
@codesandbox

codesandboxBot commented Dec 11, 2022

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroedanielroe changed the title fix(nuxt): use relative path for generate meta namefix(nuxt): remove absolute paths from routes objectsDec 11, 2022
pi0
pi0 reviewed Dec 12, 2022
View reviewed changes
Comment threadpackages/nuxt/src/pages/utils.ts
pi0
pi0 approved these changes Dec 12, 2022
View reviewed changes

@pi0pi0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. (resolving from srcDir to be fixed later together with other places)

@pi0
pi0 merged commit 23307cd into mainDec 12, 2022
@pi0
pi0 deleted the fix/relative-component-name branch December 12, 2022 12:25
@pi0pi0 mentioned this pull request Dec 15, 2022
Closed
6 tasks
@danielroedanielroe mentioned this pull request Jan 20, 2023
Merged
danielroe added a commit that referenced this pull request Jan 21, 2023
@danielroe
fix(nuxt): remove absolute paths from routes objects (#9655)
bdf9070
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@TheAlexLichterTheAlexLichterTheAlexLichter approved these changes
@pi0pi0pi0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@danielroedanielroe

Labels

3.xbugSomething isn't working🍰 p2-nice-to-havePriority 2: nothing is broken but it's worth addressing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

nuxt use absolute path when build and generate

3 participants

@danielroe@TheAlexLichter@pi0