Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): make dev-only regexp less greedy - #9679

Merged
danielroe merged 2 commits into
mainfrom
fix/dev-only-regexp
Dec 13, 2022
Merged

fix(nuxt): make dev-only regexp less greedy#9679
danielroe merged 2 commits into
mainfrom
fix/dev-only-regexp

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#15646

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This updates the dev-only regexp to be less greedy, so it won't accidentally swallow up intervening content between dev-only components.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Dec 12, 2022
@danielroe
danielroe requested a review from pi0December 12, 2022 21:30
@danielroedanielroe self-assigned this Dec 12, 2022
@codesandbox

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe
danielroe merged commit 4cf110e into mainDec 13, 2022
@danielroe
danielroe deleted the fix/dev-only-regexp branch December 13, 2022 09:39
@pi0pi0 mentioned this pull request Dec 15, 2022
6 tasks
@danielroedanielroe mentioned this pull request Jan 20, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Several DevOnly in one component raise error Element is missing end tag.

2 participants

@danielroe@antfu