Skip to content

fix(google-maps): bind $attrs to overlay view#672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harlan-zw merged 2 commits into from
Mar 24, 2026
Merged

fix(google-maps): bind $attrs to overlay view #672

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1aab5f3
fix(google-maps): bind `$attrs` to overlay view
DamianGlowala Mar 24, 2026
67add62
set inheritAttrs to false
Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/runtime/components/GoogleMaps/ScriptGoogleMapsOverlayView.vue
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,10 @@ type OverlayAnchor = 'center' | 'top-left' | 'top-center' | 'top-right'
type OverlayPane = 'mapPane' | 'overlayLayer' | 'markerLayer'
| 'overlayMouseTarget' | 'floatPane'

defineOptions({
inheritAttrs: false,
})

const props = withDefaults(defineProps<{
/**
* Geographic position for the overlay. Falls back to parent marker position if omitted.
Expand DownExpand Up@@ -304,7 +308,7 @@ defineExpose({ overlay, dataState })

<template>
<div style="display: none;">
<div ref="overlay-content" :data-state="dataState">
<div ref="overlay-content" :data-state="dataState" v-bind="$attrs">
Comment thread
coderabbitai[bot] marked this conversation as resolved.
<slot />
</div>
</div>
Expand Down
Loading