Rofl public vars

[martintomazic]

Part of oasisprotocol/oasis-sdk#2248.

Used public var instead of env to make sure people don't accidentally set secrets here.

Tested it with https://github.com/oasisprotocol/Honoroll/pull/440.

[netlify]

✅ Deploy Preview for oasisprotocol-cli canceled.

Name	Link
🔨 Latest commit	17537ed
🔍 Latest deploy log	https://app.netlify.com/projects/oasisprotocol-cli/deploys/6a50085b09290f00087cac52

[martintomazic]

Followed the style and organisation 1:1 with oasis rofl secrets.

[martintomazic]

NIT: existing global config makes things hard to test cleanly :((

[matevz]

If you define a public var with the same name as the existing secret, Oasis CLI should fail.

[martintomazic]

If you define a public var with the same name as the existing secret, Oasis CLI should fail.

Private variable name (if --public-name is set) is available inside rofl.yaml so the fix should work in all cases...? Writing tests for the new validation would require a thorough refactor of the existing code, so I only tested manually for now.

Note there is similar issue with secrets definitions overlapping between each other:

the secret name is capitalized and spaces are replaced with underscores, so a secret called my secret will be available as MY_SECRET.

meaning cli should probably not allow setting my secret and MY_SECRET at the same time as a rofl secret, but I would ignore this as 1. existing and 2. app admin should be responsible.

[matevz]

Please also mention special env. metadata fields behavior in the ROFL manifest specs https://github.com/oasisprotocol/oasis-sdk/blob/main/docs/rofl/features/manifest.md

[peternose]

Please also mention special env. metadata fields behavior in the ROFL manifest specs https://github.com/oasisprotocol/oasis-sdk/blob/main/docs/rofl/features/manifest.md

You could also gather these variables under the same key, e.g. metadata["env"] = "city=London,country=England".