Uh oh!
There was an error while loading. Please reload this page.
cmd/tx: Implement Safe transaction batch output format - #708
Merged
Conversation
✅ Deploy Preview for oasisprotocol-cli ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
kostko
reviewed
Jul 14, 2026
Uh oh!
There was an error while loading. Please reload this page.
matevz
commented
Jul 15, 2026
| // No admin in manifest, leave unchanged. | ||
| case npa.AccountSetExplicitly: | ||
| // No admin in manifest, leave unchanged; ignore for unsigned transactions entirely. | ||
| case npa.AccountSetExplicitly, common.TxUnsigned: |
MemberAuthor
There was a problem hiding this comment.
This will be pretty common for multisig ROFLs where no one will have a local admin account available. But creating and exporting ROFL transactions into Safe format must still work.
kostko
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements option 2 of #700
An example workflow for updating ROFL parameters on a ROFL that is governed by a multisig account on Safe:
echo "abc" | oasis rofl public-var set GAS_PRICE -oasis rofl update --format safe --unsigned -o update-rofl-gas-price.json