A flow cannot send a localizable notification — the app wires no `emailTemplates` barrel, so only the explicitly non-localizable path exists

[os-warren]

AGENTS.md §8: "English is the source language. Every authored label gets an en entry; zh-CN is hand-translated. Do not hard-code display text in a hook or flow."

A notify node has exactly two content paths, and they are mutually exclusive by schema (NotifyConfigSchema.superRefine):

• template — names a sys_email_template bundle; the delivery path resolves (name, recipient locale) per recipient at send time. This is the localizable path.
• inline title + message — sent to every recipient verbatim. The schema's own .describe() calls this "not localizable".

defineStack accepts an emailTemplates collection (stack.zod.ts, merged with concat), but this app wires no barrel for one: there is no src/email-templates/, and objectstack.config.ts — the file a feature branch must not edit — lists no emailTemplates key. So the localizable path is unreachable from a feature branch, and §8 cannot be followed by any flow that notifies anybody.

The three reminder sweeps landed in #11 therefore carry inline English title/message. That is a declared deviation, recorded in the flow file's header, not an oversight — but it is a deviation that every future notifying flow will have to repeat, and each one is a string that cannot reach the zh-CN bundle.

What closing this looks like

1. src/email-templates/index.ts exporting a named dulyEmailTemplates array, following the same barrel convention and the same "named array, never Object.values" reasoning as every other directory.
2. emailTemplates: dulyEmailTemplates in objectstack.config.ts (the one edit, made once, by whoever owns that file — same shape as the pre-created empty barrels already there).
3. Move the Lead-time reminders, overdue escalation and stagnation alerts #11 sweep strings into bundles and swap the three notify nodes from title/message to template + templateData.

Sequencing note: the barrel is worth pre-creating empty exactly like the others, so the config edit happens once and no later branch needs to touch it. Related to #18 (i18n bundle + CI coverage gate), which will otherwise measure coverage over a set of strings it cannot see.

Found while implementing #11.

---

Generated by Claude Code

[os-warren]

Claiming this one.

• Session: session_01SqkTcrxUFci7nqXdbBSe2p
• Branch: claude/issue-69-email-templates-barrel

Scope per the card's three steps: the dulyEmailTemplates barrel (named array, never Object.values), the single emailTemplates: edit in objectstack.config.ts, and moving the #11 sweep strings out of the three notify nodes into template bundles (template + templateData). Not building a translation-coverage check — that is #18's deliverable, which is in flight in parallel.

Generated by Claude Code

---

Generated by Claude Code

[os-warren]

{
 "issue": 69,
 "status": "done",
 "branch": "claude/issue-69-email-templates-barrel",
 "pr": "https://github.com/objectstack-ai/duly/pull/99",
 "premise_still_valid": true,
 "summary": "All three steps of the card. src/email-templates/ now exists with a named dulyEmailTemplates array carrying the repo's standard 'named array, never Object.values' comment; objectstack.config.ts gains exactly two lines (the import and emailTemplates: dulyEmailTemplates); the three #11 sweep strings moved into bundles and the three notify nodes swapped from inline title/message to template + templateData, so the AGENTS.md §8 deviation recorded in reminders.flow.ts's header is gone rather than restated. Each of the three names carries two (name, locale) rows — en and zh-CN, exactly i18n.supportedLocales — because sys_email_template localizes by ROW, not through the translations bundle (TranslationSchema declares no emailTemplates key), so #18's bundle could not have supplied them. No translation-coverage check was built: that is #18's deliverable. I landed FIRST — origin/main is still 75d086f, unmoved since dispatch.",
 "tests": "All four gates green at branch head 4ca5549, one locked run: `pnpm validate` -> '✓ Validation passed (436ms)'; `pnpm typecheck` -> exit 0, no output; `pnpm test` -> 'Test Files 27 passed (27) / Tests 674 passed (674)'; `pnpm build` -> '✓ Build complete' + 'Artifact: dist/objectstack.json (128.4 KB)', whose emailTemplates holds all 6 rows and whose lead-time notify config reads {template, templateData:{subject,due_date}} with no title/message. Every heavy run went through scripts/pm/os-verify-lock.sh (VERDICT command-exit 0). END-TO-END (test/email-templates.test.ts, 10 tests): boots a real kernel with the real automation/job/messaging/email services, drives the REAL TimeRelativeTrigger sweep via the job service's trigger(), and reads the row the inbox channel wrote — sys_inbox_message.title = \"File the operator's emissions return\", body_md = 'This is now on your list. Due 2026-09-08.'; boot log '[email] declared email templates materialized into sys_email_template {\"seeded\":6,\"skipped\":0,\"total\":6}' and '[messaging] reliable delivery on (outbox + dispatcher, 8 partitions, single-node)'. The same bundle at locale zh-CN resolves to '这项任务已进入你的待办列表，截止日期 2026-09-08。'. ABLATION 1 (dangling reference, no rebuild needed — vitest transpiles src directly, no dist in the loop): mutated template: 'duly.task_lead_time' -> 'duly.task_lead_tim' in reminders.flow.ts with the mutation confirmed on disk by grep counts of BOTH the deleted and the injected text (deleted-text before=1 after=0, injected-text=1), restored by a trap; result 3 failed / 7 passed, including the end-to-end leg timing out with no inbox row ever written, while the automation run log was byte-identical to the green run ('status=completed acted=0 skipped=1 unmeasured=1') — the run reports success and the delivery dead-letters, which is exactly the failure the test exists to catch. ABLATION 2 (does validate actually parse the new collection): injected an undeclared key into one template definition, confirmed on disk (injected-marker-count=1); `pnpm validate` went exit 1 with 'Unrecognized key(s) on this email template: `bogusKeyThatNoSchemaDeclares`'. Its trap restore FAILED SILENTLY (git checkout on an untracked file: 'did not match any file(s) known to git') — caught by the post-check, restored by hand, marker count re-read as 0 and validate re-run green (exit 0) before continuing.",
 "open_questions": [],
 "out_of_scope_findings": []
}

---

Generated by Claude Code

[os-warren]

os-dev-report

(Supersedes the previous comment — its <!-- os-dev-report --> marker was eaten by the body sanitizer after storage, so the scan could not see it. Same report, literal-text marker.)

{
 "issue": 69,
 "status": "done",
 "branch": "claude/issue-69-email-templates-barrel",
 "pr": "https://github.com/objectstack-ai/duly/pull/99",
 "premise_still_valid": true,
 "summary": "All three steps of the card. src/email-templates/ now exists with a named dulyEmailTemplates array carrying the repo's standard 'named array, never Object.values' comment; objectstack.config.ts gains exactly two lines (the import and emailTemplates: dulyEmailTemplates); the three #11 sweep strings moved into bundles and the three notify nodes swapped from inline title/message to template + templateData, so the AGENTS.md section 8 deviation recorded in reminders.flow.ts's header is gone rather than restated. Each of the three names carries two (name, locale) rows - en and zh-CN, exactly i18n.supportedLocales - because sys_email_template localizes by ROW, not through the translations bundle (TranslationSchema declares no emailTemplates key), so #18's bundle could not have supplied them. No translation-coverage check was built: that is #18's deliverable. I landed FIRST - origin/main is still 75d086f, unmoved since dispatch.",
 "tests": "All four gates green at branch head 4ca5549, one locked run: `pnpm validate` -> 'Validation passed (436ms)'; `pnpm typecheck` -> exit 0, no output; `pnpm test` -> 'Test Files 27 passed (27) / Tests 674 passed (674)'; `pnpm build` -> 'Build complete' + 'Artifact: dist/objectstack.json (128.4 KB)', whose emailTemplates holds all 6 rows and whose lead-time notify config reads {template, templateData:{subject,due_date}} with no title/message. Every heavy run went through scripts/pm/os-verify-lock.sh (VERDICT command-exit 0). END-TO-END (test/email-templates.test.ts, 10 tests): boots a real kernel with the real automation/job/messaging/email services, drives the REAL TimeRelativeTrigger sweep via the job service's trigger(), and reads the row the inbox channel wrote - sys_inbox_message.title = \"File the operator's emissions return\", body_md = 'This is now on your list. Due 2026-09-08.'; boot log '[email] declared email templates materialized into sys_email_template {seeded:6, skipped:0, total:6}' and '[messaging] reliable delivery on (outbox + dispatcher, 8 partitions, single-node)'. The same bundle at locale zh-CN resolves to the Chinese sentence authored in the zh-CN row. ABLATION 1 (dangling reference; no rebuild needed - vitest transpiles src directly, no dist in the loop): mutated template: 'duly.task_lead_time' -> 'duly.task_lead_tim' in reminders.flow.ts, mutation confirmed on disk by grep counts of BOTH the deleted and the injected text (deleted-text before=1 after=0, injected-text=1), restored by a trap and the restore re-verified (good=1, injected=0); result 3 failed / 7 passed, including the end-to-end leg timing out with no inbox row ever written, while the automation run log was byte-identical to the green run ('status=completed acted=0 skipped=1 unmeasured=1') - the run reports success and the delivery dead-letters, which is exactly the failure the test exists to catch. ABLATION 2 (does validate actually parse the new collection): injected an undeclared key into one template definition, confirmed on disk (injected-marker-count=1); `pnpm validate` went exit 1 with 'Unrecognized key(s) on this email template: bogusKeyThatNoSchemaDeclares'. Its trap restore FAILED SILENTLY (git checkout on an untracked file: 'did not match any file(s) known to git') - caught by the post-check, restored by hand, marker count re-read as 0 and validate re-run green (exit 0) before continuing.",
 "open_questions": [],
 "out_of_scope_findings": []
}

---

Generated by Claude Code