Uh oh!
There was an error while loading. Please reload this page.
docs: name the full share recipient set in the actions and record-access tables - #110
Merged
Merged
Conversation
…ess tables The built-in `share` row said "a user / role"; `role` is retired vocabulary (ADR-0090 D3 renamed the sharing recipient `role` to `position`). The record-access mechanisms row named three of the five recipient kinds. Both now use the enumeration record-access.mdx already uses further down. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Yaqu7kmKZM3tRPd9Y4xivo
os-elon
marked this pull request as ready for review
August 18, 2026 15:49
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#91
Two table cells named the record-share recipient kinds with retired or incomplete vocabulary. Both now use the enumeration
content/docs/configure/permissions/record-access.mdxalready uses further down the same page.content/docs/build/interface/actions.mdx:170content/docs/configure/permissions/record-access.mdx:15Source of truth
ShareRecipientTypeinpackages/spec/src/security/sharing.zod.tsonobjectstack@origin/mainis exactly:roleis not a member. Therole->positionrename is ADR-0090 D3, recorded indocs/adr/0086("Renamedrole->position(ADR-0090 D3); 'role' is now a reserved-forbidden word"),docs/adr/0087:378anddocs/adr/0090:176, and on this site already atcontent/docs/resources/changelog.mdx:212and:260. The schema's own comment block records the siblinggroup->teamrename and theguest/queueexclusions, but not therolerename — that lives in the ADRs.Wording: why the full five, not the four the triage comment sketched
Triage suggested "user, team, position, or business unit" for the
actions.mdxcell. Both cells name all five kinds instead, verbatim from the page's own sentence atrecord-access.mdx:66("a user, team, position, business unit, or a unit and its subordinates").The reason is that the second half of this card is the incomplete-subset defect:
record-access.mdx:15silently dropped two kinds. Fixing that row while shipping a four-of-five enumeration one page over would re-file the same defect in the file being fixed. The full list costs one line in an unaligned markdown table, and it makes both cells agree with:66rather than with a third phrasing.Not touched
content/docs/index.mdx:43— triage excluded it: comparative prose about the Salesforce / NetSuite product category, not an authoring instruction.Corpus grep
Triage's premise that these were the last English pages teaching the retired spelling does not hold:
reference/cel.mdx:69and:124document and demonstrateos.user.roles, a keyEvalUserdoes not have (it ispositions), andconfigure/notifications.mdx:76/:83plusresources/glossary.mdx:161still nameroleas a principal kind. Filed unassigned as #109.groupas a recipient kind has zero English hits.Verification at
dcb25eepnpm install --frozen-lockfilepnpm turbo run type-check build test --continue --force--force, no FULL TURBO);testmatches no task in this repo, which is #72node .github/scripts/check-translations.mjsnode .github/scripts/check-translation-ownership.mjs --actor os-elon --files changed.txtnode .github/scripts/check-translation-output.mjs --self-testnode .github/scripts/check-translation-output.mjs --files changed.txtEnglish only; no locale sibling touched. Both pages now have stale
*.locale.mdxsiblings, which is the designed outcome per AGENTS.md.Generated by Claude Code