Uh oh!
There was an error while loading. Please reload this page.
docs: rename pages.mdx component visibility key to visibleWhen - #136
Merged
Conversation
ADR-0089 makes `visibleWhen` the single canonical name for the page-component conditional-visibility key. `pages.mdx` was the last English page still spelling it `visibility` in the Components code example and the property table. The old spelling still parses and is normalized at the schema boundary, so the property-table row keeps a one-line note that `visibility` is accepted as a deprecated alias rather than going silent. Fixes#129
os-warren
marked this pull request as ready for review
August 19, 2026 03:35
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#129
What changed
content/docs/build/interface/pages.mdxwas the last English page spelling thepage-component conditional-visibility key as
visibilityinstead of theADR-0089 canonical
visibleWhen. Renamed it in both places:visibility: "..."→visibleWhen: "...".now keeps a one-line note that
visibilityis still accepted as adeprecated alias, since it genuinely parses and normalizes at the schema
boundary and silence would read as "my metadata just broke" to an existing
author.
Editorial-call note (per the card): I looked for an established corpus
convention for documenting an accepted-but-deprecated alias inside a
property-table row and found none — the one precedent
(
content/docs/build/automation/approvals.mdx) documents its deprecatedalias in prose above the table, not as a table row annotation, and links to
matching
os lintrule ids. Since no table-row precedent exists, I followedthe PM triage recommendation: a short parenthetical note in the description
cell rather than a separate row or silence.
English source only — no locale siblings touched.
pages.zh-Hans.mdxis nowreported stale by the translation freshness gate, which is the designed
non-blocking behavior (see below).
Premise re-verification (on branch point
5fd04d8)Corpus grep for the three spellings across English
.mdx(locale siblingsexcluded) confirms this was still the only
visibility:/`visibility`hit, with a
visibleWhen/visibleOncontrol probe returning real hitselsewhere (
formulas.mdx,validation-rules.mdx,views.mdx,changelog.mdx) — the single-hit reading is a real measurement, not abroken grep.
Verification (HEAD
94b76e5)pnpm turbo run type-check --filter=@objectos/docs --force— 1 successful, 1 total.pnpm turbo run build --filter=@objectos/docs --force— 1 successful, 1 total; confirmed the rendered/en/docs/build/interface/pages.htmloutput containsvisibleWhenin both the code sample and the property table, with the deprecated-alias note.node .github/scripts/check-translations.mjs— exit 0, "✓ translations gate passed";pages.zh-Hans.mdxnow listed as stale, which is the designed non-blocking outcome (English lands on its own; the next translation pass re-derives it).pnpm turbo run testwas not run — it executes zero tasks in this repo.Generated by Claude Code
Generated by Claude Code