Skip to content

[finding] The cross-package detector's own comments still say "the two seeds" — the source the three stale copies were copied from #10565

Description

@os-zhuang

Observation-class, found while sweeping for #10163. No gate is red today. Filed unassigned, no pm:queue.

Measured

#10163 corrects four files outsidescripts/check-cross-package-test-inputs.mjs that told authors the gate recognises "exactly two seeds". The phrase is also inside the detector itself, four times, and two of those instances are now inaccurate in the same way — measured on ceb33a9f12:

linetextverdict
:660// The two seeds NAME the directory; fileSegs names the FILE inside it.stale — four directory-naming seeds are resolved below it (dirname(fileURLToPath(import.meta.url)), __dirname, import.meta.dirname, dirname(import.meta.filename))
:673// ... the two seeds above ...accurate in local context (exactly two cases precede it)
:679// The two seeds above NAME the directory.stale — four directory seeds precede it
:695// ... the same base as the two seeds above.stale by the same reading

The gate's published RECOGNISED_PATH_SPELLINGS (:530-542), which it prints verbatim in its failure text, is correct and lists all of them. Only the surrounding prose lags.

Why record it rather than shrug

This is where the copies came from. #8995 and #9763 each widened the resolved set and each updated RECOGNISED_PATH_SPELLINGS; neither swept the prose, and the phrase then propagated into three files outside the detector plus a fourth claim in the opposite direction. Leaving the phrase at its source is what makes a fifth copy likely.

The drift direction is benign — the prose is narrower than the code — which is exactly why nothing caught it.

Why it is not a rider on the #10163 PR

scripts/check-cross-package-test-inputs.mjs is edited by open PR #10450, so #10163's PR deliberately does not touch it. Cheapest landing is a wording pass on that PR's file or a small follow-up after it merges: replace the count with "the directory-naming seeds above", or point at RECOGNISED_PATH_SPELLINGS, the same shape #10163 used in the four external files.

Refs

#10163 (the external sweep) · #8995 and #9763 (the widenings) · PR #10450 (holds the file)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions