plugin-sharing declares six separate `MinimalLogger` types, now divergent after #10556

[os-warren]

Observation filed while landing PR #10691 (the #10556 sink paydown). Not a claim; unassigned. Not fixed there — out of that card's scope.

packages/plugins/plugin-sharing/src declares six separate local types all named MinimalLogger, one per module:

file	shape (after #10691)
bulk-recompute.ts	{ info?, warn, error? }
rule-hooks.ts	{ info?, warn }
record-share-cascade.ts	{ info?, warn }
sharing-rule-provenance.ts	{ info?, warn? }
record-orphan-cleanup.ts	{ info?: Function, warn?: Function }
bu-tree-recompute.ts	{ info?, warn? }
primary-bu-projection.ts	{ info?, warn? }

(Seven rows, six of which spell the same name — primary-bu-projection.ts and bu-tree-recompute.ts are byte-identical to each other.)

Why this is worth recording rather than shrugging at

The duplication is not itself the defect; the divergence is. #10556 made bulk-recompute.ts's warn non-optional, and tsc immediately reported two call sites — rule-hooks.ts:240 and record-share-cascade.ts:328 — with the confusing form:

Argument of type 'MinimalLogger | undefined' is not assignable to parameter of type 'MinimalLogger | undefined'.
 Type 'MinimalLogger' is not assignable to type 'MinimalLogger'. Two different types with this name exist, but they are unrelated.

Both were repaired in #10691 (their warn is now required too, because they forward into the guaranteed sink). What is left is that three of the seven still declare warn? while three declare warn, under one name, in one package — so the next forwarding edge added between any of them re-opens the same seam, and the diagnostic that reports it names the same type on both sides.

record-orphan-cleanup.ts's { info?: Function, warn?: Function } is a further wrinkle: bare Function accepts any callable, so it neither documents the call shape nor catches an arity mistake.

Note for whoever picks this up

⚠️ Not simply "extract one shared type". Four of the seven declare no error member at all, which deliberately keeps them out of the check:optional-error-sink population (#9754) — collapsing them onto one shape that declares error? would pull four modules into that gate's scope and is a contract decision, not a refactor. The cheap and clearly-correct subset is the three already-identical { info?, warn? } shapes; the rest wants a judgement about what this package's logger contract actually is.

[huangyiirene]

Concentration-round first-touch: promoted finding → pm:queue, Task, domain:services (routed by landing point: plugin-sharing).

Scope ruled narrow, per the card's own ⚠️: unify only the clearly-correct subset — the three byte-identical { info?, warn? } shapes onto one shared local type, and replace record-orphan-cleanup.ts's bare-Function members with real signatures without adding an error member. ⛔ The full seven-way collapse is out of scope: four shapes deliberately declare no error to stay outside check:optional-error-sink's population (#9754), and pulling them in is a contract decision that belongs with the #10556 family, not a refactor rider. If the subset unification turns out to force that boundary, stop and report. Size S.

---

Generated by Claude Code

[os-warren]

Claim: dispatched.

• session: user-29 [974948]
• branch: claude/issue-10692-sharing-minimal-logger-divergence
• worktree: ../objectstack-10692
• Clause-②: no for the cheap subset — module-local types, no public surface, no accept/reject set. ⚠️ Yes for anything that changes a module's check:optional-error-sink membership; see the fence below.
• serial constraint: packages/plugins/plugin-sharing/src. Free.

⛔ The fence, stated first because it is the whole risk

This is not "extract one shared type." The card says why:

Four of the seven declare no error member at all, which deliberately keeps them out of the check:optional-error-sink population (#9754) — collapsing them onto one shape that declares error? would pull four modules into that gate's scope and is a contract decision, not a refactor.

So:

• In scope: unify the shapes that are already identical. The card names them as the three { info?, warn? } ones. That subset changes no module's gate membership and no type's meaning.
• ⛔ Out of scope: any change that gives a module an error member it does not have, or removes one it does. That moves check:optional-error-sink's population, which is a ledger this lane has been paying down deliberately (Pay down the optional-error sink ledger: 15 sink types still declare an error that can go nowhere #10556 → 15, then 3, then 2). Silently enrolling four modules into it is the opposite of paying it down.
• If you conclude the right answer is one contract for the whole package, that is a needs_decision return with the measurement — say what the package's logger contract should be and what it would cost each module. Do not implement it.

Re-derive the count; the card's own is ambiguous

The title says six types. The table lists seven files. The body says "Seven rows, six of which spell the same name." Those do not obviously reconcile.

Derive it yourself, by enclosing declaration rather than by grep hit, and state the method. ⚠️ Two traps this lane measured today:

• a grep count is not a fact count — doc comments, type annotations and log strings all match;
• an optional chain on the field (this.x?.y?.()) defeats the obvious pattern. A count that looked right was off by one for exactly that reason a few hours ago.

If your number differs from six or seven, that is a finding, not an error — say so with the method.

What must be pinned — and what "pinned" means for a type change

A type unification has no runtime behaviour to assert, so the pin is the compiler:

• ⚠️ The proof is that tsc still passes AND that it would have failed. Run the package's typecheck before and after — and prove the instrument is live by showing it catches a deliberate mismatch, rather than reporting a green that would have been green anyway. A type change with no failing counterfactual is not measured.
• the two call sites the card names — rule-hooks.ts:240 and record-share-cascade.ts:328 — still compile, and their warn requirement is unchanged.
• ⛔ check:optional-error-sink membership is unchanged. Run the gate before and after and quote both verdicts. Its population count must not move. This is the load-bearing check for this card.
• record-orphan-cleanup.ts's { info?: Function, warn?: Function } — bare Function accepts any callable, so it neither documents the call shape nor catches an arity mistake. ⚠️ Tightening it is a real improvement but changes what compiles; if you tighten it, prove nothing broke, and if you leave it, say why.

Standing proof standard

Ablation with the signature predicted first — for a type change, the natural ablation is reintroducing a divergence and showing tsc names it. Restore proved byte-identical by git hash-object, and re-run the restore leg to a real verdict. Gate union derived on the final commit, clean tree, dispatch-gates.mjs with no path arguments, exit codes captured before any pipe. Class #10309 — it held on one card today and was short on four; re-derive on the final committed diff, which is what made the difference, and say whether it named your gates. Changeset required. Draft PR only.

⚠️ A gate's refusal (PREREQUISITE NOT MET / Nothing was checked / --re-measure cannot run) is NOT MEASURED, never a pass — build the closure and re-run. A pnpm --filter matching no script exits 0 having run nothing — echo the script name and count the echoed lines. Never git stash (shared stack).

⛔ Do not touch content/docs/releases/** or packages/spec.

Refs

#10556 (the sink ledger this must not enlarge) · PR #10691 (where the divergence was found and two call sites repaired) · #9754 (check:optional-error-sink and its population rule) · #10706 / PR #11055 (adjacent: the same package family's logger-binding defect, landed today)

---

Generated by Claude Code