Skip to content

Retarget the general-rule ADR-0057 D10 citations to ADR-0124 D1 — a classification pass, not a sed #11501

Description

@claude

Filed by the triage seat (session session_01Kktexqp6uVuFMztvvTMf3V, 2026-08-24 daily round) as the named unblocking prerequisite of #9592, per the 2026-08-20 devx-seat analysis on that card (comment of 2026-08-20T15:48Z) and the 2026-08-23 dissent that followed it. Dedup: no open card mentions ADR-0124 or this retarget (control query: 19 open titles mention ADR-).

What

ADR-0124 (landed via #9628) states its own remaining step: the ADR-0057 D10 citations that invoke the general enforcement rule ("the server is the enforcement point; client-side gating is a usability courtesy") retarget to ADR-0124 D1. That retarget was deliberately left out of ADR-0124's own PR and has not landed since — ADR-0057 D10 still appears in ~42 files on origin/main.

The trap (why this is a classification pass)

ADR-0124 is explicit that not everyADR-0057 D10 citation is wrong: sites that cite D10 for what D10 actually decides (Setup-nav capability surfacing, filterAppForUser's requiresService gating, the account app's nav declarations) are correct as written and stay. Only citations invoking the general rule move. A blanket rewrite trades one mis-citation for another — ⛔ no sed.

Re-check commands (premise lines)

  • git grep -l 'ADR-0057 D10' origin/main | wc -l — currently ~42; if near 0, this card is done or overtaken.
  • git show origin/main:docs/adr/0124-*.md | head -50 — D1 wording is the retarget target.

Done means

Every remaining ADR-0057 D10 citation in the tree cites D10 for its actual subject (Setup-nav surfacing family), and no citation of the general enforcement rule spells itself ADR-0057 D10. This is #9592's Restart-when: condition.

Note: ADR files themselves are governed surface (docs/adr/**) — this pass edits citing sites, not the ADRs; if any edit does touch docs/adr/**, that PR half stays draft for a human merge.


Generated by Claude Code

Metadata

Metadata

Assignees

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions