Skip to content

service-sms: sms-plugin.ts still describes the retired slice(0, 6) prefix pin in the present tense #11594

Description

@os-zhuang

Split out of #11415 rather than carried in its PR: #11415's declared file surface is packages/cli/test/serve-defaults.test.ts only, and this sentence lives in a second package, so taking it would have widened that PR's verification surface for a comment with no behaviour. Filed unassigned and ungraded — domain:* and type are triage's to mint.

What is there

packages/services/service-sms/src/sms-plugin.ts (in the optionalDependencies doc comment, ~line 109):

sms is the entry this card was filed about: it sits at index 6 of PLATFORM_ALWAYS_ON_CAPABILITIES, one past the pinned slice(0, 6), so before this declaration its correct position relative to settings was held by nothing at all.

Why it is stale

"the pinned slice(0, 6)" is present tense about a pin that no longer exists. #11046 replaced the spec-side literal with the derived rule (commit 68e8b4b5, PR #11416), and #11415 does the same at the third home, packages/cli/test/serve-defaults.test.ts. After both, no home of that pin is a slice: each states the rule — every always-on entry that is not a bind target (queue/job/cache/settings) is mounted after all of them — so sms is now held by the pin rather than sitting one past it.

Historical narrative, no behaviour: nothing reads this comment and no test asserts on it.

Suggested work

Reword the sentence to put the slice in the past and name what replaced it. Comment-only; no changeset.

Refs

#11415 (found while implementing it) · #11046 / PR #11416 (the spec-side repair) · #10250 (the original defect and ruling)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions