spec: NotifyConfigSchema template doc/description promises per-recipient locale resolution that the delivery path deliberately does not do (deployment default, ruled 2026-08-13) #12178

Description

@huangyiirene

Found while implementing objectstack-ai/hotcrm#1185 (localize 16 notify nodes). The wording below is what made that card look actionable; the implementation is correct and the spec doc block is what drifted, so filing against packages/spec.

The drift

packages/spec/src/automation/io-node-config.zod.ts states, in the NotifyConfigSchema doc block (line ~135) and again in the template field .describe() (line ~188):

  • L135: "the delivery path resolves (name, recipient locale)per recipient at delivery time via IEmailService.sendTemplate({ template, locale })"
  • L188: "the delivery path resolves (name, recipient locale) at delivery time and renders subject/body per recipient"

Read plainly, both say the recipient's own locale selects the template row.

The delivery path's own source says the opposite, and says it honestly — packages/services/service-messaging/src/email-channel.ts L86-99:

"The measured source, and its limits, spelled out: the platform has no per-user locale today (sys_user carries no locale column; the 2026-08-13 ruling defers one until measured pull) … So 'recipient locale' resolves to the deployment defaultII18nService.getDefaultLocale()."

So "recipient locale" is a term of art here meaning deployment default, and the spec block is the one place it is not qualified.

Measured on the published 17.1.0 artifacts

Two recipients, different locales, one notification, real createEmailChannel / createInboxChannel, stub email service capturing what reaches sendTemplate / renderTemplate:

sendTemplate to=en@example.com locale="en"
renderTemplate to=(inbox) locale="en"
sendTemplate to=zh@example.com locale="en" <- zh-CN recipient
renderTemplate to=(inbox) locale="en" <- zh-CN recipient

The only lever is payload.locale, which is interpolated once before fan-out, so it is one value for the whole notification (verified at all three channel.send call sites in service-messaging: fanOut, the outbox single-delivery path, and processDigestGroup — each passes the same payload to every recipient).

Also confirmed: sys_user has no locale field (and carries protection.lock: "full"), and sys_notification_preference has none either — so there is no per-recipient source to read even if a channel wanted one.

service-messaging@17.2.0 is byte-identical on the two locale-resolution lines, so this is not a "fixed in a later release" situation.

Why it is worth a wording fix rather than a shrug

The doc block is the contract a consuming app reads. Quoted at face value it licenses exactly one conclusion — "convert the nodes and non-English users get non-English notifications" — which is false, and the conversion is a net regression when made on that belief (TEMPLATE_* failures classify permanent and dead-letter, and the inbox channel starts requiring an email service with renderTemplate() where inline text needed none).

One nearby log line has the same issue — service-messaging/src/plugin.ts: "notify template refs resolve sys_email_template per recipient locale".

Suggested fix

Qualify the three sites the way email-channel.ts already does — name the resolved value the deployment default (II18nService.getDefaultLocale()), and note that a per-user locale is deferred by the 2026-08-13 ruling and layers in as an override when it lands. No behaviour change.

Note packages/spec/src/automation/io-node-config.test.ts L277/L303 assert /recipient locale/ against these strings, so a reword touches those two assertions.

Not filing the per-user-locale capability itself here — that is the deferred half of the 2026-08-13 ruling and belongs to whoever weighs the pull; hotcrm#1185 is one such datapoint and says so.


Generated by Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
       blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
      }
      } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
      })();
      (function(){
      try {
      var __m = "github.com";
      var __re = new RegExp('^' + "github\\.com" + '
      
      Skip to content

      spec: NotifyConfigSchema template doc/description promises per-recipient locale resolution that the delivery path deliberately does not do (deployment default, ruled 2026-08-13) #12178

      Description

      @huangyiirene

      Found while implementing objectstack-ai/hotcrm#1185 (localize 16 notify nodes). The wording below is what made that card look actionable; the implementation is correct and the spec doc block is what drifted, so filing against packages/spec.

      The drift

      packages/spec/src/automation/io-node-config.zod.ts states, in the NotifyConfigSchema doc block (line ~135) and again in the template field .describe() (line ~188):

      • L135: "the delivery path resolves (name, recipient locale)per recipient at delivery time via IEmailService.sendTemplate({ template, locale })"
      • L188: "the delivery path resolves (name, recipient locale) at delivery time and renders subject/body per recipient"

      Read plainly, both say the recipient's own locale selects the template row.

      The delivery path's own source says the opposite, and says it honestly — packages/services/service-messaging/src/email-channel.ts L86-99:

      "The measured source, and its limits, spelled out: the platform has no per-user locale today (sys_user carries no locale column; the 2026-08-13 ruling defers one until measured pull) … So 'recipient locale' resolves to the deployment defaultII18nService.getDefaultLocale()."

      So "recipient locale" is a term of art here meaning deployment default, and the spec block is the one place it is not qualified.

      Measured on the published 17.1.0 artifacts

      Two recipients, different locales, one notification, real createEmailChannel / createInboxChannel, stub email service capturing what reaches sendTemplate / renderTemplate:

      sendTemplate to=en@example.com locale="en"
      renderTemplate to=(inbox) locale="en"
      sendTemplate to=zh@example.com locale="en" <- zh-CN recipient
      renderTemplate to=(inbox) locale="en" <- zh-CN recipient
      

      The only lever is payload.locale, which is interpolated once before fan-out, so it is one value for the whole notification (verified at all three channel.send call sites in service-messaging: fanOut, the outbox single-delivery path, and processDigestGroup — each passes the same payload to every recipient).

      Also confirmed: sys_user has no locale field (and carries protection.lock: "full"), and sys_notification_preference has none either — so there is no per-recipient source to read even if a channel wanted one.

      service-messaging@17.2.0 is byte-identical on the two locale-resolution lines, so this is not a "fixed in a later release" situation.

      Why it is worth a wording fix rather than a shrug

      The doc block is the contract a consuming app reads. Quoted at face value it licenses exactly one conclusion — "convert the nodes and non-English users get non-English notifications" — which is false, and the conversion is a net regression when made on that belief (TEMPLATE_* failures classify permanent and dead-letter, and the inbox channel starts requiring an email service with renderTemplate() where inline text needed none).

      One nearby log line has the same issue — service-messaging/src/plugin.ts: "notify template refs resolve sys_email_template per recipient locale".

      Suggested fix

      Qualify the three sites the way email-channel.ts already does — name the resolved value the deployment default (II18nService.getDefaultLocale()), and note that a per-user locale is deferred by the 2026-08-13 ruling and layers in as an override when it lands. No behaviour change.

      Note packages/spec/src/automation/io-node-config.test.ts L277/L303 assert /recipient locale/ against these strings, so a reword touches those two assertions.

      Not filing the per-user-locale capability itself here — that is the deferred half of the 2026-08-13 ruling and belongs to whoever weighs the pull; hotcrm#1185 is one such datapoint and says so.


      Generated by Claude Code

      Activity

      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

      Metadata

      Metadata

      Assignees

      No one assigned

        Type

        Projects

        No projects

          Milestone

          No milestone

          Relationships

          None yet

          Development

          No branches or pull requests

          Issue actions

          , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
          Skip to content

          spec: NotifyConfigSchema template doc/description promises per-recipient locale resolution that the delivery path deliberately does not do (deployment default, ruled 2026-08-13) #12178

          Description

          @huangyiirene

          Found while implementing objectstack-ai/hotcrm#1185 (localize 16 notify nodes). The wording below is what made that card look actionable; the implementation is correct and the spec doc block is what drifted, so filing against packages/spec.

          The drift

          packages/spec/src/automation/io-node-config.zod.ts states, in the NotifyConfigSchema doc block (line ~135) and again in the template field .describe() (line ~188):

          • L135: "the delivery path resolves (name, recipient locale)per recipient at delivery time via IEmailService.sendTemplate({ template, locale })"
          • L188: "the delivery path resolves (name, recipient locale) at delivery time and renders subject/body per recipient"

          Read plainly, both say the recipient's own locale selects the template row.

          The delivery path's own source says the opposite, and says it honestly — packages/services/service-messaging/src/email-channel.ts L86-99:

          "The measured source, and its limits, spelled out: the platform has no per-user locale today (sys_user carries no locale column; the 2026-08-13 ruling defers one until measured pull) … So 'recipient locale' resolves to the deployment defaultII18nService.getDefaultLocale()."

          So "recipient locale" is a term of art here meaning deployment default, and the spec block is the one place it is not qualified.

          Measured on the published 17.1.0 artifacts

          Two recipients, different locales, one notification, real createEmailChannel / createInboxChannel, stub email service capturing what reaches sendTemplate / renderTemplate:

          sendTemplate to=en@example.com locale="en"
          renderTemplate to=(inbox) locale="en"
          sendTemplate to=zh@example.com locale="en" <- zh-CN recipient
          renderTemplate to=(inbox) locale="en" <- zh-CN recipient
          

          The only lever is payload.locale, which is interpolated once before fan-out, so it is one value for the whole notification (verified at all three channel.send call sites in service-messaging: fanOut, the outbox single-delivery path, and processDigestGroup — each passes the same payload to every recipient).

          Also confirmed: sys_user has no locale field (and carries protection.lock: "full"), and sys_notification_preference has none either — so there is no per-recipient source to read even if a channel wanted one.

          service-messaging@17.2.0 is byte-identical on the two locale-resolution lines, so this is not a "fixed in a later release" situation.

          Why it is worth a wording fix rather than a shrug

          The doc block is the contract a consuming app reads. Quoted at face value it licenses exactly one conclusion — "convert the nodes and non-English users get non-English notifications" — which is false, and the conversion is a net regression when made on that belief (TEMPLATE_* failures classify permanent and dead-letter, and the inbox channel starts requiring an email service with renderTemplate() where inline text needed none).

          One nearby log line has the same issue — service-messaging/src/plugin.ts: "notify template refs resolve sys_email_template per recipient locale".

          Suggested fix

          Qualify the three sites the way email-channel.ts already does — name the resolved value the deployment default (II18nService.getDefaultLocale()), and note that a per-user locale is deferred by the 2026-08-13 ruling and layers in as an override when it lands. No behaviour change.

          Note packages/spec/src/automation/io-node-config.test.ts L277/L303 assert /recipient locale/ against these strings, so a reword touches those two assertions.

          Not filing the per-user-locale capability itself here — that is the deferred half of the 2026-08-13 ruling and belongs to whoever weighs the pull; hotcrm#1185 is one such datapoint and says so.


          Generated by Claude Code

          Activity

          Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

          Metadata

          Metadata

          Assignees

          No one assigned

            Type

            Projects

            No projects

              Milestone

              No milestone

              Relationships

              None yet

              Development

              No branches or pull requests

              Issue actions

              , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
              Skip to content

              spec: NotifyConfigSchema template doc/description promises per-recipient locale resolution that the delivery path deliberately does not do (deployment default, ruled 2026-08-13) #12178

              Description

              @huangyiirene

              Found while implementing objectstack-ai/hotcrm#1185 (localize 16 notify nodes). The wording below is what made that card look actionable; the implementation is correct and the spec doc block is what drifted, so filing against packages/spec.

              The drift

              packages/spec/src/automation/io-node-config.zod.ts states, in the NotifyConfigSchema doc block (line ~135) and again in the template field .describe() (line ~188):

              • L135: "the delivery path resolves (name, recipient locale)per recipient at delivery time via IEmailService.sendTemplate({ template, locale })"
              • L188: "the delivery path resolves (name, recipient locale) at delivery time and renders subject/body per recipient"

              Read plainly, both say the recipient's own locale selects the template row.

              The delivery path's own source says the opposite, and says it honestly — packages/services/service-messaging/src/email-channel.ts L86-99:

              "The measured source, and its limits, spelled out: the platform has no per-user locale today (sys_user carries no locale column; the 2026-08-13 ruling defers one until measured pull) … So 'recipient locale' resolves to the deployment defaultII18nService.getDefaultLocale()."

              So "recipient locale" is a term of art here meaning deployment default, and the spec block is the one place it is not qualified.

              Measured on the published 17.1.0 artifacts

              Two recipients, different locales, one notification, real createEmailChannel / createInboxChannel, stub email service capturing what reaches sendTemplate / renderTemplate:

              sendTemplate to=en@example.com locale="en"
              renderTemplate to=(inbox) locale="en"
              sendTemplate to=zh@example.com locale="en" <- zh-CN recipient
              renderTemplate to=(inbox) locale="en" <- zh-CN recipient
              

              The only lever is payload.locale, which is interpolated once before fan-out, so it is one value for the whole notification (verified at all three channel.send call sites in service-messaging: fanOut, the outbox single-delivery path, and processDigestGroup — each passes the same payload to every recipient).

              Also confirmed: sys_user has no locale field (and carries protection.lock: "full"), and sys_notification_preference has none either — so there is no per-recipient source to read even if a channel wanted one.

              service-messaging@17.2.0 is byte-identical on the two locale-resolution lines, so this is not a "fixed in a later release" situation.

              Why it is worth a wording fix rather than a shrug

              The doc block is the contract a consuming app reads. Quoted at face value it licenses exactly one conclusion — "convert the nodes and non-English users get non-English notifications" — which is false, and the conversion is a net regression when made on that belief (TEMPLATE_* failures classify permanent and dead-letter, and the inbox channel starts requiring an email service with renderTemplate() where inline text needed none).

              One nearby log line has the same issue — service-messaging/src/plugin.ts: "notify template refs resolve sys_email_template per recipient locale".

              Suggested fix

              Qualify the three sites the way email-channel.ts already does — name the resolved value the deployment default (II18nService.getDefaultLocale()), and note that a per-user locale is deferred by the 2026-08-13 ruling and layers in as an override when it lands. No behaviour change.

              Note packages/spec/src/automation/io-node-config.test.ts L277/L303 assert /recipient locale/ against these strings, so a reword touches those two assertions.

              Not filing the per-user-locale capability itself here — that is the deferred half of the 2026-08-13 ruling and belongs to whoever weighs the pull; hotcrm#1185 is one such datapoint and says so.


              Generated by Claude Code

              Activity

              Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

              Metadata

              Metadata

              Assignees

              No one assigned

                Type

                Projects

                No projects

                  Milestone

                  No milestone

                  Relationships

                  None yet

                  Development

                  No branches or pull requests

                  Issue actions

                  , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
                  Skip to content

                  spec: NotifyConfigSchema template doc/description promises per-recipient locale resolution that the delivery path deliberately does not do (deployment default, ruled 2026-08-13) #12178

                  Description

                  @huangyiirene

                  Found while implementing objectstack-ai/hotcrm#1185 (localize 16 notify nodes). The wording below is what made that card look actionable; the implementation is correct and the spec doc block is what drifted, so filing against packages/spec.

                  The drift

                  packages/spec/src/automation/io-node-config.zod.ts states, in the NotifyConfigSchema doc block (line ~135) and again in the template field .describe() (line ~188):

                  • L135: "the delivery path resolves (name, recipient locale)per recipient at delivery time via IEmailService.sendTemplate({ template, locale })"
                  • L188: "the delivery path resolves (name, recipient locale) at delivery time and renders subject/body per recipient"

                  Read plainly, both say the recipient's own locale selects the template row.

                  The delivery path's own source says the opposite, and says it honestly — packages/services/service-messaging/src/email-channel.ts L86-99:

                  "The measured source, and its limits, spelled out: the platform has no per-user locale today (sys_user carries no locale column; the 2026-08-13 ruling defers one until measured pull) … So 'recipient locale' resolves to the deployment defaultII18nService.getDefaultLocale()."

                  So "recipient locale" is a term of art here meaning deployment default, and the spec block is the one place it is not qualified.

                  Measured on the published 17.1.0 artifacts

                  Two recipients, different locales, one notification, real createEmailChannel / createInboxChannel, stub email service capturing what reaches sendTemplate / renderTemplate:

                  sendTemplate to=en@example.com locale="en"
                  renderTemplate to=(inbox) locale="en"
                  sendTemplate to=zh@example.com locale="en" <- zh-CN recipient
                  renderTemplate to=(inbox) locale="en" <- zh-CN recipient
                  

                  The only lever is payload.locale, which is interpolated once before fan-out, so it is one value for the whole notification (verified at all three channel.send call sites in service-messaging: fanOut, the outbox single-delivery path, and processDigestGroup — each passes the same payload to every recipient).

                  Also confirmed: sys_user has no locale field (and carries protection.lock: "full"), and sys_notification_preference has none either — so there is no per-recipient source to read even if a channel wanted one.

                  service-messaging@17.2.0 is byte-identical on the two locale-resolution lines, so this is not a "fixed in a later release" situation.

                  Why it is worth a wording fix rather than a shrug

                  The doc block is the contract a consuming app reads. Quoted at face value it licenses exactly one conclusion — "convert the nodes and non-English users get non-English notifications" — which is false, and the conversion is a net regression when made on that belief (TEMPLATE_* failures classify permanent and dead-letter, and the inbox channel starts requiring an email service with renderTemplate() where inline text needed none).

                  One nearby log line has the same issue — service-messaging/src/plugin.ts: "notify template refs resolve sys_email_template per recipient locale".

                  Suggested fix

                  Qualify the three sites the way email-channel.ts already does — name the resolved value the deployment default (II18nService.getDefaultLocale()), and note that a per-user locale is deferred by the 2026-08-13 ruling and layers in as an override when it lands. No behaviour change.

                  Note packages/spec/src/automation/io-node-config.test.ts L277/L303 assert /recipient locale/ against these strings, so a reword touches those two assertions.

                  Not filing the per-user-locale capability itself here — that is the deferred half of the 2026-08-13 ruling and belongs to whoever weighs the pull; hotcrm#1185 is one such datapoint and says so.


                  Generated by Claude Code

                  Activity

                  Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

                  Metadata

                  Metadata

                  Assignees

                  No one assigned

                    Type

                    Projects

                    No projects

                      Milestone

                      No milestone

                      Relationships

                      None yet

                      Development

                      No branches or pull requests

                      Issue actions

                      , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
                      Skip to content

                      spec: NotifyConfigSchema template doc/description promises per-recipient locale resolution that the delivery path deliberately does not do (deployment default, ruled 2026-08-13) #12178

                      Description

                      @huangyiirene

                      Found while implementing objectstack-ai/hotcrm#1185 (localize 16 notify nodes). The wording below is what made that card look actionable; the implementation is correct and the spec doc block is what drifted, so filing against packages/spec.

                      The drift

                      packages/spec/src/automation/io-node-config.zod.ts states, in the NotifyConfigSchema doc block (line ~135) and again in the template field .describe() (line ~188):

                      • L135: "the delivery path resolves (name, recipient locale)per recipient at delivery time via IEmailService.sendTemplate({ template, locale })"
                      • L188: "the delivery path resolves (name, recipient locale) at delivery time and renders subject/body per recipient"

                      Read plainly, both say the recipient's own locale selects the template row.

                      The delivery path's own source says the opposite, and says it honestly — packages/services/service-messaging/src/email-channel.ts L86-99:

                      "The measured source, and its limits, spelled out: the platform has no per-user locale today (sys_user carries no locale column; the 2026-08-13 ruling defers one until measured pull) … So 'recipient locale' resolves to the deployment defaultII18nService.getDefaultLocale()."

                      So "recipient locale" is a term of art here meaning deployment default, and the spec block is the one place it is not qualified.

                      Measured on the published 17.1.0 artifacts

                      Two recipients, different locales, one notification, real createEmailChannel / createInboxChannel, stub email service capturing what reaches sendTemplate / renderTemplate:

                      sendTemplate to=en@example.com locale="en"
                      renderTemplate to=(inbox) locale="en"
                      sendTemplate to=zh@example.com locale="en" <- zh-CN recipient
                      renderTemplate to=(inbox) locale="en" <- zh-CN recipient
                      

                      The only lever is payload.locale, which is interpolated once before fan-out, so it is one value for the whole notification (verified at all three channel.send call sites in service-messaging: fanOut, the outbox single-delivery path, and processDigestGroup — each passes the same payload to every recipient).

                      Also confirmed: sys_user has no locale field (and carries protection.lock: "full"), and sys_notification_preference has none either — so there is no per-recipient source to read even if a channel wanted one.

                      service-messaging@17.2.0 is byte-identical on the two locale-resolution lines, so this is not a "fixed in a later release" situation.

                      Why it is worth a wording fix rather than a shrug

                      The doc block is the contract a consuming app reads. Quoted at face value it licenses exactly one conclusion — "convert the nodes and non-English users get non-English notifications" — which is false, and the conversion is a net regression when made on that belief (TEMPLATE_* failures classify permanent and dead-letter, and the inbox channel starts requiring an email service with renderTemplate() where inline text needed none).

                      One nearby log line has the same issue — service-messaging/src/plugin.ts: "notify template refs resolve sys_email_template per recipient locale".

                      Suggested fix

                      Qualify the three sites the way email-channel.ts already does — name the resolved value the deployment default (II18nService.getDefaultLocale()), and note that a per-user locale is deferred by the 2026-08-13 ruling and layers in as an override when it lands. No behaviour change.

                      Note packages/spec/src/automation/io-node-config.test.ts L277/L303 assert /recipient locale/ against these strings, so a reword touches those two assertions.

                      Not filing the per-user-locale capability itself here — that is the deferred half of the 2026-08-13 ruling and belongs to whoever weighs the pull; hotcrm#1185 is one such datapoint and says so.


                      Generated by Claude Code

                      Activity

                      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

                      Metadata

                      Metadata

                      Assignees

                      No one assigned

                        Type

                        Projects

                        No projects

                          Milestone

                          No milestone

                          Relationships

                          None yet

                          Development

                          No branches or pull requests

                          Issue actions

                          , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
                          Skip to content

                          spec: NotifyConfigSchema template doc/description promises per-recipient locale resolution that the delivery path deliberately does not do (deployment default, ruled 2026-08-13) #12178

                          Description

                          @huangyiirene

                          Found while implementing objectstack-ai/hotcrm#1185 (localize 16 notify nodes). The wording below is what made that card look actionable; the implementation is correct and the spec doc block is what drifted, so filing against packages/spec.

                          The drift

                          packages/spec/src/automation/io-node-config.zod.ts states, in the NotifyConfigSchema doc block (line ~135) and again in the template field .describe() (line ~188):

                          • L135: "the delivery path resolves (name, recipient locale)per recipient at delivery time via IEmailService.sendTemplate({ template, locale })"
                          • L188: "the delivery path resolves (name, recipient locale) at delivery time and renders subject/body per recipient"

                          Read plainly, both say the recipient's own locale selects the template row.

                          The delivery path's own source says the opposite, and says it honestly — packages/services/service-messaging/src/email-channel.ts L86-99:

                          "The measured source, and its limits, spelled out: the platform has no per-user locale today (sys_user carries no locale column; the 2026-08-13 ruling defers one until measured pull) … So 'recipient locale' resolves to the deployment defaultII18nService.getDefaultLocale()."

                          So "recipient locale" is a term of art here meaning deployment default, and the spec block is the one place it is not qualified.

                          Measured on the published 17.1.0 artifacts

                          Two recipients, different locales, one notification, real createEmailChannel / createInboxChannel, stub email service capturing what reaches sendTemplate / renderTemplate:

                          sendTemplate to=en@example.com locale="en"
                          renderTemplate to=(inbox) locale="en"
                          sendTemplate to=zh@example.com locale="en" <- zh-CN recipient
                          renderTemplate to=(inbox) locale="en" <- zh-CN recipient
                          

                          The only lever is payload.locale, which is interpolated once before fan-out, so it is one value for the whole notification (verified at all three channel.send call sites in service-messaging: fanOut, the outbox single-delivery path, and processDigestGroup — each passes the same payload to every recipient).

                          Also confirmed: sys_user has no locale field (and carries protection.lock: "full"), and sys_notification_preference has none either — so there is no per-recipient source to read even if a channel wanted one.

                          service-messaging@17.2.0 is byte-identical on the two locale-resolution lines, so this is not a "fixed in a later release" situation.

                          Why it is worth a wording fix rather than a shrug

                          The doc block is the contract a consuming app reads. Quoted at face value it licenses exactly one conclusion — "convert the nodes and non-English users get non-English notifications" — which is false, and the conversion is a net regression when made on that belief (TEMPLATE_* failures classify permanent and dead-letter, and the inbox channel starts requiring an email service with renderTemplate() where inline text needed none).

                          One nearby log line has the same issue — service-messaging/src/plugin.ts: "notify template refs resolve sys_email_template per recipient locale".

                          Suggested fix

                          Qualify the three sites the way email-channel.ts already does — name the resolved value the deployment default (II18nService.getDefaultLocale()), and note that a per-user locale is deferred by the 2026-08-13 ruling and layers in as an override when it lands. No behaviour change.

                          Note packages/spec/src/automation/io-node-config.test.ts L277/L303 assert /recipient locale/ against these strings, so a reword touches those two assertions.

                          Not filing the per-user-locale capability itself here — that is the deferred half of the 2026-08-13 ruling and belongs to whoever weighs the pull; hotcrm#1185 is one such datapoint and says so.


                          Generated by Claude Code

                          Activity

                          Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

                          Metadata

                          Metadata

                          Assignees

                          No one assigned

                            Type

                            Projects

                            No projects

                              Milestone

                              No milestone

                              Relationships

                              None yet

                              Development

                              No branches or pull requests

                              Issue actions

                              , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
                              Skip to content

                              spec: NotifyConfigSchema template doc/description promises per-recipient locale resolution that the delivery path deliberately does not do (deployment default, ruled 2026-08-13) #12178

                              Description

                              @huangyiirene

                              Found while implementing objectstack-ai/hotcrm#1185 (localize 16 notify nodes). The wording below is what made that card look actionable; the implementation is correct and the spec doc block is what drifted, so filing against packages/spec.

                              The drift

                              packages/spec/src/automation/io-node-config.zod.ts states, in the NotifyConfigSchema doc block (line ~135) and again in the template field .describe() (line ~188):

                              • L135: "the delivery path resolves (name, recipient locale)per recipient at delivery time via IEmailService.sendTemplate({ template, locale })"
                              • L188: "the delivery path resolves (name, recipient locale) at delivery time and renders subject/body per recipient"

                              Read plainly, both say the recipient's own locale selects the template row.

                              The delivery path's own source says the opposite, and says it honestly — packages/services/service-messaging/src/email-channel.ts L86-99:

                              "The measured source, and its limits, spelled out: the platform has no per-user locale today (sys_user carries no locale column; the 2026-08-13 ruling defers one until measured pull) … So 'recipient locale' resolves to the deployment defaultII18nService.getDefaultLocale()."

                              So "recipient locale" is a term of art here meaning deployment default, and the spec block is the one place it is not qualified.

                              Measured on the published 17.1.0 artifacts

                              Two recipients, different locales, one notification, real createEmailChannel / createInboxChannel, stub email service capturing what reaches sendTemplate / renderTemplate:

                              sendTemplate to=en@example.com locale="en"
                              renderTemplate to=(inbox) locale="en"
                              sendTemplate to=zh@example.com locale="en" <- zh-CN recipient
                              renderTemplate to=(inbox) locale="en" <- zh-CN recipient
                              

                              The only lever is payload.locale, which is interpolated once before fan-out, so it is one value for the whole notification (verified at all three channel.send call sites in service-messaging: fanOut, the outbox single-delivery path, and processDigestGroup — each passes the same payload to every recipient).

                              Also confirmed: sys_user has no locale field (and carries protection.lock: "full"), and sys_notification_preference has none either — so there is no per-recipient source to read even if a channel wanted one.

                              service-messaging@17.2.0 is byte-identical on the two locale-resolution lines, so this is not a "fixed in a later release" situation.

                              Why it is worth a wording fix rather than a shrug

                              The doc block is the contract a consuming app reads. Quoted at face value it licenses exactly one conclusion — "convert the nodes and non-English users get non-English notifications" — which is false, and the conversion is a net regression when made on that belief (TEMPLATE_* failures classify permanent and dead-letter, and the inbox channel starts requiring an email service with renderTemplate() where inline text needed none).

                              One nearby log line has the same issue — service-messaging/src/plugin.ts: "notify template refs resolve sys_email_template per recipient locale".

                              Suggested fix

                              Qualify the three sites the way email-channel.ts already does — name the resolved value the deployment default (II18nService.getDefaultLocale()), and note that a per-user locale is deferred by the 2026-08-13 ruling and layers in as an override when it lands. No behaviour change.

                              Note packages/spec/src/automation/io-node-config.test.ts L277/L303 assert /recipient locale/ against these strings, so a reword touches those two assertions.

                              Not filing the per-user-locale capability itself here — that is the deferred half of the 2026-08-13 ruling and belongs to whoever weighs the pull; hotcrm#1185 is one such datapoint and says so.


                              Generated by Claude Code

                              Activity

                              Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

                              Metadata

                              Metadata

                              Assignees

                              No one assigned

                                Type

                                Projects

                                No projects

                                  Milestone

                                  No milestone

                                  Relationships

                                  None yet

                                  Development

                                  No branches or pull requests

                                  Issue actions