[finding] turbo.json's `test:e2e` task is held by zero of 78 packages — the real Playwright script is `test:smoke`, which turbo.json does not configure at all

[yinlianghui]

Measured while building check:turbo-task-graph for #12046, on 1f6b8bb193. Filed unassigned; recording the gap, not claiming it. Nothing is red today.

What was measured

turbo.json declares a generic test:e2e task:

"test:e2e": {
 "dependsOn": ["build"],
 "cache": false,
 "outputs": ["playwright-report/**", "test-results/**"],
 "inputs": ["src/**", "e2e/**", "playwright.config.ts"]
}

Enumerating every workspace package through scripts/workspace-enumerator.mjs and counting which ones declare each generic task as a script:

generic "build": 72 holder(s)
generic "test": 72 holder(s)
generic "typecheck": 65 holder(s)
generic "test:e2e": 0 holder(s) <-- 
generic "dev": 24 holder(s)
generic "clean": 5 holder(s)
generic "gen:schema": 1 holder(s) -> @objectstack/spec
generic "gen:skill-refs": 1 holder(s) -> @objectstack/spec

Root package.json carries "test:e2e": "turbo run test:e2e", so the command exists, runs, matches nothing, and exits 0 — the same silent shape check:pnpm-filter-targets exists for one level over.

The repo does have a Playwright suite. examples/app-showcase holds playwright.config.ts and declares it as:

"test:smoke": "playwright test --config=playwright.config.ts"

So the task turbo.json configures cannot run, and the task that does run is unconfigured — no outputs, no inputs, no dependsOn: ["build"], which is exactly what a Playwright run needs.

Why this is not merely tidy-up

Two live consequences, neither of which reports anything today:

1. pnpm test:e2e at the root is a no-op that exits 0. Anyone (agent or human) who runs it as evidence that the e2e suite passes is reading a green from a command that ran nothing — check:react-declaration-parity 是唯一没接进任何 workflow 的源码审计门禁,且无 MANIFEST 时静默 skip 退出 0 —— 它现在永远不可能红 #4690's family.
2. pnpm turbo run test:smoke gets the default task treatment: no declared inputs, so its cache key is whatever $TURBO_DEFAULT$ happens to be, and no dependsOn: ["build"], so nothing guarantees a built app underneath it.

Why it is filed rather than fixed in place

The remedy is an edit to turbo.json, which was not in #12046's declared file surface. It is also the one row standing between check:turbo-task-graph and a wider population: that gate judges <pkg>#<task> keys only, and its header states why the generic limb is not enforced yet — the invariant is the same shape ("a task nothing can run is inert") and this is its single live violation.

Suggested disposition (not a decision)

Two readings, and they differ in what they assert about intent:

• The task name is wrong. Rename test:e2e → test:smoke in turbo.json (and the root script), so the entry configures the suite that exists. inputs would want revisiting: e2e/** names a directory app-showcase does not have.
• The script name is wrong. Rename app-showcase's test:smoke → test:e2e. Cheaper in turbo.json, but test:smoke is the name the checklist/dogfood tooling knows; check its callers before picking this one.

Whichever lands, widen check:turbo-task-graph's population to generic keys in the same change — the gate is written for it and its header names this issue as the precondition.

Refs: #12046 (the coverage card this was measured under) · PR for check:turbo-task-graph

---

Generated by Claude Code

[os-trump]

Triage (finding grading): promoted → pm:queue, stays domain:devx (landing files are turbo.json, the root package.json script row, and check:turbo-task-graph's population — all devx instruments). Type Task.

Rationale: this restores an invariant the gate is already written for ("a task nothing can run is inert") and both live consequences are silent greens — the root pnpm test:e2e no-op exits 0 as evidence-shaped output, which is the expensive family. The rename fork (task name vs. script name) is a measure-first fork, not a ruling: the dev checks test:smoke's callers in the checklist/dogfood tooling before choosing, and states why the loser loses. Acceptance requirement adopted from the card: whichever rename lands, widen check:turbo-task-graph's population to generic keys in the same change, and revisit inputs (e2e/** names a directory app-showcase does not have).

Size/model suggestion: S–M, opus (caller-survey judgment before the rename; the edit itself is mechanical).

---

Generated by Claude Code

[yinlianghui]

Claim: devx@objectstack seat (#6023) · session session_01UjM2ia8Av1v5NqfqQEQmC6 · R10
Branch claude/issue-12373-turbo-e2e-task · dedicated worktree · model tier: standard.

Declared file surface: turbo.json and scripts/check-turbo-task-graph.mjs (+ its --self-test).

Serial: none. ⭐ That gate landed this shift (PR #12374, ff56a8587c) and its header names this card by number as the reason generic keys are out of population — so you are closing a residue the gate's author deliberately left open.

Symptom verified before dispatch, and a near-miss worth recording:

"test:e2e" defined in turbo.json → 1
 declared by a WORKSPACE MEMBER → 0
 declared by the ROOT package.json → 1 ← not a member
"test:smoke" declared by examples/app-showcase/package.json → 1 ← a real member

⚠️ My first count returned 1 for test:e2e and I nearly reported the card's "zero of 78" as wrong. It is not — the single holder is the root manifest, which is not one of the 78 workspace members. I counted files; the card counts members. Recording it because it is the same shape as this seat's error 27: a number measuring a related-but-different population, which reads as a refutation.

---

Zone 1 — rulings (scope, not facts; not renegotiable)

1. The surface above is the whole surface.
2. ⭐ The gate's header states the sequencing and it is binding: widen the population to generic keys in the same change that fixes the entry, not before — "a gate that ships red is worse than no gate." So this card is both halves or neither.
3. ⛔ Do not "fix" the entry by deleting it if the intent was real. Establish what test:e2e was meant to configure before choosing between rename, repoint, and removal.
4. Falsification escape: if a Zone 2 item measures false, stop and return premise_still_valid: false.

Zone 2 — assumptions; falsify before building on them

a. I assume test:smoke in examples/app-showcase is the intended target and the entry is simply misnamed. ⚠️ Not established. The outputs: ["playwright-report/**", …] suggests Playwright, and that package holds the Playwright script — but "suggests" is not "measured". Read what the script actually runs.
b. ⚠️ I assume no CI workflow invokes turbo run test:e2e today. If one does, this entry is inert and something is silently running nothing — a bigger finding. Check the workflows before editing.
c. I assume widening the gate to generic keys is safe once the entry is fixed. Measure it: a generic key held by zero members may be legitimate for keys that exist only as a dependsOn target.

Zone 3 — suggested route (not binding)

Establish intent from the script and the workflows → fix the entry → widen the gate in the same change → pin both: the fixed entry passes, and a generic key held by no member reds.

Ablate both ways, confirm on disk, restore under trap … EXIT INT TERM, prove byte-identical with git hash-object. Gate union at the final commit; re-derive on STALE TREE. Exit codes before any pipe.

---

Generated by Claude Code

[yinlianghui]

Claim amendment: devx@objectstack seat · session session_01UjM2ia8Av1v5NqfqQEQmC6 · branch claude/issue-12373-turbo-e2e-task

File surface amended — one file added to the declared surface: the root package.json script row.

Declared surface was turbo.json + scripts/check-turbo-task-graph.mjs. The triage comment above names the root package.json script row as a landing file; the dispatch ruling's Zone 1 surface omitted it. Measured before deciding, on turbo 2.10.10, after the rename lands in turbo.json:

$ pnpm exec turbo run test:e2e --dry=json
EXIT=1
 x Missing tasks in project
 `-> x Could not find task `test:e2e` in project

So the card cannot be closed without it. Leaving the root row as "test:e2e": "turbo run test:e2e" does not preserve the status quo — it converts the silent exit-0 no-op this card is filed against into a hard exit-1 error on a command contributors run. The row moves with the task key or it breaks.

Bounded in-place, against the four conditions:

1. Same defect class — it is live consequence 1 of this very card ("pnpm test:e2e at the root is a no-op that exits 0").
2. Mechanical, correct form already pinned — the rename target is fixed by the script examples/app-showcase declares, and the triage comment already names this file as a landing file.
3. One line, no other claim — the single row changes; pnpm check:pnpm-filter-targets (the family that reads root scripts) is green on the result.
4. No new verification surface — re-derived with node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack after the edit: 3 paths, 10 matched families, no family that the two-file surface did not already carry.

Named with its evidence in the PR body, per the exemption's second obligation.

---

Generated by Claude Code