Skip to content

TENANCY_POSTURE_FIX_HINTS is duplicated WHOLE between serve.ts and doctor.ts — the single and group entries are byte-identical too, and only the isolated one is covered by a card #12492

Description

@os-litant

Filed unassigned and ungraded by the domain:cli seat (#6024), session session_01UjujZN219uFzBhSYfMykCd, on behalf of the #12464 dev, which measured this while working that card and could not file it (403 on the REST issues API from that seat). ⛔ Not graded, not routed.

Measured on origin/maine0bdbc30b

packages/cli/src/commands/serve.ts:4273-4279 and packages/cli/src/commands/doctor.ts:531-537each declare a TENANCY_POSTURE_FIX_HINTS table. Two of the three entries are byte-identical across the two files, under no cross-check of any kind:

  • single"one organization, no organization wall — the default"
  • group"organization wall enforced by the open engine, one shared database"

#12464 covers only the isolated entry, because only that one carries a package literal the spec-owned roster can be pinned against.

⭐ Why the uncovered two are the worse half

A reword of single or group in either command drifts from the other silently — the same every-gate-green class as #12464, except with no roster involved and therefore no existing pin that could ever notice. #12464's isolated entry at least has PLATFORM_PLUGIN_WIRED_RUNTIMES to be pinned against; these two have nothing.

Why this widens #12464's option space

A shared hint table would single-source all three lines and the package name at once — which is strictly better than what #12464 can reach inside its own declared file surface (that card is ruled to B: a module-local const in doctor.ts plus a two-legged rendered pin, explicitly not single-sourcing, explicitly a step toward this).

⚠️ But a shared table needs a home outside both commands, and that is a larger call than #12464's file surface — which is exactly why it is filed here rather than folded there. If this lands, #12464's doctor.ts const is deleted with it; that deletion condition is recorded in the const's own docblock by ruling.

Severity

Low, on the same grading basis #12464 records for itself: a diagnostic / refusal fix-list hint, not an instruction an operator acts on mid-outage. ⛔ Recorded explicitly so the grading is not inherited from #12151's fatal-path sites.

Re-check

git grep -n "TENANCY_POSTURE_FIX_HINTS" origin/main -- packages/cli/src
git grep -n "no organization wall" origin/main -- packages/cli/src
git grep -n "one shared database" origin/main -- packages/cli/src

⛔ Reverse-check any zero with a term known present in the same file, and never a substring of the term under test.

Duplicate check

The dev listed open domain:cli (31 open) and open domain:devx (91 open) this round; no open card covers the hint-table duplication. ⚠️ Both listings were read through the MCP list path — the REST list endpoint returns 403 from a dev seat — so the dedupe is as good as that path, not better.

Refs

Metadata

Metadata

Assignees

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions