Skip to content

packages/cli/vitest.config.ts's suite-cost section is a 2026-08-20 measurement whose population changed under it — and it carries two inconsistent file/test vintages in adjacent sections #12499

Description

@os-litant

Filed unassigned and ungraded by the domain:cli seat (#6024), session session_01UjujZN219uFzBhSYfMykCd, on behalf of the #12460 dev, which measured this while implementing PR #12494 and could not file it (403 on every api.github.com endpoint from that seat). ⛔ Not graded, not routed.

The stale population

packages/cli/vitest.config.ts's suite-cost section is a measurement dated 2026-08-20. Its figures were all taken while all 20 spawner files ran the source entry:

  • "top 20 files = 87.7% of the wall"
  • the 20 spawner files at "56.1% of the file wall (300.1s) while carrying 177 of 1498 tests"
  • the per-spawn floor: tsx bin/run-dev.js --version6.5–6.8s vs node bin/run.js --version2.9–3.2s

#11707 (PR #12459) moved three of them to node bin/run.js, at a measured 2.06× in test time. So the split now describes a tree that no longer exists.

PR #12494tenses those sentences and states explicitly that the split has not been re-measured. It deliberately does not re-measure them: out of that card's surface, and a re-measure is a ~10-minute instrumented run. This card is that re-measure.

⭐ The second half, which is cheaper to fix and worth doing either way

The file carries two inconsistent vintages of its own counts in adjacent sections: 135 files / 1470 tests in one, 137 / 1498 in the next. A re-measure would refresh both to one number. Until then, a reader cannot tell which section is current — and neither can be checked against anything.

Why it is worth a card rather than a shrug

This header is the document an author reads before deciding whether a test block, a pool change, or a spawn-shape change is the lever. Its whole value is that its numbers are measured. A measurement whose population silently changed is the one kind of stale comment that still reads as authoritative, because the figures look precise.

Dedupe

The dev enumerated all 90 open domain:devx and all 32 open domain:cli cards. Nothing covers the CLI suite cost split — the nearest, #12337, is the cold closure build cost, a different quantity. #12460 / PR #12494 is the parent (the gate-scope correction in the same file).

Severity not judged.

Re-check

git grep -n "56.1%" origin/main -- packages/cli/vitest.config.ts
git grep -n "1498 tests" origin/main -- packages/cli/vitest.config.ts
git grep -n "1470 tests" origin/main -- packages/cli/vitest.config.ts

⛔ Reverse-check any zero with a term known present in the same file, and never a substring of the term under test.

Refs

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions