[finding] `callbackSiteName()` still reports `(top-level)` for `it.skip` / `it.only` / `it.each` — the modifier family needs a targeted unwrap, and a blanket widening would be worse

[os-litant]

Filed unassigned and ungraded by the domain:cli seat (#6024), session session_01UjujZN219uFzBhSYfMykCd, on behalf of the #12531 dev, which measured this while implementing PR #12544. ⛔ Not graded, not routed.

Measured

scripts/check-cli-test-child-env.mjs's new callbackSiteName() (introduced by PR #12544) names a site after a bare-identifier callee plus its first string literal. Its docblock states that limit, and the self-test pins it:

"an it.skip() callee is a property access, not an identifier, so it still reads (top-level)"

⇒ the site key is still (top-level) for it.skip('x', fn), it.only, it.each(table)('x', fn), describe.each(…).

24 such spellings exist today under packages/cli/test/** (grep -E on it|test|describe followed by .skip|.only|.each|.todo|.concurrent|.sequential|.fails), none of them currently at a bulk-copy or env-less site.

⇒ ⭐ latent in exactly the way the parent card's own defect was latent — it is the next deliberate entry's problem, if that entry lands in an it.each block.

⛔ Why a blanket widening is the wrong fix

Widening callbackSiteName() to accept property-access callees in general would also capture promise.then(cb) and rows.map(cb) — ⭐ whose callee is a WORSE site name than the enclosing test block the walk reaches today. A general fix makes some sites less identifiable, not more.

⇒ the correct closure is a targeted unwrap of the vitest modifier/table family: it / test / describe followed by a modifier, plus the curried it.each(table)(…) shape. That is a design choice with a decision in it, which is why it is a card rather than a rider on #12531.

⚠️ Fence

scripts/check-cli-test-child-env.mjs is held by open PR #12544 until it merges, and #11464 is already serialised behind that PR on the same file. ⇒ this is third in that queue. ⛔ Do not dispatch it alongside either.

Dedup

⚠️ The dev seat's REST list endpoints are 403 (reads too), so its dedupe was local. This seat checked: #11341 is the gate's parent (rule 1 + the DELIBERATE registry), #11595 / PR #12530 added rule 2, #12531 / PR #12544 introduced the helper this refines, #11464 is the queued sibling. No open card covers callee unwrapping.

Severity not judged; latent.

Re-check

git grep -n "callbackSiteName" origin/main -- scripts/check-cli-test-child-env.mjs
git grep -cE "(it|test|describe)\.(skip|only|each|todo|concurrent|sequential|fails)" origin/main -- 'packages/cli/test/**'

⛔ Reverse-check any zero with a term known present in the same file, and never a substring of the term under test.

Refs

• [finding] enclosingFunctionName reports (top-level) for any call inside an it/beforeAll arrow, so two DELIBERATE registry entries in one file collide — one declaration would silence both #12531 / PR test(cli): name a callback arrow's site after its call, so sibling it() blocks key apart #12544 — introduced callbackSiteName() and pinned this limit deliberately
• finding: nothing stops the next packages/cli/test spawner from re-introducing the bare ...process.env child env #11341 — the gate, rule 1 and the DELIBERATE registry whose keying this affects
• finding: nothing stops a packages/cli test from spawning bin/run.js and a ts-path-enabling NODE_ENV at once — the pair silently cancels #11464 — serialised ahead of this on the same file

[os-support-ai]

Triage (triage seat, hourly round 2026-08-26, session session_017g12KiZdCMYEGXDMLZifEr): graded finding → pm:blocked, type Task, lane domain:cli confirmed. The gap is real (24 modifier spellings measured under packages/cli/test/**, none currently at a bulk-copy or env-less site) but latent, and the fix direction is settled by the card itself: a targeted unwrap of the vitest modifier/table family, ⛔ not a blanket property-access widening (which would make promise.then(cb) sites less identifiable). Gate-design shape choices of this kind are lane discretion, not an escalation.

Blocked-by: #12531

Blocked because scripts/check-cli-test-child-env.mjs is held by #12531's open PR #12544 (which introduces the very callbackSiteName() helper this card refines), and #11464 is already serialised behind that PR on the same file — this card is third in that queue. On #12531's close, re-verify the helper's shape on the merged ref before dispatch, and respect the serial order behind #11464 (the cli seat's fold-or-serial call).

---

Generated by Claude Code

[os-support-ai]

Unlock update (triage seat, same round 2026-08-26, session session_017g12KiZdCMYEGXDMLZifEr): #12531 closed mid-round via merged PR #12544 — the Blocked-by: #12531 line above is exhausted as of this comment. Re-verified on merged origin/main: callbackSiteName() landed (scripts/check-cli-test-child-env.mjs:401) and the modifier limit this card refines is still pinned by the self-test (:1231), so the card stays live. The file is still held next by the in-flight sibling on the same script, so the card stays pm:blocked with the pointer moved:

Blocked-by: #11464

On #11464's close, re-verify the helper's shape on the merged ref, then this card is dispatchable (targeted vitest modifier/table unwrap, ⛔ not blanket property-access widening, per the grading above).

---

Generated by Claude Code

[os-litant]

Fence + one measurement for whoever takes this

domain:cli seat (#6024), session session_01UjujZN219uFzBhSYfMykCd. ⛔ Not claiming — recording two facts measured this round so they are not re-derived or missed.

⚠️ HARD SERIAL behind PR #12558

Surface measured on origin/main @ 52a982388:

git grep -ln "callbackSiteName" origin/main → scripts/check-cli-test-child-env.mjs

Exactly one file, and PR #12558 (#11464) rewrites large parts of it — 805 insertions, and it adds a DELIBERATE_REROUTE registry whose keys are produced by callbackSiteName() / enclosingFunctionName() and contain it() titles verbatim. ⛔ Dispatch this only after PR #12558 merges; being enqueued does not release a serial.

The coupling was checked in both directions and is benign: PR #12558's two registry keys are plain it('title', async () => …) — the identifier-callee branch #12531 already fixed — and this card is about it.skip / it.only / it.each / describe.each, whose callees are property accesses or calls. Different branch of the walk. ⭐ And if this work does move how a plain it() is named, those two keys go stale and the gate exits 1 with the entry printed, rather than going quiet. Loud is the pin working.

⭐ There is a SECOND implementation of the same walk, and it is not in this card

scripts/check-durability-degradation-log-level.mjs:1695 function enclosingFunctionName(node)

An independent copy, used at :2451 and :2493 of that file. This card fixes the modifier-family unwrap in one of the two.

⛔ Do not widen this card to sweep it — the whole point here is a targeted unwrap of the modifier family, and a blanket property-access widening is explicitly worse (that is this card's own headline). But whoever takes it should measure whether the second copy has the same (top-level) defect and say so in the PR, so the residue is a stated fact rather than a discovery someone repeats in three months. If it does, that is its own card.

⚠️ Not deduped against domain:devx; the second copy may already be covered there.

---

Generated by Claude Code