Skip to content

[finding] plugins.scim / plugins.sso are undeclared config keys that read as configuration but cannot ever change the outcome — the env var always outranks them #13439

Description

@baozhoutao

Surfaced from the cloud side while implementing objectstack-ai/cloud#1451 (hardening the cloud control plane's own AuthPlugin against an ambient OS_SCIM_ENABLED). Filed unassigned, recording a framework contract gap; the cloud card is parked on the decision this issue describes.

Measured at 1a540e82b1421c26ea036ff67e381689075b501c (the SHA cloud/.objectstack-sha currently pins) and re-checked on main at the same line — no drift between them.

The two halves

1. The keys are not declared.AuthPluginConfigSchema (packages/spec/src/system/auth-config.zod.ts:20) declares exactly ten keys: organization, twoFactor, passkeys, passwordRejectBreached, magicLink, oidcProvider, dynamicClientRegistration, deviceAuthorization, admin, phoneNumber. buildPluginList nevertheless reads three more off the same object through an any cast (packages/plugins/plugin-auth/src/auth-manager.ts):

:2426 const scimEffective = scimFromEnv ?? (pluginConfig as any).scim ?? false;
:2445 scim: scimEffective,
:2446 sso: ssoFromEnv ?? (pluginConfig as any).sso ?? false,
ssoDomainVerification: ssoDomainVerifyFromEnv ?? (pluginConfig as any).ssoDomainVerification ?? false,

So plugins.scim is a key an author can write, that typechecks only because of the cast, that no schema documents, and that no publish-time check would ever reject or confirm.

2. Where it IS read, the env var always wins.readBooleanEnv (auth-manager.ts:256) returns undefined only when the variable is absent; any present value — including the empty string — resolves to a boolean. Because scimFromEnv is the left operand of the ?? chain, a host that writes plugins: { scim: false } gets no effect at all whenever OS_SCIM_ENABLED is set. The same holds for sso / OS_SSO_ENABLED.

The precedence itself is deliberate and documented in the block comment above it ("the env var WINS over the config-file setting so platform operators can override per-environment without touching the application bundle"). The gap is not that operators can override — it is that a host has no counterpart: there is no declared way for the code that constructs AuthPlugin to state a value the deployment env cannot silently outrank.

Why this is worth a decision rather than a patch

The combination is the sharp part. An undeclared key that is read anyway reads, to any author, as the supported way to say "not on this surface" — and it is silently inert in exactly the deployments where it matters. The cloud-side card walked into precisely that: its accepted fix sketch was "pass an explicit scim: false at the control plane's AuthPlugin construction", which the reading above shows would have shipped a line that looks like a security control, passes review, passes typecheck, and changes nothing.

dynamicClientRegistration already shows the shape the platform uses when a host needs to force a value against a default: a declared, tri-statez.boolean().optional() whose docstring spells out what unset means. scim and sso have neither the declaration nor the tri-state.

Amplification worth naming, since it is not local to the SCIM line: admin: pluginConfig.admin ?? scimEffective (:2439, mirrored at :5064). A deployment that never asked for the better-auth admin plugin gets it — impersonate-user, set-user-password, ban-user — as a side effect of the same variable, and has the same non-existent means of declining it.

Options

  • A. Declare scim, sso, ssoDomainVerification in AuthPluginConfigSchema as tri-state z.boolean().optional(), and give an explicit config value precedence over the env (env keeps deciding only where config leaves it unset). Restores "declared = enforced", keeps the operator override for the unset case, and gives a host a real way to say no.
  • B. Keep env-wins, add a separate narrow host-forced channel (a distinct declared field, or an option that scopes which env overrides an instance honors).
  • C. Declare the keys but keep them env-subordinate, and document them as advisory. Cheapest, and leaves the misleading-affordance half unfixed.

Recommendation is A: it is the only option under which the key means what an author reading it would assume, and it is the direction the platform already took for dynamicClientRegistration. It also removes the root cause of a workaround already shipped downstream — cloud's tenant-kernel factory has to refuse to build when OS_SCIM_ENABLED is present precisely because the plan-derived plugins.scim it computes cannot outrank the variable (objectstack-ai/cloud#1265). Under A that plan gate would simply be authoritative.

Note on scope discipline: A changes documented precedence for these three keys only, and only for the case where a host states a value explicitly — no deployment that leaves them unset sees any change.

Not reproduced against a running deployment; this is read off the source at the SHA above plus the corroborating comments in cloud's own artifact-kernel-factory.scim.test.ts / .scim-env-guard.test.ts, which independently document the same resolution order.

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingdomain:specpriority:p1High: required for production / M2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    , 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
     blocks
    (function() {
    function addCopyButtons() {
    document.querySelectorAll('pre code').forEach(function(codeBlock) {
    if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
    codeBlock.parentElement.setAttribute('data-copy-added', 'true');
    var btn = document.createElement('button');
    btn.textContent = 'Copy';
    btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
    btn.onmouseover = function() { this.style.opacity = '1'; };
    btn.onmouseout = function() { this.style.opacity = '0.7'; };
    btn.onclick = function() {
    navigator.clipboard.writeText(codeBlock.textContent).then(function() {
    btn.textContent = 'Copied!';
    setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
    });
    };
    codeBlock.parentElement.style.position = 'relative';
    codeBlock.parentElement.appendChild(btn);
    });
    }
    addCopyButtons();
    // Re-run on dynamic content
    var observer = new MutationObserver(addCopyButtons);
    observer.observe(document.body, { childList: true, subtree: true });
    })();
    }
    } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
    })();
    (function(){
    try {
    var __m = "github.com";
    var __re = new RegExp('^' + "github\\.com" + '
    [finding] `plugins.scim` / `plugins.sso` are undeclared config keys that read as configuration but cannot ever change the outcome — the env var always outranks them · Issue #13439 · objectstack-ai/objectstack · GitHub
    Skip to content

    [finding] plugins.scim / plugins.sso are undeclared config keys that read as configuration but cannot ever change the outcome — the env var always outranks them #13439

    Description

    @baozhoutao

    Surfaced from the cloud side while implementing objectstack-ai/cloud#1451 (hardening the cloud control plane's own AuthPlugin against an ambient OS_SCIM_ENABLED). Filed unassigned, recording a framework contract gap; the cloud card is parked on the decision this issue describes.

    Measured at 1a540e82b1421c26ea036ff67e381689075b501c (the SHA cloud/.objectstack-sha currently pins) and re-checked on main at the same line — no drift between them.

    The two halves

    1. The keys are not declared.AuthPluginConfigSchema (packages/spec/src/system/auth-config.zod.ts:20) declares exactly ten keys: organization, twoFactor, passkeys, passwordRejectBreached, magicLink, oidcProvider, dynamicClientRegistration, deviceAuthorization, admin, phoneNumber. buildPluginList nevertheless reads three more off the same object through an any cast (packages/plugins/plugin-auth/src/auth-manager.ts):

    :2426 const scimEffective = scimFromEnv ?? (pluginConfig as any).scim ?? false;
    :2445 scim: scimEffective,
    :2446 sso: ssoFromEnv ?? (pluginConfig as any).sso ?? false,
    ssoDomainVerification: ssoDomainVerifyFromEnv ?? (pluginConfig as any).ssoDomainVerification ?? false,
    

    So plugins.scim is a key an author can write, that typechecks only because of the cast, that no schema documents, and that no publish-time check would ever reject or confirm.

    2. Where it IS read, the env var always wins.readBooleanEnv (auth-manager.ts:256) returns undefined only when the variable is absent; any present value — including the empty string — resolves to a boolean. Because scimFromEnv is the left operand of the ?? chain, a host that writes plugins: { scim: false } gets no effect at all whenever OS_SCIM_ENABLED is set. The same holds for sso / OS_SSO_ENABLED.

    The precedence itself is deliberate and documented in the block comment above it ("the env var WINS over the config-file setting so platform operators can override per-environment without touching the application bundle"). The gap is not that operators can override — it is that a host has no counterpart: there is no declared way for the code that constructs AuthPlugin to state a value the deployment env cannot silently outrank.

    Why this is worth a decision rather than a patch

    The combination is the sharp part. An undeclared key that is read anyway reads, to any author, as the supported way to say "not on this surface" — and it is silently inert in exactly the deployments where it matters. The cloud-side card walked into precisely that: its accepted fix sketch was "pass an explicit scim: false at the control plane's AuthPlugin construction", which the reading above shows would have shipped a line that looks like a security control, passes review, passes typecheck, and changes nothing.

    dynamicClientRegistration already shows the shape the platform uses when a host needs to force a value against a default: a declared, tri-statez.boolean().optional() whose docstring spells out what unset means. scim and sso have neither the declaration nor the tri-state.

    Amplification worth naming, since it is not local to the SCIM line: admin: pluginConfig.admin ?? scimEffective (:2439, mirrored at :5064). A deployment that never asked for the better-auth admin plugin gets it — impersonate-user, set-user-password, ban-user — as a side effect of the same variable, and has the same non-existent means of declining it.

    Options

    • A. Declare scim, sso, ssoDomainVerification in AuthPluginConfigSchema as tri-state z.boolean().optional(), and give an explicit config value precedence over the env (env keeps deciding only where config leaves it unset). Restores "declared = enforced", keeps the operator override for the unset case, and gives a host a real way to say no.
    • B. Keep env-wins, add a separate narrow host-forced channel (a distinct declared field, or an option that scopes which env overrides an instance honors).
    • C. Declare the keys but keep them env-subordinate, and document them as advisory. Cheapest, and leaves the misleading-affordance half unfixed.

    Recommendation is A: it is the only option under which the key means what an author reading it would assume, and it is the direction the platform already took for dynamicClientRegistration. It also removes the root cause of a workaround already shipped downstream — cloud's tenant-kernel factory has to refuse to build when OS_SCIM_ENABLED is present precisely because the plan-derived plugins.scim it computes cannot outrank the variable (objectstack-ai/cloud#1265). Under A that plan gate would simply be authoritative.

    Note on scope discipline: A changes documented precedence for these three keys only, and only for the case where a host states a value explicitly — no deployment that leaves them unset sees any change.

    Not reproduced against a running deployment; this is read off the source at the SHA above plus the corroborating comments in cloud's own artifact-kernel-factory.scim.test.ts / .scim-env-guard.test.ts, which independently document the same resolution order.

    Metadata

    Metadata

    Assignees

    Labels

    bugSomething isn't workingdomain:specpriority:p1High: required for production / M2

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      , 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [finding] `plugins.scim` / `plugins.sso` are undeclared config keys that read as configuration but cannot ever change the outcome — the env var always outranks them · Issue #13439 · objectstack-ai/objectstack · GitHub
      Skip to content

      [finding] plugins.scim / plugins.sso are undeclared config keys that read as configuration but cannot ever change the outcome — the env var always outranks them #13439

      Description

      @baozhoutao

      Surfaced from the cloud side while implementing objectstack-ai/cloud#1451 (hardening the cloud control plane's own AuthPlugin against an ambient OS_SCIM_ENABLED). Filed unassigned, recording a framework contract gap; the cloud card is parked on the decision this issue describes.

      Measured at 1a540e82b1421c26ea036ff67e381689075b501c (the SHA cloud/.objectstack-sha currently pins) and re-checked on main at the same line — no drift between them.

      The two halves

      1. The keys are not declared.AuthPluginConfigSchema (packages/spec/src/system/auth-config.zod.ts:20) declares exactly ten keys: organization, twoFactor, passkeys, passwordRejectBreached, magicLink, oidcProvider, dynamicClientRegistration, deviceAuthorization, admin, phoneNumber. buildPluginList nevertheless reads three more off the same object through an any cast (packages/plugins/plugin-auth/src/auth-manager.ts):

      :2426 const scimEffective = scimFromEnv ?? (pluginConfig as any).scim ?? false;
      :2445 scim: scimEffective,
      :2446 sso: ssoFromEnv ?? (pluginConfig as any).sso ?? false,
      ssoDomainVerification: ssoDomainVerifyFromEnv ?? (pluginConfig as any).ssoDomainVerification ?? false,
      

      So plugins.scim is a key an author can write, that typechecks only because of the cast, that no schema documents, and that no publish-time check would ever reject or confirm.

      2. Where it IS read, the env var always wins.readBooleanEnv (auth-manager.ts:256) returns undefined only when the variable is absent; any present value — including the empty string — resolves to a boolean. Because scimFromEnv is the left operand of the ?? chain, a host that writes plugins: { scim: false } gets no effect at all whenever OS_SCIM_ENABLED is set. The same holds for sso / OS_SSO_ENABLED.

      The precedence itself is deliberate and documented in the block comment above it ("the env var WINS over the config-file setting so platform operators can override per-environment without touching the application bundle"). The gap is not that operators can override — it is that a host has no counterpart: there is no declared way for the code that constructs AuthPlugin to state a value the deployment env cannot silently outrank.

      Why this is worth a decision rather than a patch

      The combination is the sharp part. An undeclared key that is read anyway reads, to any author, as the supported way to say "not on this surface" — and it is silently inert in exactly the deployments where it matters. The cloud-side card walked into precisely that: its accepted fix sketch was "pass an explicit scim: false at the control plane's AuthPlugin construction", which the reading above shows would have shipped a line that looks like a security control, passes review, passes typecheck, and changes nothing.

      dynamicClientRegistration already shows the shape the platform uses when a host needs to force a value against a default: a declared, tri-statez.boolean().optional() whose docstring spells out what unset means. scim and sso have neither the declaration nor the tri-state.

      Amplification worth naming, since it is not local to the SCIM line: admin: pluginConfig.admin ?? scimEffective (:2439, mirrored at :5064). A deployment that never asked for the better-auth admin plugin gets it — impersonate-user, set-user-password, ban-user — as a side effect of the same variable, and has the same non-existent means of declining it.

      Options

      • A. Declare scim, sso, ssoDomainVerification in AuthPluginConfigSchema as tri-state z.boolean().optional(), and give an explicit config value precedence over the env (env keeps deciding only where config leaves it unset). Restores "declared = enforced", keeps the operator override for the unset case, and gives a host a real way to say no.
      • B. Keep env-wins, add a separate narrow host-forced channel (a distinct declared field, or an option that scopes which env overrides an instance honors).
      • C. Declare the keys but keep them env-subordinate, and document them as advisory. Cheapest, and leaves the misleading-affordance half unfixed.

      Recommendation is A: it is the only option under which the key means what an author reading it would assume, and it is the direction the platform already took for dynamicClientRegistration. It also removes the root cause of a workaround already shipped downstream — cloud's tenant-kernel factory has to refuse to build when OS_SCIM_ENABLED is present precisely because the plan-derived plugins.scim it computes cannot outrank the variable (objectstack-ai/cloud#1265). Under A that plan gate would simply be authoritative.

      Note on scope discipline: A changes documented precedence for these three keys only, and only for the case where a host states a value explicitly — no deployment that leaves them unset sees any change.

      Not reproduced against a running deployment; this is read off the source at the SHA above plus the corroborating comments in cloud's own artifact-kernel-factory.scim.test.ts / .scim-env-guard.test.ts, which independently document the same resolution order.

      Metadata

      Metadata

      Assignees

      Labels

      bugSomething isn't workingdomain:specpriority:p1High: required for production / M2

      Type

      No type

      Projects

      No projects

        Milestone

        No milestone

        Relationships

        None yet

        Development

        No branches or pull requests

        Issue actions

        , 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [finding] `plugins.scim` / `plugins.sso` are undeclared config keys that read as configuration but cannot ever change the outcome — the env var always outranks them · Issue #13439 · objectstack-ai/objectstack · GitHub
        Skip to content

        [finding] plugins.scim / plugins.sso are undeclared config keys that read as configuration but cannot ever change the outcome — the env var always outranks them #13439

        Description

        @baozhoutao

        Surfaced from the cloud side while implementing objectstack-ai/cloud#1451 (hardening the cloud control plane's own AuthPlugin against an ambient OS_SCIM_ENABLED). Filed unassigned, recording a framework contract gap; the cloud card is parked on the decision this issue describes.

        Measured at 1a540e82b1421c26ea036ff67e381689075b501c (the SHA cloud/.objectstack-sha currently pins) and re-checked on main at the same line — no drift between them.

        The two halves

        1. The keys are not declared.AuthPluginConfigSchema (packages/spec/src/system/auth-config.zod.ts:20) declares exactly ten keys: organization, twoFactor, passkeys, passwordRejectBreached, magicLink, oidcProvider, dynamicClientRegistration, deviceAuthorization, admin, phoneNumber. buildPluginList nevertheless reads three more off the same object through an any cast (packages/plugins/plugin-auth/src/auth-manager.ts):

        :2426 const scimEffective = scimFromEnv ?? (pluginConfig as any).scim ?? false;
        :2445 scim: scimEffective,
        :2446 sso: ssoFromEnv ?? (pluginConfig as any).sso ?? false,
        ssoDomainVerification: ssoDomainVerifyFromEnv ?? (pluginConfig as any).ssoDomainVerification ?? false,
        

        So plugins.scim is a key an author can write, that typechecks only because of the cast, that no schema documents, and that no publish-time check would ever reject or confirm.

        2. Where it IS read, the env var always wins.readBooleanEnv (auth-manager.ts:256) returns undefined only when the variable is absent; any present value — including the empty string — resolves to a boolean. Because scimFromEnv is the left operand of the ?? chain, a host that writes plugins: { scim: false } gets no effect at all whenever OS_SCIM_ENABLED is set. The same holds for sso / OS_SSO_ENABLED.

        The precedence itself is deliberate and documented in the block comment above it ("the env var WINS over the config-file setting so platform operators can override per-environment without touching the application bundle"). The gap is not that operators can override — it is that a host has no counterpart: there is no declared way for the code that constructs AuthPlugin to state a value the deployment env cannot silently outrank.

        Why this is worth a decision rather than a patch

        The combination is the sharp part. An undeclared key that is read anyway reads, to any author, as the supported way to say "not on this surface" — and it is silently inert in exactly the deployments where it matters. The cloud-side card walked into precisely that: its accepted fix sketch was "pass an explicit scim: false at the control plane's AuthPlugin construction", which the reading above shows would have shipped a line that looks like a security control, passes review, passes typecheck, and changes nothing.

        dynamicClientRegistration already shows the shape the platform uses when a host needs to force a value against a default: a declared, tri-statez.boolean().optional() whose docstring spells out what unset means. scim and sso have neither the declaration nor the tri-state.

        Amplification worth naming, since it is not local to the SCIM line: admin: pluginConfig.admin ?? scimEffective (:2439, mirrored at :5064). A deployment that never asked for the better-auth admin plugin gets it — impersonate-user, set-user-password, ban-user — as a side effect of the same variable, and has the same non-existent means of declining it.

        Options

        • A. Declare scim, sso, ssoDomainVerification in AuthPluginConfigSchema as tri-state z.boolean().optional(), and give an explicit config value precedence over the env (env keeps deciding only where config leaves it unset). Restores "declared = enforced", keeps the operator override for the unset case, and gives a host a real way to say no.
        • B. Keep env-wins, add a separate narrow host-forced channel (a distinct declared field, or an option that scopes which env overrides an instance honors).
        • C. Declare the keys but keep them env-subordinate, and document them as advisory. Cheapest, and leaves the misleading-affordance half unfixed.

        Recommendation is A: it is the only option under which the key means what an author reading it would assume, and it is the direction the platform already took for dynamicClientRegistration. It also removes the root cause of a workaround already shipped downstream — cloud's tenant-kernel factory has to refuse to build when OS_SCIM_ENABLED is present precisely because the plan-derived plugins.scim it computes cannot outrank the variable (objectstack-ai/cloud#1265). Under A that plan gate would simply be authoritative.

        Note on scope discipline: A changes documented precedence for these three keys only, and only for the case where a host states a value explicitly — no deployment that leaves them unset sees any change.

        Not reproduced against a running deployment; this is read off the source at the SHA above plus the corroborating comments in cloud's own artifact-kernel-factory.scim.test.ts / .scim-env-guard.test.ts, which independently document the same resolution order.

        Metadata

        Metadata

        Assignees

        Labels

        bugSomething isn't workingdomain:specpriority:p1High: required for production / M2

        Type

        No type

        Projects

        No projects

          Milestone

          No milestone

          Relationships

          None yet

          Development

          No branches or pull requests

          Issue actions

          , 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' [finding] `plugins.scim` / `plugins.sso` are undeclared config keys that read as configuration but cannot ever change the outcome — the env var always outranks them · Issue #13439 · objectstack-ai/objectstack · GitHub
          Skip to content

          [finding] plugins.scim / plugins.sso are undeclared config keys that read as configuration but cannot ever change the outcome — the env var always outranks them #13439

          Description

          @baozhoutao

          Surfaced from the cloud side while implementing objectstack-ai/cloud#1451 (hardening the cloud control plane's own AuthPlugin against an ambient OS_SCIM_ENABLED). Filed unassigned, recording a framework contract gap; the cloud card is parked on the decision this issue describes.

          Measured at 1a540e82b1421c26ea036ff67e381689075b501c (the SHA cloud/.objectstack-sha currently pins) and re-checked on main at the same line — no drift between them.

          The two halves

          1. The keys are not declared.AuthPluginConfigSchema (packages/spec/src/system/auth-config.zod.ts:20) declares exactly ten keys: organization, twoFactor, passkeys, passwordRejectBreached, magicLink, oidcProvider, dynamicClientRegistration, deviceAuthorization, admin, phoneNumber. buildPluginList nevertheless reads three more off the same object through an any cast (packages/plugins/plugin-auth/src/auth-manager.ts):

          :2426 const scimEffective = scimFromEnv ?? (pluginConfig as any).scim ?? false;
          :2445 scim: scimEffective,
          :2446 sso: ssoFromEnv ?? (pluginConfig as any).sso ?? false,
          ssoDomainVerification: ssoDomainVerifyFromEnv ?? (pluginConfig as any).ssoDomainVerification ?? false,
          

          So plugins.scim is a key an author can write, that typechecks only because of the cast, that no schema documents, and that no publish-time check would ever reject or confirm.

          2. Where it IS read, the env var always wins.readBooleanEnv (auth-manager.ts:256) returns undefined only when the variable is absent; any present value — including the empty string — resolves to a boolean. Because scimFromEnv is the left operand of the ?? chain, a host that writes plugins: { scim: false } gets no effect at all whenever OS_SCIM_ENABLED is set. The same holds for sso / OS_SSO_ENABLED.

          The precedence itself is deliberate and documented in the block comment above it ("the env var WINS over the config-file setting so platform operators can override per-environment without touching the application bundle"). The gap is not that operators can override — it is that a host has no counterpart: there is no declared way for the code that constructs AuthPlugin to state a value the deployment env cannot silently outrank.

          Why this is worth a decision rather than a patch

          The combination is the sharp part. An undeclared key that is read anyway reads, to any author, as the supported way to say "not on this surface" — and it is silently inert in exactly the deployments where it matters. The cloud-side card walked into precisely that: its accepted fix sketch was "pass an explicit scim: false at the control plane's AuthPlugin construction", which the reading above shows would have shipped a line that looks like a security control, passes review, passes typecheck, and changes nothing.

          dynamicClientRegistration already shows the shape the platform uses when a host needs to force a value against a default: a declared, tri-statez.boolean().optional() whose docstring spells out what unset means. scim and sso have neither the declaration nor the tri-state.

          Amplification worth naming, since it is not local to the SCIM line: admin: pluginConfig.admin ?? scimEffective (:2439, mirrored at :5064). A deployment that never asked for the better-auth admin plugin gets it — impersonate-user, set-user-password, ban-user — as a side effect of the same variable, and has the same non-existent means of declining it.

          Options

          • A. Declare scim, sso, ssoDomainVerification in AuthPluginConfigSchema as tri-state z.boolean().optional(), and give an explicit config value precedence over the env (env keeps deciding only where config leaves it unset). Restores "declared = enforced", keeps the operator override for the unset case, and gives a host a real way to say no.
          • B. Keep env-wins, add a separate narrow host-forced channel (a distinct declared field, or an option that scopes which env overrides an instance honors).
          • C. Declare the keys but keep them env-subordinate, and document them as advisory. Cheapest, and leaves the misleading-affordance half unfixed.

          Recommendation is A: it is the only option under which the key means what an author reading it would assume, and it is the direction the platform already took for dynamicClientRegistration. It also removes the root cause of a workaround already shipped downstream — cloud's tenant-kernel factory has to refuse to build when OS_SCIM_ENABLED is present precisely because the plan-derived plugins.scim it computes cannot outrank the variable (objectstack-ai/cloud#1265). Under A that plan gate would simply be authoritative.

          Note on scope discipline: A changes documented precedence for these three keys only, and only for the case where a host states a value explicitly — no deployment that leaves them unset sees any change.

          Not reproduced against a running deployment; this is read off the source at the SHA above plus the corroborating comments in cloud's own artifact-kernel-factory.scim.test.ts / .scim-env-guard.test.ts, which independently document the same resolution order.

          Metadata

          Metadata

          Assignees

          Labels

          bugSomething isn't workingdomain:specpriority:p1High: required for production / M2

          Type

          No type

          Projects

          No projects

            Milestone

            No milestone

            Relationships

            None yet

            Development

            No branches or pull requests

            Issue actions

            , 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [finding] `plugins.scim` / `plugins.sso` are undeclared config keys that read as configuration but cannot ever change the outcome — the env var always outranks them · Issue #13439 · objectstack-ai/objectstack · GitHub
            Skip to content

            [finding] plugins.scim / plugins.sso are undeclared config keys that read as configuration but cannot ever change the outcome — the env var always outranks them #13439

            Description

            @baozhoutao

            Surfaced from the cloud side while implementing objectstack-ai/cloud#1451 (hardening the cloud control plane's own AuthPlugin against an ambient OS_SCIM_ENABLED). Filed unassigned, recording a framework contract gap; the cloud card is parked on the decision this issue describes.

            Measured at 1a540e82b1421c26ea036ff67e381689075b501c (the SHA cloud/.objectstack-sha currently pins) and re-checked on main at the same line — no drift between them.

            The two halves

            1. The keys are not declared.AuthPluginConfigSchema (packages/spec/src/system/auth-config.zod.ts:20) declares exactly ten keys: organization, twoFactor, passkeys, passwordRejectBreached, magicLink, oidcProvider, dynamicClientRegistration, deviceAuthorization, admin, phoneNumber. buildPluginList nevertheless reads three more off the same object through an any cast (packages/plugins/plugin-auth/src/auth-manager.ts):

            :2426 const scimEffective = scimFromEnv ?? (pluginConfig as any).scim ?? false;
            :2445 scim: scimEffective,
            :2446 sso: ssoFromEnv ?? (pluginConfig as any).sso ?? false,
            ssoDomainVerification: ssoDomainVerifyFromEnv ?? (pluginConfig as any).ssoDomainVerification ?? false,
            

            So plugins.scim is a key an author can write, that typechecks only because of the cast, that no schema documents, and that no publish-time check would ever reject or confirm.

            2. Where it IS read, the env var always wins.readBooleanEnv (auth-manager.ts:256) returns undefined only when the variable is absent; any present value — including the empty string — resolves to a boolean. Because scimFromEnv is the left operand of the ?? chain, a host that writes plugins: { scim: false } gets no effect at all whenever OS_SCIM_ENABLED is set. The same holds for sso / OS_SSO_ENABLED.

            The precedence itself is deliberate and documented in the block comment above it ("the env var WINS over the config-file setting so platform operators can override per-environment without touching the application bundle"). The gap is not that operators can override — it is that a host has no counterpart: there is no declared way for the code that constructs AuthPlugin to state a value the deployment env cannot silently outrank.

            Why this is worth a decision rather than a patch

            The combination is the sharp part. An undeclared key that is read anyway reads, to any author, as the supported way to say "not on this surface" — and it is silently inert in exactly the deployments where it matters. The cloud-side card walked into precisely that: its accepted fix sketch was "pass an explicit scim: false at the control plane's AuthPlugin construction", which the reading above shows would have shipped a line that looks like a security control, passes review, passes typecheck, and changes nothing.

            dynamicClientRegistration already shows the shape the platform uses when a host needs to force a value against a default: a declared, tri-statez.boolean().optional() whose docstring spells out what unset means. scim and sso have neither the declaration nor the tri-state.

            Amplification worth naming, since it is not local to the SCIM line: admin: pluginConfig.admin ?? scimEffective (:2439, mirrored at :5064). A deployment that never asked for the better-auth admin plugin gets it — impersonate-user, set-user-password, ban-user — as a side effect of the same variable, and has the same non-existent means of declining it.

            Options

            • A. Declare scim, sso, ssoDomainVerification in AuthPluginConfigSchema as tri-state z.boolean().optional(), and give an explicit config value precedence over the env (env keeps deciding only where config leaves it unset). Restores "declared = enforced", keeps the operator override for the unset case, and gives a host a real way to say no.
            • B. Keep env-wins, add a separate narrow host-forced channel (a distinct declared field, or an option that scopes which env overrides an instance honors).
            • C. Declare the keys but keep them env-subordinate, and document them as advisory. Cheapest, and leaves the misleading-affordance half unfixed.

            Recommendation is A: it is the only option under which the key means what an author reading it would assume, and it is the direction the platform already took for dynamicClientRegistration. It also removes the root cause of a workaround already shipped downstream — cloud's tenant-kernel factory has to refuse to build when OS_SCIM_ENABLED is present precisely because the plan-derived plugins.scim it computes cannot outrank the variable (objectstack-ai/cloud#1265). Under A that plan gate would simply be authoritative.

            Note on scope discipline: A changes documented precedence for these three keys only, and only for the case where a host states a value explicitly — no deployment that leaves them unset sees any change.

            Not reproduced against a running deployment; this is read off the source at the SHA above plus the corroborating comments in cloud's own artifact-kernel-factory.scim.test.ts / .scim-env-guard.test.ts, which independently document the same resolution order.

            Metadata

            Metadata

            Assignees

            Labels

            bugSomething isn't workingdomain:specpriority:p1High: required for production / M2

            Type

            No type

            Projects

            No projects

              Milestone

              No milestone

              Relationships

              None yet

              Development

              No branches or pull requests

              Issue actions

              , 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [finding] `plugins.scim` / `plugins.sso` are undeclared config keys that read as configuration but cannot ever change the outcome — the env var always outranks them · Issue #13439 · objectstack-ai/objectstack · GitHub
              Skip to content

              [finding] plugins.scim / plugins.sso are undeclared config keys that read as configuration but cannot ever change the outcome — the env var always outranks them #13439

              Description

              @baozhoutao

              Surfaced from the cloud side while implementing objectstack-ai/cloud#1451 (hardening the cloud control plane's own AuthPlugin against an ambient OS_SCIM_ENABLED). Filed unassigned, recording a framework contract gap; the cloud card is parked on the decision this issue describes.

              Measured at 1a540e82b1421c26ea036ff67e381689075b501c (the SHA cloud/.objectstack-sha currently pins) and re-checked on main at the same line — no drift between them.

              The two halves

              1. The keys are not declared.AuthPluginConfigSchema (packages/spec/src/system/auth-config.zod.ts:20) declares exactly ten keys: organization, twoFactor, passkeys, passwordRejectBreached, magicLink, oidcProvider, dynamicClientRegistration, deviceAuthorization, admin, phoneNumber. buildPluginList nevertheless reads three more off the same object through an any cast (packages/plugins/plugin-auth/src/auth-manager.ts):

              :2426 const scimEffective = scimFromEnv ?? (pluginConfig as any).scim ?? false;
              :2445 scim: scimEffective,
              :2446 sso: ssoFromEnv ?? (pluginConfig as any).sso ?? false,
              ssoDomainVerification: ssoDomainVerifyFromEnv ?? (pluginConfig as any).ssoDomainVerification ?? false,
              

              So plugins.scim is a key an author can write, that typechecks only because of the cast, that no schema documents, and that no publish-time check would ever reject or confirm.

              2. Where it IS read, the env var always wins.readBooleanEnv (auth-manager.ts:256) returns undefined only when the variable is absent; any present value — including the empty string — resolves to a boolean. Because scimFromEnv is the left operand of the ?? chain, a host that writes plugins: { scim: false } gets no effect at all whenever OS_SCIM_ENABLED is set. The same holds for sso / OS_SSO_ENABLED.

              The precedence itself is deliberate and documented in the block comment above it ("the env var WINS over the config-file setting so platform operators can override per-environment without touching the application bundle"). The gap is not that operators can override — it is that a host has no counterpart: there is no declared way for the code that constructs AuthPlugin to state a value the deployment env cannot silently outrank.

              Why this is worth a decision rather than a patch

              The combination is the sharp part. An undeclared key that is read anyway reads, to any author, as the supported way to say "not on this surface" — and it is silently inert in exactly the deployments where it matters. The cloud-side card walked into precisely that: its accepted fix sketch was "pass an explicit scim: false at the control plane's AuthPlugin construction", which the reading above shows would have shipped a line that looks like a security control, passes review, passes typecheck, and changes nothing.

              dynamicClientRegistration already shows the shape the platform uses when a host needs to force a value against a default: a declared, tri-statez.boolean().optional() whose docstring spells out what unset means. scim and sso have neither the declaration nor the tri-state.

              Amplification worth naming, since it is not local to the SCIM line: admin: pluginConfig.admin ?? scimEffective (:2439, mirrored at :5064). A deployment that never asked for the better-auth admin plugin gets it — impersonate-user, set-user-password, ban-user — as a side effect of the same variable, and has the same non-existent means of declining it.

              Options

              • A. Declare scim, sso, ssoDomainVerification in AuthPluginConfigSchema as tri-state z.boolean().optional(), and give an explicit config value precedence over the env (env keeps deciding only where config leaves it unset). Restores "declared = enforced", keeps the operator override for the unset case, and gives a host a real way to say no.
              • B. Keep env-wins, add a separate narrow host-forced channel (a distinct declared field, or an option that scopes which env overrides an instance honors).
              • C. Declare the keys but keep them env-subordinate, and document them as advisory. Cheapest, and leaves the misleading-affordance half unfixed.

              Recommendation is A: it is the only option under which the key means what an author reading it would assume, and it is the direction the platform already took for dynamicClientRegistration. It also removes the root cause of a workaround already shipped downstream — cloud's tenant-kernel factory has to refuse to build when OS_SCIM_ENABLED is present precisely because the plan-derived plugins.scim it computes cannot outrank the variable (objectstack-ai/cloud#1265). Under A that plan gate would simply be authoritative.

              Note on scope discipline: A changes documented precedence for these three keys only, and only for the case where a host states a value explicitly — no deployment that leaves them unset sees any change.

              Not reproduced against a running deployment; this is read off the source at the SHA above plus the corroborating comments in cloud's own artifact-kernel-factory.scim.test.ts / .scim-env-guard.test.ts, which independently document the same resolution order.

              Metadata

              Metadata

              Assignees

              Labels

              bugSomething isn't workingdomain:specpriority:p1High: required for production / M2

              Type

              No type

              Projects

              No projects

                Milestone

                No milestone

                Relationships

                None yet

                Development

                No branches or pull requests

                Issue actions

                , 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); [finding] `plugins.scim` / `plugins.sso` are undeclared config keys that read as configuration but cannot ever change the outcome — the env var always outranks them · Issue #13439 · objectstack-ai/objectstack · GitHub
                Skip to content

                [finding] plugins.scim / plugins.sso are undeclared config keys that read as configuration but cannot ever change the outcome — the env var always outranks them #13439

                Description

                @baozhoutao

                Surfaced from the cloud side while implementing objectstack-ai/cloud#1451 (hardening the cloud control plane's own AuthPlugin against an ambient OS_SCIM_ENABLED). Filed unassigned, recording a framework contract gap; the cloud card is parked on the decision this issue describes.

                Measured at 1a540e82b1421c26ea036ff67e381689075b501c (the SHA cloud/.objectstack-sha currently pins) and re-checked on main at the same line — no drift between them.

                The two halves

                1. The keys are not declared.AuthPluginConfigSchema (packages/spec/src/system/auth-config.zod.ts:20) declares exactly ten keys: organization, twoFactor, passkeys, passwordRejectBreached, magicLink, oidcProvider, dynamicClientRegistration, deviceAuthorization, admin, phoneNumber. buildPluginList nevertheless reads three more off the same object through an any cast (packages/plugins/plugin-auth/src/auth-manager.ts):

                :2426 const scimEffective = scimFromEnv ?? (pluginConfig as any).scim ?? false;
                :2445 scim: scimEffective,
                :2446 sso: ssoFromEnv ?? (pluginConfig as any).sso ?? false,
                ssoDomainVerification: ssoDomainVerifyFromEnv ?? (pluginConfig as any).ssoDomainVerification ?? false,
                

                So plugins.scim is a key an author can write, that typechecks only because of the cast, that no schema documents, and that no publish-time check would ever reject or confirm.

                2. Where it IS read, the env var always wins.readBooleanEnv (auth-manager.ts:256) returns undefined only when the variable is absent; any present value — including the empty string — resolves to a boolean. Because scimFromEnv is the left operand of the ?? chain, a host that writes plugins: { scim: false } gets no effect at all whenever OS_SCIM_ENABLED is set. The same holds for sso / OS_SSO_ENABLED.

                The precedence itself is deliberate and documented in the block comment above it ("the env var WINS over the config-file setting so platform operators can override per-environment without touching the application bundle"). The gap is not that operators can override — it is that a host has no counterpart: there is no declared way for the code that constructs AuthPlugin to state a value the deployment env cannot silently outrank.

                Why this is worth a decision rather than a patch

                The combination is the sharp part. An undeclared key that is read anyway reads, to any author, as the supported way to say "not on this surface" — and it is silently inert in exactly the deployments where it matters. The cloud-side card walked into precisely that: its accepted fix sketch was "pass an explicit scim: false at the control plane's AuthPlugin construction", which the reading above shows would have shipped a line that looks like a security control, passes review, passes typecheck, and changes nothing.

                dynamicClientRegistration already shows the shape the platform uses when a host needs to force a value against a default: a declared, tri-statez.boolean().optional() whose docstring spells out what unset means. scim and sso have neither the declaration nor the tri-state.

                Amplification worth naming, since it is not local to the SCIM line: admin: pluginConfig.admin ?? scimEffective (:2439, mirrored at :5064). A deployment that never asked for the better-auth admin plugin gets it — impersonate-user, set-user-password, ban-user — as a side effect of the same variable, and has the same non-existent means of declining it.

                Options

                • A. Declare scim, sso, ssoDomainVerification in AuthPluginConfigSchema as tri-state z.boolean().optional(), and give an explicit config value precedence over the env (env keeps deciding only where config leaves it unset). Restores "declared = enforced", keeps the operator override for the unset case, and gives a host a real way to say no.
                • B. Keep env-wins, add a separate narrow host-forced channel (a distinct declared field, or an option that scopes which env overrides an instance honors).
                • C. Declare the keys but keep them env-subordinate, and document them as advisory. Cheapest, and leaves the misleading-affordance half unfixed.

                Recommendation is A: it is the only option under which the key means what an author reading it would assume, and it is the direction the platform already took for dynamicClientRegistration. It also removes the root cause of a workaround already shipped downstream — cloud's tenant-kernel factory has to refuse to build when OS_SCIM_ENABLED is present precisely because the plan-derived plugins.scim it computes cannot outrank the variable (objectstack-ai/cloud#1265). Under A that plan gate would simply be authoritative.

                Note on scope discipline: A changes documented precedence for these three keys only, and only for the case where a host states a value explicitly — no deployment that leaves them unset sees any change.

                Not reproduced against a running deployment; this is read off the source at the SHA above plus the corroborating comments in cloud's own artifact-kernel-factory.scim.test.ts / .scim-env-guard.test.ts, which independently document the same resolution order.

                Metadata

                Metadata

                Assignees

                Labels

                bugSomething isn't workingdomain:specpriority:p1High: required for production / M2

                Type

                No type

                Projects

                No projects

                  Milestone

                  No milestone

                  Relationships

                  None yet

                  Development

                  No branches or pull requests

                  Issue actions