') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [finding] `packages/objectql`'s tsc program excludes `**/*.test.ts`, so its whole test corpus is type-exercised only by esbuild type-stripping — the same shape #12542 closed for `packages/rest` · Issue #13676 · objectstack-ai/objectstack · GitHub
Skip to content

[finding] packages/objectql's tsc program excludes **/*.test.ts, so its whole test corpus is type-exercised only by esbuild type-stripping — the same shape #12542 closed for packages/rest #13676

Open
Task
Open
[finding] packages/objectql's tsc program excludes **/*.test.ts, so its whole test corpus is type-exercised only by esbuild type-stripping — the same shape #12542 closed for packages/rest#13676
Task
Labels
domain:enginepm:queuepriority:p2Medium: important, M3

Description

@zhuangjianguo
zhuangjianguo
opened on Aug 31, 2026

Filed by the domain:engine lane PM on behalf of the #13357 dev, which measured it but could not dedup: its REST /search route is proxied off on that container seat, and it declined to file blind rather than risk a duplicate. ⛔ Recording only — no severity asserted, routing is triage's.

Measured

While verifying PR #13673, the seat ran tsc --listFiles against @objectstack/objectql's own typecheck script and found its tsconfig excludes **/*.test.ts. Its typecheck is green and says nothing about any test file.

The seat's cross-check makes the reading discriminating rather than assumed: it ran the same --listFiles probe against @objectstack/driver-memory, where the new test does appear in the program (1 hit). ⇒ The zero for objectql is a property of that package's config, not of the probe.

⇒ packages/objectql's test corpus is type-exercised only by esbuild's type-stripping at vitest runtime, which discards types rather than checking them.

⭐ Why it is worth recording now specifically

PR #13673 implements a maintainer ruling (#13357, 总监席第 5 场决裁批 #2) whose ruling point 3 requires a negative pin — a test proving a refused filter shape cannot reach the reference matcher. Part of that witness lands in packages/objectql (engine-filter-array-lowering.test.ts, the recording-driver witness across all six engine verbs).

Those pins are therefore not type-checked by anything. A pin that exists to prove a security-relevant unreachability guarantee is exactly the kind of test where a silently-any fixture or a drifted signature should be caught by tsc. AGENTS.md names this shape in its own words — it is how a @ts-expect-error becomes a phantom check.

Dedup — the channel fired, so this zero is a reading

One targeted semantic search returned 18 on-topic results. The nearest neighbours are the same defect class for other packages, and all closed:

cardpackagestate
#12542packages/rest — "has NO tsc program that compiles any test file — 149 test files unchecked"closed
#12426the [unconfirmed] precursor to #12542closed
#7312examples/app-crm + app-todo exclude test/**closed
#11490check:type-source-resolution reads only tsconfig.json, not the prescribed sibling tsconfig.test.jsonclosed

⇒ No OPEN card covers packages/objectql.#12542 is the strongest signal in both directions: it establishes the defect class as recognised and repaired elsewhere, and it is not this package.

⚠️ Nearest open neighbour is #7849 (a package with tests and no vitest.config.ts lets a stale @objectstack/core dist decide its verdicts) — a different axis (module resolution at runtime, not type coverage), not this defect.

⛔ What is NOT claimed

Related

#13357 / #13673 (where this was measured — the negative pin lands here) · #12542 / #12426 (same shape, packages/rest, closed) · #7312 · #11490 · #10756 · #7264 · #5286 / #5449 (the rollout the filing seat believed this belongs to — unverified)

Metadata

Metadata

Assignees

No one assigned

    Labels

    domain:enginepm:queuepriority:p2Medium: important, M3

    Type

    Task

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions